Skip to content
Snippets Groups Projects
  1. Apr 03, 2020
  2. Apr 01, 2020
  3. Mar 27, 2020
  4. Mar 24, 2020
    • Axel Naumann's avatar
      [treeplayer] Construct TThreadedObject after enabling IMT: · 99af46c1
      Axel Naumann authored
      Before, the TThreadedObject had to guess 64 slots were enough for the use case of TTreeProcessorMT - and with 256 cores that was not the case.
      Be explicit about the use of IMT for TThreadedObject by providing the new argument.
      IMT is enabled before the construction of the TThreadedObject (and thus TThreadedObject now knows how many slots to expect), because the pool is constructed before.
      If the order ever gets changes, the TThreadedObject will complain as it is now told to expect IMT usage.
      
      A future TTreeProcessorMT ctor overload might provide a specific thread count, and can pass it down to TThreadedObject.
      99af46c1
  5. Mar 01, 2020
    • Bertrand Bellenot's avatar
      Fix Jira issue #ROOT-10561 [TTreeProcessorMT] Breaks without EnableImplicitMT on · 6d3cbf05
      Bertrand Bellenot authored
      Move the creation of `TThreadExecutor pool` before the call of `Internal::MakeClusters()`, to make sure it is properly initialized when calling `ROOT::Internal::TPoolManager::GetPoolSize()` (via `ROOT::GetImplicitMTPoolSize()`)
      This fix a crash with the `gtest-tree-treeplayer-test-treeprocessormt` test on Windows, due to a division by zero at line 224 in `TTreeProcessorMT`
      6d3cbf05
  6. Feb 05, 2020
    • Stefan Wunsch's avatar
      [ROOT-10508] Fix TTreeProcessorMT for unnamed chain as friend · c279445e
      Stefan Wunsch authored
      * Retrieves correctly the name of the trees building the chain if the
        chain itself does not has a name. This happens if the default
        constructor for TChain is used and the name of the tree is retrieved
        via the string given to `TChain::AddFile("file.root/treeName")`.
      * This does not fix the issue entirely since the FriendInfo needs a
        refactoring. The FriendInfo assumes that in a chain each tree has the
        same name, which could not hold true.
      c279445e
  7. Jul 11, 2019
  8. May 10, 2019
  9. May 09, 2019
  10. Apr 16, 2019
  11. Mar 13, 2019
  12. Jan 21, 2019
    • Danilo Piparo's avatar
      [TTreeProcessorMT][ROOT-9791] Create a max number of tasks per file processed · 4e2ad81f
      Danilo Piparo authored
      and not one task per cluster.
      We need to "fuse" together clusters if the number of clusters is to big with respect to
      the number of workers, otherwise we can incur in an overhead which is so big to make
      the parallelisation detrimental for performance.
      For example, this is the case when following a merging of many small files a file
      contains a tree with many entries and with clusters of just a few entries.
      The criterium according to which we fuse clusters together is to have at most
      TTreeProcessorMT::GetMaxTasksPerFilePerWorker() clusters per file per slot.
      For example: given 2 files and 16 workers, at most 16 * 2 * TTreeProcessorMT::GetMaxTasksPerFilePerWorker()
      clusters will be created, at most 16 * TTreeProcessorMT::GetMaxTasksPerFilePerWorker() per file.
      4e2ad81f
  13. Dec 05, 2018
  14. Nov 13, 2018
  15. Oct 15, 2018
  16. Oct 09, 2018
  17. Sep 19, 2018
  18. Jun 09, 2018
  19. Jun 08, 2018
  20. Jun 06, 2018
Loading