Error in <TStatusBitsChecker>: In TProofPlayer class hierarchy, there are duplicates bits:
Error in <TStatusBitsChecker>:    Bit  16 used in TProofPlayer as kIsProcessing
Error in <TStatusBitsChecker>:    Bit  16 used in TVirtualProofPlayer as kIsSubmerger

Error in <TStatusBitsChecker>: In TProofServ class hierarchy, there are duplicates bits:
Error in <TStatusBitsChecker>:    Bit  16 used in TProofServ as kHighMemory
Error in <TStatusBitsChecker>:    Bit  16 used in TApplication as kDefaultApplication

This refactors the CMake build files to no longer manually call
the CMake functions for generating and linking the dicionairies.
One reason is to reduce boilerplate, the other is that it is now
no longer possible to have naming mismatches between the dictionary
generation arguments and linking function arguments which was causing
the race conditions we had in our build system.

This also now follows more strictly the separation between dependencies
like Math, Tree and Core and pure linking flags to external libraries.

This property was renamed in CMake 2.8.12, so we now should use
the newer name on recent CMake versions. We don't need to support
the pre-2.8.12 versions of CMake because we anyway have code
that requires 3.x.

ROOT_GENERATE_DICTIONARY allows to specify dependencies, but we currently
don't actually specify those. As we need this for getting the module
dependencies right (as we can't build missing modules on demand), we should
add those dependencies here. Then those dependencies propagate to the
rootcling invocation which will in the future also generate the C++ module
for the selected dictionary.

This is already the case in CMake builds, adding it to make
behavior between build types more uniform. The option is not
added for ICC since it does not have such option and will
generate warnings about ignored flags. Also remove some old
unused options.

ClassImp is a macro defined in Rtypes.h. It can be written without trailing
semicolon. However, clang-format is based on lexing and it doesn't know at
all about preprocessors and how to expand macros. When visiting ClassImp(X)
it thinks this is not a completed entity (as it doesn't expand macros) and
considers the next line as continuation of the previous.

Inserting a semicolon fixes the issue and makes formatting with clang-format
in the ROOT codebase less tricky.

gROOTMutex (equal to gInterpreterMutex) are always set at the same type as gGlobalMutex so there is no need to use R__LOCKGUARD2

Fix for coverity #61340 #61356 #61397 #61413 #61359 #44337 #54858 #54872 #61261 #62101 #62104 #56175

Many headers contains redundant header guards around #include directives:

    #ifndef ROOT_TTree
    #include "TTree.h"
    #endif

This patch removes the #ifndef's around these includes as they
don't serve any pratical purpose anymore and are no longer part
of the current ROOT coding convention.

This patch also fixes the 153 typos that are contained in the
symbols of the #ifndef directives.

Signed-off-by: Vassil Vassilev <vvasilev@cern.ch>

This reverts commit 04178a28.

This is not needed anymore because cling can bridge well compiled and interpreted worlds.

This reverts commit 5c076c6c.

This reverts commit b406328d, reversing
changes made to 318c7a47.

Replaces if(builtin_foo) statements with explicit support in the
various ROOT macros.

This removes ROOT_ADD_BUILTIN_DEPENDENCIES and adds BUILD_BYPRODUCTS
for the external projects.  This way, the build system can explicitly
depend on the output file of the external project instead of introducing
a hidden dependency..

Make cannot deal with 'export *', they have to be escaped and fixed later on.

This is the recommended way of using the modules feature and should pave our way
of enabling -fmodules-local-submodules-visibility mode.

Use the standard #include <typeinfo> and #include <iosfwd> instead.

This remove duplicate definitions and duplicate default argument errors when
building modules for proof.

Our two build systems can generate almost entirely a modulemap file laying out
one module per library. Due to some non-modular implementation in ROOT's core we
still need to treat some header files specially.

This patch appends modular header files to the modulemap while skipping the
predefined ones. Configure-make relates all headers that are installed in
$ROOTSYS/include to their library whereas relates only headers which are part of
library's dictionary.

rpdutils is under net, not proof

rpdp headers are not part of the ROOT public API and thus should not
be visible in include/. They were simply because multiple ROOT modules
were including them, and we had no way to specify that other than
publishing them. Now we have a new directory next to src/ and inc/:
res/ (as in "reserved" or "restricted"), signalling that these headers
are not public but used by other ROOT modules.

Update the Moduke.mk-s accordingly.

Move a few really private headers into their src/ directories.

Remove residual symlink creation (after optimization introduced in 0a976f4a).
For PROOF-Lite, make sure that all the relevant files (including .pcm) are present in the cache.