Skip to content
Snippets Groups Projects
  1. Sep 03, 2018
  2. Aug 30, 2018
  3. May 16, 2018
  4. May 04, 2018
  5. Apr 10, 2018
    • Wolf Behrenhoff's avatar
      Correct misleading indentation · 417cce0c
      Wolf Behrenhoff authored
      In case of VariableTransform.cxx, reformatted the whole file as it was
      using 4 whitespaces indentation and had misleading indentation on the
      bottom.
      417cce0c
  6. Mar 27, 2018
  7. Mar 20, 2018
  8. Feb 06, 2018
  9. Dec 04, 2017
    • Julien Nabet's avatar
      cppcheck: fix some reports · cd6fa81b
      Julien Nabet authored
      [net/monalisa/src/TMonaLisaWriter.cxx:956] -> [net/monalisa/src/TMonaLisaWriter.cxx:957]: (error) Iterator 'iter' used after element has been erased.
      [proof/proofd/src/XrdProofdProofServMgr.cxx:4648] -> [proof/proofd/src/XrdProofdProofServMgr.cxx:4646]: (error) Iterator 'iter' used after element has been erased.
      
      [math/minuit2/src/Minuit2Minimizer.cxx:669] -> [math/minuit2/src/Minuit2Minimizer.cxx:669]: (style) Same expression on both sides of '||'.
      [math/minuit2/src/Minuit2Minimizer.cxx:736] -> [math/minuit2/src/Minuit2Minimizer.cxx:736]: (style) Same expression on both sides of '||'.
      [math/minuit2/src/Minuit2Minimizer.cxx:753] -> [math/minuit2/src/Minuit2Minimizer.cxx:753]: (style) Same expression on both sides of '||'.
      
      [tree/tree/src/TBasket.cxx:852]: (style) Redundant condition: If 'flag >= 80', the comparison 'flag' is always true.
      [misc/table/src/TFileIter.cxx:467] -> [misc/table/src/TFileIter.cxx:468]: (warning) Identical condition 'thisRunNumber<runNumber', second condition is always false
      
      [math/mathcore/src/TMath.cxx:826]: (style) Array index 'ia' is used before limits check.
      [math/mathcore/src/TMath.cxx:830]: (style) Array index 'ib' is used before limits check.
      [math/mathcore/src/triangle.c:15434]: (style) Array index 'aspectindex' is used before limits check.
      [roofit/roofit/src/RooIntegralMorph.cxx:375]: (style) Array index 'igapHigh' is used before limits check.
      
      [core/winnt/src/TWinNTSystem.cxx:5035]: (style) Statements following return, break, continue, goto or throw will never be executed.
      [tree/treeplayer/src/TSelectorDraw.cxx:380]: (style) Statements following return, break, continue, goto or throw will never be executed.
      
      [net/auth/src/TAuthenticate.cxx:4205]: (error) Resource leak: fd
      [roofit/roofitcore/src/BidirMMapPipe.cxx:1880]: (error) Memory leak: s
      [tree/tree/src/TLeaf.cxx:222]: (error) Memory leak: countname
      [tree/tree/src/TLeaf.cxx:226]: (error) Memory leak: countname
      [tmva/tmva/src/MethodBase.cxx:2783]: (error) Memory leak: pdfS
      [tmva/tmva/src/MethodBase.cxx:2783]: (error) Memory leak: pdfB
      
      [roofit/roofitcore/src/RooAbsArg.cxx:280]: (style) Redundant checking of STL container element existence before removing it.
      
      [core/dictgen/src/rootcling_impl.cxx:457]: (performance) Possible inefficient checking for 'fieldSelRules' emptiness.
      [core/dictgen/src/rootcling_impl.cxx:4573]: (performance) Possible inefficient checking for 'filesIncludedByLinkdef' emptiness.
      [gui/canvaspainter/v7/src/TCanvasPainter.cxx:322]: (performance) Possible inefficient checking for 'fWebConn' emptiness.
      [gui/canvaspainter/v7/src/TCanvasPainter.cxx:374]: (performance) Possible inefficient checking for 'fCmds' emptiness.
      [gui/canvaspainter/v7/src/TCanvasPainter.cxx:419]: (performance) Possible inefficient checking for 'fWebConn' emptiness.
      [gui/canvaspainter/v7/src/TCanvasPainter.cxx:475]: (performance) Possible inefficient checking for 'fWebConn' emptiness.
      [gui/canvaspainter/v7/src/TCanvasPainter.cxx:587]: (performance) Possible inefficient checking for 'fCmds' emptiness.
      [gui/canvaspainter/v7/src/TCanvasPainter.cxx:787]: (performance) Possible inefficient checking for 'fCmds' emptiness.
      [html/src/TDocParser.cxx:684]: (performance) Possible inefficient checking for 'currentType' emptiness.
      [proof/proofd/src/XrdProofdManager.cxx:804]: (performance) Possible inefficient checking for 'uwrks' emptiness.
      [proof/proofd/src/XrdProofdSandbox.cxx:467]: (performance) Possible inefficient checking for 'staglst' emptiness.
      [proof/proofd/src/XrdProofdSandbox.cxx:571]: (performance) Possible inefficient checking for 'actln' emptiness.
      [roofit/roofitcore/src/RooSimWSTool.cxx:574]: (performance) Possible inefficient checking for 'slist' emptiness.
      
      all the reports Prefer prefix ++/-- operators for non-primitive types
      cd6fa81b
  10. Dec 01, 2017
  11. Nov 28, 2017
  12. Oct 19, 2017
    • Bertrand Bellenot's avatar
      Fix some more warnings on Windows · 2fe017bc
      Bertrand Bellenot authored
      Fix mostly warning C4138: '*/' found outside of comment. But also:
      warning C4101: 'hProcess': unreferenced local variable
      warning C4005: 'open': macro redefinition
      warning C4002: too many actual parameters for macro 'open'
      warning C4091: 'static ': ignored on left of '' when no variable is declared
      2fe017bc
  13. Oct 09, 2017
  14. Oct 03, 2017
  15. Sep 04, 2017
  16. Sep 01, 2017
    • Philippe Canal's avatar
      Change value of TProofServ::kHighMemory and TVirtualProofPlayer::kIsSubmerger. · 2e6a11d1
      Philippe Canal authored
      Error in <TStatusBitsChecker>: In TProofPlayer class hierarchy, there are duplicates bits:
      Error in <TStatusBitsChecker>:    Bit  16 used in TProofPlayer as kIsProcessing
      Error in <TStatusBitsChecker>:    Bit  16 used in TVirtualProofPlayer as kIsSubmerger
      
      Error in <TStatusBitsChecker>: In TProofServ class hierarchy, there are duplicates bits:
      Error in <TStatusBitsChecker>:    Bit  16 used in TProofServ as kHighMemory
      Error in <TStatusBitsChecker>:    Bit  16 used in TApplication as kDefaultApplication
      2e6a11d1
  17. Aug 23, 2017
  18. Jul 28, 2017
    • Raphael Isemann's avatar
      Use ROOT_STANDARD_LIBRARY_PACKAGE where possible [NFC] · ac0de75b
      Raphael Isemann authored
      This refactors the CMake build files to no longer manually call
      the CMake functions for generating and linking the dicionairies.
      One reason is to reduce boilerplate, the other is that it is now
      no longer possible to have naming mismatches between the dictionary
      generation arguments and linking function arguments which was causing
      the race conditions we had in our build system.
      
      This also now follows more strictly the separation between dependencies
      like Math, Tree and Core and pure linking flags to external libraries.
      ac0de75b
  19. Jul 25, 2017
  20. Jul 12, 2017
    • Raphael Isemann's avatar
      Add missing dependencies to ROOT_GENERATE_DICTIONARY · 8a646b53
      Raphael Isemann authored
      ROOT_GENERATE_DICTIONARY allows to specify dependencies, but we currently
      don't actually specify those. As we need this for getting the module
      dependencies right (as we can't build missing modules on demand), we should
      add those dependencies here. Then those dependencies propagate to the
      rootcling invocation which will in the future also generate the C++ module
      for the selected dictionary.
      8a646b53
    • Guilherme Amadio's avatar
      Add -Wno-nonnull-compare to proof/proofd in classic builds · 233fbdee
      Guilherme Amadio authored
      This is already the case in CMake builds, adding it to make
      behavior between build types more uniform. The option is not
      added for ICC since it does not have such option and will
      generate warnings about ignored flags. Also remove some old
      unused options.
      233fbdee
  21. Jun 06, 2017
    • Vassil Vassilev's avatar
      Try silencing gcc indentation warning. · 4cac5a12
      Vassil Vassilev authored
      4cac5a12
    • Vassil Vassilev's avatar
      Do not confuse clang-format. · 68a8a335
      Vassil Vassilev authored
      ClassImp is a macro defined in Rtypes.h. It can be written without trailing
      semicolon. However, clang-format is based on lexing and it doesn't know at
      all about preprocessors and how to expand macros. When visiting ClassImp(X)
      it thinks this is not a completed entity (as it doesn't expand macros) and
      considers the next line as continuation of the previous.
      
      Inserting a semicolon fixes the issue and makes formatting with clang-format
      in the ROOT codebase less tricky.
      68a8a335
  22. Jun 01, 2017
  23. May 16, 2017
  24. May 15, 2017
  25. May 07, 2017
  26. Apr 12, 2017
  27. Feb 14, 2017
    • Raphael Isemann's avatar
      Remove all redundant header guards around include directives · 04fe6d5d
      Raphael Isemann authored
      
      Many headers contains redundant header guards around #include directives:
      
          #ifndef ROOT_TTree
          #include "TTree.h"
          #endif
      
      This patch removes the #ifndef's around these includes as they
      don't serve any pratical purpose anymore and are no longer part
      of the current ROOT coding convention.
      
      This patch also fixes the 153 typos that are contained in the
      symbols of the #ifndef directives.
      
      Signed-off-by: default avatarVassil Vassilev <vvasilev@cern.ch>
      04fe6d5d
  28. Feb 09, 2017
  29. Jan 28, 2017
Loading