Skip to content
Snippets Groups Projects
  1. Sep 30, 2018
  2. Sep 28, 2018
    • Philippe Canal's avatar
      Fix ROOT-9662 race condition in TStreamerInfo loading. · b6523df2
      Philippe Canal authored
      When noting that a TStreamerInfo set has already been processed, we
      must do it in 3 separates steps:
        - check it was seen before
        - read and process the set
        - record that the set as been seen.
      
      The previous situation:
        - check and record that the set as been seen
        - read and process the set
      led to a race condition if a second thread was checking the same
      set before the second step was completed (in which case the
      second thread was believing that the set was process and looking
      for the result of the process (one of the StreamerInfo) but could
      not find it.
      
      We extend RConcurrentHashColl to have 2 new operations
        - standalone Hash calculation
        - standalone Find of hash
        - standalone Insert of hash.
      and we use it to split the check and the recording as described
      previously.
      
      (this is an addendum to 95bf468438)
      b6523df2
  3. Sep 24, 2018
  4. Aug 30, 2018
  5. Aug 20, 2018
  6. Aug 17, 2018
    • Philippe Canal's avatar
      Additional fix for rule scheduling in TBranchElement. · 8b7bc79b
      Philippe Canal authored
      This is an additional fix for https://github.com/cms-sw/cmssw/pull/22594
      
      If one of the class associated with a TBranchElement has a base class and/or sub-object class that
      has a rule that requires a cache (onfileObject) object to stage the original data *but* does not
      have branch in the TTree that also neeed the same cache object, we need to associate a cache
      object with the StreamerInfoAction sequence that needs it (associated with a higher level branch)
      and give it ownership of this cache object)
      8b7bc79b
  7. Aug 16, 2018
  8. Aug 13, 2018
  9. Aug 03, 2018
  10. Aug 02, 2018
  11. Jul 18, 2018
  12. Jul 04, 2018
  13. Jun 27, 2018
  14. Jun 26, 2018
  15. Jun 25, 2018
  16. Jun 14, 2018
  17. Jun 04, 2018
  18. Jun 01, 2018
  19. May 09, 2018
    • Philippe Canal's avatar
      Avoid out-of-bound read. · 73e0e0a8
      Philippe Canal authored
      Note: This read was however harmless as the loop cut short immediately thereafter
      without using the result of the read.
      73e0e0a8
  20. Apr 27, 2018
  21. Apr 19, 2018
  22. Apr 18, 2018
Loading