Skip to content
Snippets Groups Projects
  1. Apr 21, 2021
  2. Apr 20, 2021
  3. Apr 19, 2021
    • Vincenzo Eduardo Padulano's avatar
      [DF] Give priority to user provided npartitions · f040e051
      Vincenzo Eduardo Padulano authored
      The distributed RDataFrame constructor accepts an optional `npartitions` keyword argument. Previously, if this argument was provided by the user, it set the number of partitions in which the rdf would split the distributed computations.
      But then, right before starting the execution, the distributed backend implementation tried to optimize this number. In the case of Spark, an educated guess for the number of partitions would be spark.executor.cores * spark.executor.instances, that is the number of distributed nodes times the number of cores used for each node.
      If we let this optimization happen just before the start of the execution, it means we completely disregard the user provided value for `npartitions`. Instead, the backend guessing at a number of partitions should happen only if the user doesn't supply one.
      This commit addresses the issue by moving the call to `backend.optimize_npartitions` inside the initialization of the distributed dataframe object, plus adds a couple of tests to check the behaviour in the Spark backend.
      f040e051
    • Edoardo's avatar
      Added missing include for std::string · dff6c9ef
      Edoardo authored
      Solved missing include of std::string referenced in error handling. Needed to compile using clang and libc++
      dff6c9ef
    • Olivier Couet's avatar
      TFile doc code text size (#7921) · 73be21d8
      Olivier Couet authored
      Is now proportional to the browser size.
      73be21d8
    • Bertrand Bellenot's avatar
    • Jonas Rembser's avatar
      [RF] Implement move constructor/assignment operator of RooLinkedListIter · f7adfb5c
      Jonas Rembser authored
      Setting the move constructor and move assignment operator to = default
      causes linker errors because the copy assignment operator is not
      implemented in the TIterator base class.
      
      Having the RooLinkedListIter move constructor and assignment operators
      work is important to keep user code compatibility.
      f7adfb5c
    • Jonas Rembser's avatar
      [RF] Rename RooHistFunc::getObservables · d2e8a1cb
      Jonas Rembser authored
      Rename RooHistFunc::getObservables to not hide
      RooAbsArg::getObservables.
      d2e8a1cb
    • Pratyush Das's avatar
      [Cling] Add GitHub issue template · 77293979
      Pratyush Das authored
      Template taken from root-project/root's issue template
      77293979
  4. Apr 17, 2021
    • Enrico Guiraud's avatar
      cf7902db
    • Enrico Guiraud's avatar
      [treereader][NFC] Format fixes to a test · 4f6acb6d
      Enrico Guiraud authored
      4f6acb6d
    • Enrico Guiraud's avatar
      [treereader] Try harder when looking for a leaf · 3b80d3c9
      Enrico Guiraud authored
      Before this patch, given a TTree with a branch with name different
      from its leaf, e.g. like this:
      
      ```
      *Br    0 :NUD_total_ADC : nud_total_adc/D
      ```
      
      TTreeReaderValue failed to retrieve the leaf when the named passed
      to the constructor was just "NUD_total_ADC" (while it worked fine
      with "NUD_total_ADC.nud_total_adc"). In comparison, in a similar
      situation `TTree::Draw` "tries harder" and it assumes that the
      desired leaf is the first sub-leaf of the specified branch.
      
      With this patch, TTreeReaderValue tries `FindLeaf` after `GetLeaf`
      and as a last resort it picks the branch sub-leaf if it exists and
      it is unique.
      
      This fixes #6881.
      3b80d3c9
    • Enrico Guiraud's avatar
    • Bertrand Bellenot's avatar
      [core] Next bunch of changes for Win64 (#7894) · e74738be
      Bertrand Bellenot authored
      * [core] Next bunch of changes for Win64
      
      - Replace some more `long` types by `Longptr_t`
      - Fix pointer formatting (use `%zx` and `size_t` for architecture dependent format)
      - Fix several `warning C4267: 'argument': conversion from 'size_t' to 'Ssiz_t', possible loss of data`
      
      * [skip-ci] Fix compilation warning on i386 platforms
      
      Fix warning: format ‘%zx’ expects argument of type ‘size_t’, but argument 2 has type ‘Long_t’ {aka ‘long int’} [-Wformat=]
      e74738be
  5. Apr 16, 2021
Loading