Skip to content
Snippets Groups Projects
  1. Apr 20, 2021
  2. Apr 19, 2021
    • Vincenzo Eduardo Padulano's avatar
      [DF] Give priority to user provided npartitions · f040e051
      Vincenzo Eduardo Padulano authored
      The distributed RDataFrame constructor accepts an optional `npartitions` keyword argument. Previously, if this argument was provided by the user, it set the number of partitions in which the rdf would split the distributed computations.
      But then, right before starting the execution, the distributed backend implementation tried to optimize this number. In the case of Spark, an educated guess for the number of partitions would be spark.executor.cores * spark.executor.instances, that is the number of distributed nodes times the number of cores used for each node.
      If we let this optimization happen just before the start of the execution, it means we completely disregard the user provided value for `npartitions`. Instead, the backend guessing at a number of partitions should happen only if the user doesn't supply one.
      This commit addresses the issue by moving the call to `backend.optimize_npartitions` inside the initialization of the distributed dataframe object, plus adds a couple of tests to check the behaviour in the Spark backend.
      f040e051
    • Edoardo's avatar
      Added missing include for std::string · dff6c9ef
      Edoardo authored
      Solved missing include of std::string referenced in error handling. Needed to compile using clang and libc++
      dff6c9ef
    • Olivier Couet's avatar
      TFile doc code text size (#7921) · 73be21d8
      Olivier Couet authored
      Is now proportional to the browser size.
      Unverified
      73be21d8
    • Bertrand Bellenot's avatar
    • Jonas Rembser's avatar
      [RF] Implement move constructor/assignment operator of RooLinkedListIter · f7adfb5c
      Jonas Rembser authored
      Setting the move constructor and move assignment operator to = default
      causes linker errors because the copy assignment operator is not
      implemented in the TIterator base class.
      
      Having the RooLinkedListIter move constructor and assignment operators
      work is important to keep user code compatibility.
      f7adfb5c
    • Jonas Rembser's avatar
      [RF] Rename RooHistFunc::getObservables · d2e8a1cb
      Jonas Rembser authored
      Rename RooHistFunc::getObservables to not hide
      RooAbsArg::getObservables.
      d2e8a1cb
    • Pratyush Das's avatar
      [Cling] Add GitHub issue template · 77293979
      Pratyush Das authored
      Template taken from root-project/root's issue template
      77293979
  3. Apr 17, 2021
    • Enrico Guiraud's avatar
      cf7902db
    • Enrico Guiraud's avatar
      [treereader][NFC] Format fixes to a test · 4f6acb6d
      Enrico Guiraud authored
      4f6acb6d
    • Enrico Guiraud's avatar
      [treereader] Try harder when looking for a leaf · 3b80d3c9
      Enrico Guiraud authored
      Before this patch, given a TTree with a branch with name different
      from its leaf, e.g. like this:
      
      ```
      *Br    0 :NUD_total_ADC : nud_total_adc/D
      ```
      
      TTreeReaderValue failed to retrieve the leaf when the named passed
      to the constructor was just "NUD_total_ADC" (while it worked fine
      with "NUD_total_ADC.nud_total_adc"). In comparison, in a similar
      situation `TTree::Draw` "tries harder" and it assumes that the
      desired leaf is the first sub-leaf of the specified branch.
      
      With this patch, TTreeReaderValue tries `FindLeaf` after `GetLeaf`
      and as a last resort it picks the branch sub-leaf if it exists and
      it is unique.
      
      This fixes #6881.
      3b80d3c9
    • Enrico Guiraud's avatar
    • Bertrand Bellenot's avatar
      [core] Next bunch of changes for Win64 (#7894) · e74738be
      Bertrand Bellenot authored
      * [core] Next bunch of changes for Win64
      
      - Replace some more `long` types by `Longptr_t`
      - Fix pointer formatting (use `%zx` and `size_t` for architecture dependent format)
      - Fix several `warning C4267: 'argument': conversion from 'size_t' to 'Ssiz_t', possible loss of data`
      
      * [skip-ci] Fix compilation warning on i386 platforms
      
      Fix warning: format ‘%zx’ expects argument of type ‘size_t’, but argument 2 has type ‘Long_t’ {aka ‘long int’} [-Wformat=]
      Unverified
      e74738be
  4. Apr 16, 2021
  5. Apr 15, 2021
    • Stefan Wunsch's avatar
    • Olivier Couet's avatar
      Fix some invalid drupal links (#7877) · 32ad6f77
      Olivier Couet authored
      Unverified
      32ad6f77
    • Jonas Rembser's avatar
      [RF] Check if ranges are not overlapping in multi-range fit · 2948dd85
      Jonas Rembser authored
      Events are double counted if one accidentally defines overlapping ranges
      and uses them in a multi-range fit. This happened for example in Jira
      issue ROOT-9548 where the whole dataset was double counted, leading to
      the parameter uncertainties being underestimated by a factor of sqrt(2).
      
      That situation should be avoided. This commit introduces a check for
      overlapping ranges before the multi-range likelihood is created.
      2948dd85
    • Jonas Rembser's avatar
    • Jonas Rembser's avatar
      [RF] Make RooAbsTestStatistic error out if multiple ranges are passed · 86faf3ff
      Jonas Rembser authored
      The RooFit test statistic classes give wrong results if they are
      constructed from multiple comma-separated ranges. This can cause errors,
      such as the one reported in Jira issue ROOT-10038.
      
      This commit suggests to throw an exception if multiple comma-separated
      ranges are detected.
      86faf3ff
    • Jonas Rembser's avatar
      1d8b6a7d
    • Sergey Linev's avatar
      [jsroot] dev 14/04/2021 · 2eb6f392
      Sergey Linev authored
      Fix many warnings, use jquery dialog instead of prompt() or alert()
      2eb6f392
    • Sergey Linev's avatar
      [webgui] provide full path to ping.html file · 4ef698b8
      Sergey Linev authored
      Let run ping.cxx from any other subdir
      4ef698b8
    • Sergey Linev's avatar
    • Stefan Wunsch's avatar
      f08f6402
    • Stefan Wunsch's avatar
      a38d869c
    • Stefan Wunsch's avatar
      [DF] Add tutorial for Describe · fc7af5d3
      Stefan Wunsch authored
      fc7af5d3
    • Stefan Wunsch's avatar
      [DF] Add convenience function Describe · b41922af
      Stefan Wunsch authored
      
      Fixes #7561
      
      Co-authored-by: default avatarEnrico Guiraud <enrico.guiraud@cern.ch>
      b41922af
    • Philippe Canal's avatar
      Use 'Write' iterator when intended. · 1943192c
      Philippe Canal authored
      This makes a difference for associative containers.  For reading the iterator are iterating over the
      'TStaging' object rather than the collection.  For writing we need to iterated over the collection
      1943192c
    • Philippe Canal's avatar
      Redo part of 'Correct FullName of the index leaf of a collection' · 29491057
      Philippe Canal authored
      The intent was to prevent the creation of sub branch with 2 consecutives dots
      and to avoid a dot between the branch name of the collection and the underscore
      for name of the index leaf.
      
      The major problem of the first try is that the name of the top level branch
      was changed from "t." to "t" making existing code search for the branch by
      fullname failing.
      
      Fix #7281
      
      This effectively ammends/corrects d225f942
      
      Before v6.23
      
      ******************************************************************************
      *Tree    :tree      : treelibrated tree                                      *
      *Entries :    10000 : Total =          485042 bytes  File  Size =     177202 *
      *        :          : Tree compression factor =   2.74                       *
      ******************************************************************************
      *Br    0 :t.        : Int_t t._                                              *
      *Entries :    10000 : Total  Size=      83464 bytes  File Size  =      12844 *
      *Baskets :        4 : Basket Size=      32000 bytes  Compression=   6.25     *
      *............................................................................*
      *Br    1 :t..fUniqueID : UInt_t fUniqueID[t._]                               *
      *Entries :    10000 : Total  Size=      80935 bytes  File Size  =      12857 *
      *Baskets :        4 : Basket Size=      32000 bytes  Compression=   6.25     *
      *............................................................................*
      *Br    2 :t..fBits  : UInt_t fBits[t._]                                      *
      *Entries :    10000 : Total  Size=      80903 bytes  File Size  =      12879 *
      *Baskets :        4 : Basket Size=      32000 bytes  Compression=   6.24     *
      *............................................................................*
      *Br    3 :t..e      : Double_t e[t._]                                        *
      *Entries :    10000 : Total  Size=     121029 bytes  File Size  =      65937 *
      *Baskets :        6 : Basket Size=      32000 bytes  Compression=   1.83     *
      *............................................................................*
      *Br    4 :t..t      : Double_t t[t._]                                        *
      *Entries :    10000 : Total  Size=     121029 bytes  File Size  =      71633 *
      *Baskets :        6 : Basket Size=      32000 bytes  Compression=   1.68     *
      *............................................................................*
      
      After the first try:
      
      ******************************************************************************
      *Tree    :tree      : treelibrated tree                                      *
      *Entries :    10000 : Total =          484998 bytes  File  Size =     177400 *
      *        :          : Tree compression factor =   2.73                       *
      ******************************************************************************
      *Br    0 :t         : Int_t t_                                               *
      *Entries :    10000 : Total  Size=      83438 bytes  File Size  =      12838 *
      *Baskets :        4 : Basket Size=      32000 bytes  Compression=   6.26     *
      *............................................................................*
      *Br    1 :t.fUniqueID : UInt_t fUniqueID[t_]                                 *
      *Entries :    10000 : Total  Size=      80925 bytes  File Size  =      12852 *
      *Baskets :        4 : Basket Size=      32000 bytes  Compression=   6.25     *
      *............................................................................*
      *Br    2 :t.fBits   : UInt_t fBits[t_]                                       *
      *Entries :    10000 : Total  Size=      80893 bytes  File Size  =      12869 *
      *Baskets :        4 : Basket Size=      32000 bytes  Compression=   6.24     *
      *............................................................................*
      *Br    3 :t.e       : Double_t e[t_]                                         *
      *Entries :    10000 : Total  Size=     121017 bytes  File Size  =      66198 *
      *Baskets :        6 : Basket Size=      32000 bytes  Compression=   1.82     *
      *............................................................................*
      *Br    4 :t.t       : Double_t t[t_]                                         *
      *Entries :    10000 : Total  Size=     121017 bytes  File Size  =      71609 *
      *Baskets :        6 : Basket Size=      32000 bytes  Compression=   1.68     *
      *............................................................................*
      
      Now:
      
      ******************************************************************************
      *Tree    :tree      : treelibrated tree                                      *
      *Entries :    10000 : Total =          485003 bytes  File  Size =     177402 *
      *        :          : Tree compression factor =   2.73                       *
      ******************************************************************************
      *Br    0 :t.        : Int_t t_                                               *
      *Entries :    10000 : Total  Size=      83444 bytes  File Size  =      12844 *
      *Baskets :        4 : Basket Size=      32000 bytes  Compression=   6.25     *
      *............................................................................*
      *Br    1 :t.fUniqueID : UInt_t fUniqueID[t_]                                 *
      *Entries :    10000 : Total  Size=      80925 bytes  File Size  =      12852 *
      *Baskets :        4 : Basket Size=      32000 bytes  Compression=   6.25     *
      *............................................................................*
      *Br    2 :t.fBits   : UInt_t fBits[t_]                                       *
      *Entries :    10000 : Total  Size=      80893 bytes  File Size  =      12869 *
      *Baskets :        4 : Basket Size=      32000 bytes  Compression=   6.24     *
      *............................................................................*
      *Br    3 :t.e       : Double_t e[t_]                                         *
      *Entries :    10000 : Total  Size=     121017 bytes  File Size  =      66198 *
      *Baskets :        6 : Basket Size=      32000 bytes  Compression=   1.82     *
      *............................................................................*
      *Br    4 :t.t       : Double_t t[t_]                                         *
      *Entries :    10000 : Total  Size=     121017 bytes  File Size  =      71609 *
      *Baskets :        6 : Basket Size=      32000 bytes  Compression=   1.68     *
      *............................................................................*
      29491057
    • Philippe Canal's avatar
      Reduce the number of iteration of testInterpreterLock. · 05ac6d8d
      Philippe Canal authored
      This test is also 'stressing' the interpreter and in particular the increase in the number of symbols.  This leads to a noticeable reduction
      of the speed of the test (or more exactly the loading/setting up of the test).  In addition some of the nightly run on VM which can
      lead to performance variance (at least on this test) of a factor 4.  In a good day on one of 'failing' vm, the 100 iterations takes 400s,
      during the nightlies it oftens takes 800s to 1000s ... the timeout limit is 1200s, so it is reached from time to time.
      05ac6d8d
    • Vincenzo Eduardo Padulano's avatar
      [Tree] Expose tree utility functions for internal use · 964b647c
      Vincenzo Eduardo Padulano authored
      Bring utility functions from TTreeProcessorMT in their own namespace, to make them available for internal use in other ROOT sources.
      964b647c
    • Enrico Guiraud's avatar
      [DF] Do not warn needlessly in ~RResultPtr · 05acf445
      Enrico Guiraud authored
      We want to warn users if a RResultPtr returned by a lazy Snapshot
      action is destroyed before the event loop is run, but _only_ if there
      are no other RResultPtr objects that share ownership of the result,
      i.e. if there is no way to trigger this Snapshot in the future.
      05acf445
Loading