[net/monalisa/src/TMonaLisaWriter.cxx:956] -> [net/monalisa/src/TMonaLisaWriter.cxx:957]: (error) Iterator 'iter' used after element has been erased.
[proof/proofd/src/XrdProofdProofServMgr.cxx:4648] -> [proof/proofd/src/XrdProofdProofServMgr.cxx:4646]: (error) Iterator 'iter' used after element has been erased.

[math/minuit2/src/Minuit2Minimizer.cxx:669] -> [math/minuit2/src/Minuit2Minimizer.cxx:669]: (style) Same expression on both sides of '||'.
[math/minuit2/src/Minuit2Minimizer.cxx:736] -> [math/minuit2/src/Minuit2Minimizer.cxx:736]: (style) Same expression on both sides of '||'.
[math/minuit2/src/Minuit2Minimizer.cxx:753] -> [math/minuit2/src/Minuit2Minimizer.cxx:753]: (style) Same expression on both sides of '||'.

[tree/tree/src/TBasket.cxx:852]: (style) Redundant condition: If 'flag >= 80', the comparison 'flag' is always true.
[misc/table/src/TFileIter.cxx:467] -> [misc/table/src/TFileIter.cxx:468]: (warning) Identical condition 'thisRunNumber<runNumber', second condition is always false

[math/mathcore/src/TMath.cxx:826]: (style) Array index 'ia' is used before limits check.
[math/mathcore/src/TMath.cxx:830]: (style) Array index 'ib' is used before limits check.
[math/mathcore/src/triangle.c:15434]: (style) Array index 'aspectindex' is used before limits check.
[roofit/roofit/src/RooIntegralMorph.cxx:375]: (style) Array index 'igapHigh' is used before limits check.

[core/winnt/src/TWinNTSystem.cxx:5035]: (style) Statements following return, break, continue, goto or throw will never be executed.
[tree/treeplayer/src/TSelectorDraw.cxx:380]: (style) Statements following return, break, continue, goto or throw will never be executed.

[net/auth/src/TAuthenticate.cxx:4205]: (error) Resource leak: fd
[roofit/roofitcore/src/BidirMMapPipe.cxx:1880]: (error) Memory leak: s
[tree/tree/src/TLeaf.cxx:222]: (error) Memory leak: countname
[tree/tree/src/TLeaf.cxx:226]: (error) Memory leak: countname
[tmva/tmva/src/MethodBase.cxx:2783]: (error) Memory leak: pdfS
[tmva/tmva/src/MethodBase.cxx:2783]: (error) Memory leak: pdfB

[roofit/roofitcore/src/RooAbsArg.cxx:280]: (style) Redundant checking of STL container element existence before removing it.

[core/dictgen/src/rootcling_impl.cxx:457]: (performance) Possible inefficient checking for 'fieldSelRules' emptiness.
[core/dictgen/src/rootcling_impl.cxx:4573]: (performance) Possible inefficient checking for 'filesIncludedByLinkdef' emptiness.
[gui/canvaspainter/v7/src/TCanvasPainter.cxx:322]: (performance) Possible inefficient checking for 'fWebConn' emptiness.
[gui/canvaspainter/v7/src/TCanvasPainter.cxx:374]: (performance) Possible inefficient checking for 'fCmds' emptiness.
[gui/canvaspainter/v7/src/TCanvasPainter.cxx:419]: (performance) Possible inefficient checking for 'fWebConn' emptiness.
[gui/canvaspainter/v7/src/TCanvasPainter.cxx:475]: (performance) Possible inefficient checking for 'fWebConn' emptiness.
[gui/canvaspainter/v7/src/TCanvasPainter.cxx:587]: (performance) Possible inefficient checking for 'fCmds' emptiness.
[gui/canvaspainter/v7/src/TCanvasPainter.cxx:787]: (performance) Possible inefficient checking for 'fCmds' emptiness.
[html/src/TDocParser.cxx:684]: (performance) Possible inefficient checking for 'currentType' emptiness.
[proof/proofd/src/XrdProofdManager.cxx:804]: (performance) Possible inefficient checking for 'uwrks' emptiness.
[proof/proofd/src/XrdProofdSandbox.cxx:467]: (performance) Possible inefficient checking for 'staglst' emptiness.
[proof/proofd/src/XrdProofdSandbox.cxx:571]: (performance) Possible inefficient checking for 'actln' emptiness.
[roofit/roofitcore/src/RooSimWSTool.cxx:574]: (performance) Possible inefficient checking for 'slist' emptiness.

all the reports Prefer prefix ++/-- operators for non-primitive types

This property was renamed in CMake 2.8.12, so we now should use
the newer name on recent CMake versions. We don't need to support
the pre-2.8.12 versions of CMake because we anyway have code
that requires 3.x.

This is already the case in CMake builds, adding it to make
behavior between build types more uniform. The option is not
added for ICC since it does not have such option and will
generate warnings about ignored flags. Also remove some old
unused options.

Many headers contains redundant header guards around #include directives:

    #ifndef ROOT_TTree
    #include "TTree.h"
    #endif

This patch removes the #ifndef's around these includes as they
don't serve any pratical purpose anymore and are no longer part
of the current ROOT coding convention.

This patch also fixes the 153 typos that are contained in the
symbols of the #ifndef directives.

Signed-off-by: Vassil Vassilev <vvasilev@cern.ch>

This reverts commit 5c076c6c.

This reverts commit b406328d, reversing
changes made to 318c7a47.

Replaces if(builtin_foo) statements with explicit support in the
various ROOT macros.

This removes ROOT_ADD_BUILTIN_DEPENDENCIES and adds BUILD_BYPRODUCTS
for the external projects.  This way, the build system can explicitly
depend on the output file of the external project instead of introducing
a hidden dependency..

Make cannot deal with 'export *', they have to be escaped and fixed later on.

This is the recommended way of using the modules feature and should pave our way
of enabling -fmodules-local-submodules-visibility mode.

Use the standard #include <typeinfo> and #include <iosfwd> instead.

Our two build systems can generate almost entirely a modulemap file laying out
one module per library. Due to some non-modular implementation in ROOT's core we
still need to treat some header files specially.

This patch appends modular header files to the modulemap while skipping the
predefined ones. Configure-make relates all headers that are installed in
$ROOTSYS/include to their library whereas relates only headers which are part of
library's dictionary.

rpdutils is under net, not proof

rpdp headers are not part of the ROOT public API and thus should not
be visible in include/. They were simply because multiple ROOT modules
were including them, and we had no way to specify that other than
publishing them. Now we have a new directory next to src/ and inc/:
res/ (as in "reserved" or "restricted"), signalling that these headers
are not public but used by other ROOT modules.

Update the Moduke.mk-s accordingly.

Move a few really private headers into their src/ directories.

For setups having limitations with open ports, such as in some cases PoD, xproofd provides the
possibility to serve the files produced during running via the same port. This was implemented
by starting a rootd process upon an incoming request for a file. The use of xrootd for this
purpose was not possible with earlier versions of XRootD (up to 3) because the file serving
protocol was not available as separate plug-in.
This patch enables the use of xrootd for this purpose and deprecates the use of rootd .

 - bin/pq2
 - bin/rootd
 - bin/xpdtest
 - initd and xinitd start-up scripts
 - don't install some private headers

   include/XrdProofdTrace.h:106:10: warning: nonnull argument "this" compared to NULL [-Wnonnull-compare]

This change should improve the modules builds.