Skip to content
Snippets Groups Projects
  1. Nov 02, 2011
  2. Nov 01, 2011
    • Wouter Verkerke's avatar
      · bbf85522
      Wouter Verkerke authored
         o RooVectorDataStore
      
           - Correct version this time (with proper support for persistent)
      
      
         o RooAbsOptTestStatistics
      
           - Initialize all pointer data members in all ctors
      
      
         o RooCompositeDataStore
      
           - Implement sumEntries() as forward to components
      
      
         o RooAbsArg
      
           - Another fix for windows static linking
      
      
      git-svn-id: http://root.cern.ch/svn/root/trunk@41703 27541ba8-7e3a-0410-8455-c3a389f83636
      bbf85522
    • Lorenzo Moneta's avatar
    • Lorenzo Moneta's avatar
      merge fix 41700 from Kyle in Histfactory · ea2e100b
      Lorenzo Moneta authored
      git-svn-id: http://root.cern.ch/svn/root/trunk@41701 27541ba8-7e3a-0410-8455-c3a389f83636
      ea2e100b
    • Philippe Canal's avatar
      From Elvin: · 2af05cf0
      Philippe Canal authored
      Last week Martin Vala from ALICE came to me with a problem that he had
      while using the asynchronous prefetching. There were basically two
      main problems:
      
      1. Trying to read a root file from an archive. Here the problem was
      that when reading from an archive there is an offset of the file which
      was not taken into consideration when the file was saved in the cache.
      And this lead to a miss when reading the file from cache. I fixed it,
      but I had to expose the value of fArchiveOffset from TFile.
      
      2. The second problem was when reading using a TChain. There were some
      synchronization issues concerned to the asynchronous thread that
      actually does the reading. All this was happening because in the case
      of TChain there is only one file cache which is re-utilized as we move
      from one file to another. This was a pretty tricky issue.
      
      I attached a patch made against the current trunk which fixes both
      this problems. I gave the patch first to Martin to test it, and he was
      satisfied with it. There is a small delay when the TChain moves from
      one file to another because I have to wait for the async thread to
      finish it's worked but over all Martin said that the performance is
      way better than before. When I initially did the asyn pre-fetching I
      had no idea about these two use cases, so that's why they popped up
      now.
      
      
      
      
      git-svn-id: http://root.cern.ch/svn/root/trunk@41698 27541ba8-7e3a-0410-8455-c3a389f83636
      2af05cf0
    • Philippe Canal's avatar
      Fix medium impact coverity reports · 5e2d7a77
      Philippe Canal authored
      git-svn-id: http://root.cern.ch/svn/root/trunk@41697 27541ba8-7e3a-0410-8455-c3a389f83636
      5e2d7a77
    • Philippe Canal's avatar
      Fix high impact coverity reports · 38c1ca9f
      Philippe Canal authored
      git-svn-id: http://root.cern.ch/svn/root/trunk@41696 27541ba8-7e3a-0410-8455-c3a389f83636
      38c1ca9f
    • Philippe Canal's avatar
      4th attempt to silence coverity about the use of fpos_t · a8645217
      Philippe Canal authored
      git-svn-id: http://root.cern.ch/svn/root/trunk@41695 27541ba8-7e3a-0410-8455-c3a389f83636
      a8645217
    • Andrei Gheata's avatar
      Fixed references for Gtra shape · 9669f379
      Andrei Gheata authored
      git-svn-id: http://root.cern.ch/svn/root/trunk@41694 27541ba8-7e3a-0410-8455-c3a389f83636
      9669f379
    • Wim Lavrijsen's avatar
      conform to R.RS4 · 114f0406
      Wim Lavrijsen authored
      git-svn-id: http://root.cern.ch/svn/root/trunk@41693 27541ba8-7e3a-0410-8455-c3a389f83636
      114f0406
    • Philippe Canal's avatar
      Make sure the clones are register both with the underlying tree and the TChain... · a0b737d9
      Philippe Canal authored
      Make sure the clones are register both with the underlying tree and the TChain itself (was missing until now).  This fixes <http://savannah.cern.ch/bugs/?88339>
      
      
      git-svn-id: http://root.cern.ch/svn/root/trunk@41692 27541ba8-7e3a-0410-8455-c3a389f83636
      a0b737d9
    • Lorenzo Moneta's avatar
      add support for vector data store · 9f1cc953
      Lorenzo Moneta authored
      git-svn-id: http://root.cern.ch/svn/root/trunk@41691 27541ba8-7e3a-0410-8455-c3a389f83636
      9f1cc953
    • Lorenzo Moneta's avatar
      revert changes in isfinite for a roblem on Windows. · 82213761
      Lorenzo Moneta authored
      In Windows R__ANSISTREAM is defined and std::isfinite does not exist
      
      
      git-svn-id: http://root.cern.ch/svn/root/trunk@41690 27541ba8-7e3a-0410-8455-c3a389f83636
      82213761
    • Gerardo Ganis's avatar
      Include the portable XpdSysLogger.h instead of XrdSys/XrdSysLogger.hh · a38a9715
      Gerardo Ganis authored
      git-svn-id: http://root.cern.ch/svn/root/trunk@41689 27541ba8-7e3a-0410-8455-c3a389f83636
      a38a9715
    • Lorenzo Moneta's avatar
      fix TMath::IsNaN and TMath::Finite for intel compiler · 67c443f9
      Lorenzo Moneta authored
       with icc version 11 when used in combination with gcc > 4.3 one cannot use std::isnan but just ::isnan from math.h
      
      
      git-svn-id: http://root.cern.ch/svn/root/trunk@41687 27541ba8-7e3a-0410-8455-c3a389f83636
      67c443f9
    • Philippe Canal's avatar
      Fix Drawing a top level object (usually TBits). See... · 5b6e00b0
      Philippe Canal authored
      Fix Drawing a top level object (usually TBits).  See http://root.cern.ch/phpBB3/viewtopic.php?t=13629
      
      
      git-svn-id: http://root.cern.ch/svn/root/trunk@41686 27541ba8-7e3a-0410-8455-c3a389f83636
      5b6e00b0
    • Wouter Verkerke's avatar
      · a286c9a7
      Wouter Verkerke authored
        o RooAbsArg
      
          - Fix windows static linking issue
      
      
        o RooAbsData, stressRooFit
      
           - Select vector-based storage by default
      
      
      git-svn-id: http://root.cern.ch/svn/root/trunk@41685 27541ba8-7e3a-0410-8455-c3a389f83636
      a286c9a7
    • Wouter Verkerke's avatar
      · 84b03194
      Wouter Verkerke authored
        roofit/histfactory
      
          - Import changes from dev-roostats branch
      
        roofit/roostats
       
          - Import update on HypoTestInverterResult and HypoTestInverterPlot
            from dev branch (only fixes for compiler warnings)
      
        roofit/roofit
      
          - Import new classes Roo1DMomentMorphFunction and Roo2DMomentMorphFunction
            from dev-roostats branch (contribution by Max Baak)
      
      
      git-svn-id: http://root.cern.ch/svn/root/trunk@41684 27541ba8-7e3a-0410-8455-c3a389f83636
      84b03194
    • Gerardo Ganis's avatar
      Fix missing protections found by coverity · 27558e20
      Gerardo Ganis authored
      git-svn-id: http://root.cern.ch/svn/root/trunk@41682 27541ba8-7e3a-0410-8455-c3a389f83636
      27558e20
    • Philippe Canal's avatar
      From Gerri: · 5bc5a1a6
      Philippe Canal authored
      In TSeqCollection::Merge adding a TList of objects without a Merge method (e.g. TObjString)
      to the output list did *not* work properly, in the sense that all but one set of objects is lost. 
      This is because TSeqCollection::Merge (used by TList) is ignoring non mergeable objects instead 
      of just adding them to the original list as we do at higher level in PROOF. 
      This patch update the behavior of TSeqCollection::Merge to append the non-mergeable objects.
      
      
      git-svn-id: http://root.cern.ch/svn/root/trunk@41679 27541ba8-7e3a-0410-8455-c3a389f83636
      5bc5a1a6
    • Wouter Verkerke's avatar
      · 7722919b
      Wouter Verkerke authored
        Updated version of stressRooFit
      
      
      git-svn-id: http://root.cern.ch/svn/root/trunk@41678 27541ba8-7e3a-0410-8455-c3a389f83636
      7722919b
    • Fons Rademakers's avatar
      fix for non-absolute destionation paths, of -j switch for parallel build. · e19deb0b
      Fons Rademakers authored
      git-svn-id: http://root.cern.ch/svn/root/trunk@41677 27541ba8-7e3a-0410-8455-c3a389f83636
      e19deb0b
    • Wouter Verkerke's avatar
      · 61d82d09
      Wouter Verkerke authored
         *** Miscellaneous speed improvements ***
        
          o PiecewiseInterpolation
      
            - Import changes from Max baak (new interpolation options)
      
            - Deploy fast iterators
      
      
          o RooGaussian
      
            - Bug fix in analytical integral over 'mean' parameter (Lorenzo Moneta)
      
      
          o RooBernstein
      
            - Deploy fast iterators
      
      
          o RooProdPdf
      
            - Reorganize code for improved speed
      
      
          o RooDataHist
      
            - Add support for vector-based data storage
      
      
          o RooGenContext
      
            - Improve generation speed by putting internal pdf clone to ADirty mode
      
      
          o RooRealBinding
      
            - Minimize number of calls to min() and max() for efficiency reasons
      
      
          o RooAbsRealLValue
      
            - In randomize() Minimize number of calls to min() and max() for efficiency reasons
      
      
          o RooDataSet
      
            - Make addFast() even faster by disable state propagation
      
      
          o RooAbsGenContext
      
            - Disable state propagation in output dataset for efficiency reasons
            - Call initGenerator() only on the first generation sequence
      
       
          o RooVectorDataStore
      
            - Add support for native vs current buffers, to support the functioning
              of addColumn(s)() and cacheArgs() when the datastore is attached
              to a pdf in RooAbsOptTestStatistics
      
         
          o RooAbsCategoryLValue
      
            - Support change in RooAbsCategory to operate nominally by index rather than by label
      
      
          o RooXYChi2Var
      
            - Change code to support new pdf/data attachment scheme in RooAbsOptTestStatistics
              where only the store buffers are reattached and the variable objects themselves
      
      
          o RooFFTConvPdf
      
            - Bug fix in getActualObservables() - functionality of setCacheObs() is now restored
      
      
          o RooAbsReal
      
            - Small adjustments in getVal() to make it faster in most cases
      
      
          o RooAbsCollection
      
            - Add datamember to keep track contents is exclusively RooRealVars. For those that
              do implement a faster version of assignFast()
      
      
          o RooAbsData
      
            - Add methods attachBuffers() and resetBuffers() - forwarded to datastore - that
              facilite new 'fast-attach' methods used in RooAbsOptTestStatistic
      
      
          o RooCompositeDataStore
      
            - Fix copy constructors so that they clone and own the subsidiary datasets
      
            - Operate index by value rather than by string label for efficiency reasons
      
      
          o RooRealVar
      
            - Bug fix in attachToVStore() to properly handle RRVs with StoreError tags
      
      
          o RooAbsPdf
      
            - Adjustments in getVal() to make it faster for most cases
            - Modify generate(GenSpec*) to initialize specInit flag that
              triggers one-time call of initGenerator()
            - Modify generate() to not repeatedly call initGenerator() for the same gencontext
      
       
          o RooAbsArg
      
            - Deploy fast iterators in more places
            - Add various new inline methods performing multiple ops (e.g retrieving and
              clearing one or more dirty flags) for improbed RooAbsReal/RooAbsPdf::getVal()
              operations
         
      
          o RooBanner
      
            - Increment version tag to 3.48
      
      
          o RooRealIntegral
      
            - Add overloaded getVal() method that also checks for shapeDirty flag,
              which was removed from RooAbsReal::getVal() as it is not needed for
              any class other than RooRealIntegral
      
      
          o RooAddGenContext
      
            - Disable state propagation in output dataset for efficiency reasons
            - Replace ROOT container classes with STL versions for efficiency reasons
      
      
          o RooMultiCatIter
      
            - Adjust code to new RooCatType behaviour that by default only tracks the
              integer representation of type
      
      
          o RooProdGenContext
      
            - Replace ROOT container classes with STL versions for efficiency reasons
      
      
          o RooTreeDataStore
      
            - Adjust code so that it works with the new fast-attach mechanism used
              in RooAbsOptTestStatistic
      
      
          o RooRealProxy
      
            - In lvptr() remove explicit check for lvalue
      
      
          o RooSimGenContext
      
            - Disable state propagation in output dataset for efficiency reasons
            - Replace ROOT container classes with STL versions for efficiency reasons
            - In createDataSet() create a prototype dataset in the first call, and
              clone that for subsequent calls rather than calling the expensive named
              argument constructor each time
      
      
          o RooTrace
      
            - Add (dummy) method callgrind_zero() and callgrind_dump() as hook functions
              to facilitate improved callgrind profiling
      
      
          o RooAbsCategory
      
            - Adjust class so that it works with the integer representation of types only
              and lookup associated string label on the fly, whenever it is requested
      
      
          o RooFormular
      
            - Eliminate overloaded getVal() as its functionality is now provided in 
              RooAbsReal::getVal()
      
      
          o RooAbsOptTestStatistic
      
            - Implement new fast-attach mechanisms for pdf and datasets: only readjust the
              buffer pointers of the dataset to the pdf observables, rather than reattaching
              the pdf to the dataset observables. This results in a _much_ faster 
              operation of setData() and no longer entangles the test statistics with observables
              of datasets that may be deleted during the lifetime of the test statistic
      
       
          o RooSimultaneous
       
             - Overload fillDataHist() with new version with correct normalization (from Scott Snyder)
      
      
          o RooCategory
      
             - Adjust getLabel() so that it retries labels associated with the current index on the fly
      
      
          o RooCatType
      
             - Make label contents 'transient', i.e. it is not copied on assignment for faster 
               category operations. RooAbsCategory will load the associated labels on demand from now on.
      
      
      git-svn-id: http://root.cern.ch/svn/root/trunk@41676 27541ba8-7e3a-0410-8455-c3a389f83636
      61d82d09
    • Fons Rademakers's avatar
      now that we always use explicitlink and --no-undefined we can also always · 6fc2e199
      Fons Rademakers authored
      use --as-needed (which is the default for Ubuntu 11.10 anyway).
      
      
      git-svn-id: http://root.cern.ch/svn/root/trunk@41675 27541ba8-7e3a-0410-8455-c3a389f83636
      6fc2e199
    • Fons Rademakers's avatar
      some changes for external xrootd. · 603a682d
      Fons Rademakers authored
      git-svn-id: http://root.cern.ch/svn/root/trunk@41674 27541ba8-7e3a-0410-8455-c3a389f83636
      603a682d
    • Andrei Gheata's avatar
      Fixed typo in TGeoTrd2::ComputeNormal... · e99bbb38
      Andrei Gheata authored
      git-svn-id: http://root.cern.ch/svn/root/trunk@41673 27541ba8-7e3a-0410-8455-c3a389f83636
      e99bbb38
Loading