Skip to content
Snippets Groups Projects
  1. Jun 06, 2014
  2. Apr 29, 2014
  3. Feb 12, 2014
  4. Jan 31, 2014
    • Danilo Piparo's avatar
      Fix the CMake build · 880fe6d6
      Danilo Piparo authored
      now the library names in the rootmaps are sane.
      In addition, the creation of the tmva and genvector dicts was
      simplified.
      880fe6d6
  5. Jan 21, 2014
  6. Jan 17, 2014
  7. Jan 15, 2014
  8. Jan 12, 2014
  9. Jan 09, 2014
  10. Dec 17, 2013
  11. Dec 05, 2013
  12. Nov 25, 2013
  13. Nov 18, 2013
  14. Oct 30, 2013
  15. Sep 13, 2013
  16. Aug 16, 2013
  17. Aug 01, 2013
    • Philippe Canal's avatar
      Fix Memory leaks when using TPgSQLStatement. See JIRA ROOT-5393 · 055ff090
      Philippe Canal authored
      when recently valgrinding our analysis-software again, I found two leaks stemming from lost pointers to prepared PgSQL-statements in TPgSQLStatement (we just started using the TSQLStatement more often some weeks ago).
      The problem is that the TPgSQLServer already prepares a PGresult and adds a pointer to it to the stmt-structure which is passed to TPgSQLStatement.
      The TPgSQLStatement creates a new prepared statement in its constructor and overrides this pointer with it.
      In TPgSQLStatement:Process(), this pointer is overwritten again.
      
      To not break any existing usecases of this, the attached patch fixes this problem by first PQclear'ing the prepared result if it is not NULL. This fixes both leaks (and at the moment, I do not observe more leaks in our usage of the TPgSQLStatement).
      
      [From Oliver Freyermuth]
      055ff090
  18. Jul 18, 2013
  19. Jul 01, 2013
  20. Jun 30, 2013
    • Fons Rademakers's avatar
      More correct storage format for timestamps. Fix ROOT-5331. · 90dcc10e
      Fons Rademakers authored
      Solution attached as patch:
      - SetTimestamp() writes timestamps of the format "2013-06-30 05:11:01.021"
        to the database and communicates the 3-digit precision (i.e., milliseconds)
        to the user in its comment. 3 digit precision is also what the strftime /
        datetime methods of sqlite use, all other digits are ignored by those methods.
      - GetTimestamp() reads such timestamps, also limiting the fraction-precision
        to 3 digits and communicating that to the user from within the comment.
      
      Patch by Oliver Freyermuth.
      90dcc10e
    • Fons Rademakers's avatar
      More correct storage format for timestamps. Fix ROOT-5330. · 67fcf244
      Fons Rademakers authored
      Solution attached as patch:
      - SetTimestamp() writes timestamps of the format "2013-06-30 05:11:01.021"
        to the database and communicates the 3-digit precision (i.e., milliseconds)
        to the user in its comment. 3 digit precision is also what the strftime /
        datetime methods of sqlite use, all other digits are ignored by those methods.
      - GetTimestamp() reads such timestamps, also limiting the fraction-precision
        to 3 digits and communicating that to the user from within the comment.
      
      Patch by Oliver Freyermuth.
      67fcf244
  21. Jun 28, 2013
  22. Jun 27, 2013
    • Fons Rademakers's avatar
      TSQLite-classes to access sqlite3-databases. See ROOT-5256. · 1ecf8815
      Fons Rademakers authored
      The attached patches add the following classes:
      TSQLiteResult
      TSQLiteRow
      TSQLiteServer
      TSQLiteStatement
      and corresponding integration into both the ROOT-buildsystem and cmake.
      Naturally, also the macro for the plugin-manager is included.
      Patches supplied for ROOT 5.34.08 and current master (as SQL-part is
      rarely changing, this statement should stay valid at least for some months).
      
      Some usage notes:
      
      * The handed path is evaluated as URI by sqlite3, which means it can be
        a relative or absolute path and can even contain additional settings
        as "URI" parameters, which are described in the SQLite-documentation.
      * Functions "{Create,Select,Drop}
        DataBase(s)", "Reload", "Shutdown" are not implemented as SQLite
        operates on one DB per file only. The implemented stub methods return
        appropriate error results.
      * "TSQLiteServer::GetColumns()" is not implemented (i.e. returns error
        and value 0): This is sadly not possible via a query in SQLite by
        their API design. This also means the TableInfo-objects cannot be queried.
      * The result-row-count of a TSQLiteResult is always -1, as SQLite does
        not know the number of result rows before all have been retrieved
        (a valid optimization for a file-only DBMS).
      
      For the person reviewing this patch, please note that the indices of
      bind_parameters in SQLite start from 1, while those for the result-columns
      start from 0.
      
      As this is a rather large featureset to cover and the software of our
      experiment currently only uses a small subset of it (only 'reading'
      statements, and no prepared statements), I also wrote a very simple
      testing-tool which creates a new database with a table with 10 columns
      of very different type, inserts some example data, and rereads that
      data both using a simple Query() and using a prepared Statement().
      This tool and a very short makefile to build it are also attached if
      needed for the review-process. The tool uses the commands described
      in the documentation of the abstract baseclass TSQLStatement to
      simulate real-life behaviour.
      Please note that tool is rather hacked-together without real error-handling,
      as it is not meant for long-term usage, but might be helpful in the
      review-process / adapted to a unit-test.
      
      Apart from the mentioned specifics, nothing is really SQLite-only,
      thus I did not change the documentation of the baseclass in the patch
      (this documentation also lists all SQL-implementations). At least this
      list in the documentation might be extended to make users aware of the
      new implementation.
      
      SQlite plugin provided by Oliver Freyermuth (o.f@cern.ch).
      1ecf8815
  23. Jun 14, 2013
  24. Jun 12, 2013
  25. Jun 11, 2013
  26. Jun 09, 2013
  27. May 29, 2013
  28. May 28, 2013
  29. Apr 26, 2013
  30. Apr 12, 2013
  31. Mar 28, 2013
    • Fons Rademakers's avatar
      From Lifeng Sun: · 2f98a6a8
      Fons Rademakers authored
      The attached patchset fixes a bunch of typo in the source:
      0001-succes-success.patch
      0002-preceed-preced.patch
      0003-informations-information.patch
      0004-childs-children.patch
      0005-avaliable-available.patch
      0006-writeable-writable.patch
      0007-comand-command.patch
      0008-unkown-unknown.patch
      0009-wierd-weird.patch
      0010-wheter-whether.patch
      0011-unecessary-unnecessary.patch
      0012-splitted-split.patch
      0013-registerd-registered.patch
      0014-recieve-receive.patch
      0015-processsing-processing.patch
      0016-ouput-output.patch
      0017-mutiple-multiple.patch
      0018-lenght-length.patch
      0019-interupted-interrupted.patch
      0020-independant-independent.patch
      0021-inconsistant-inconsistent.patch
      0022-expresion-expression.patch
      0023-explicitely-explicitly.patch
      0024-enviroment-environment.patch
      0025-deafult-default.patch
      0026-continous-continuous.patch
      0027-completly-completely.patch
      0028-commited-committed.patch
      0029-choosen-chosen.patch
      0030-backgroud-background.patch
      0031-auxilliary-auxiliary.patch
      0032-authentification-authentication.patch
      0033-appropiate-appropriate.patch
      0034-an-other-another.patch
      0035-environement-environment.patch
      0036-targetting-targeting.patch
      0037-suppported-supported.patch
      0038-paramater-parameter.patch
      
      
      git-svn-id: http://root.cern.ch/svn/root/trunk@48992 27541ba8-7e3a-0410-8455-c3a389f83636
      2f98a6a8
Loading