These are temporary static libraries that need to be linked to a
final shared library, so they must be compiled with -fPIC.

This is necessary to allow builtin_openssl option to work by linking
OpenSSL statically and not distributing any headers afterwards.

[net/monalisa/src/TMonaLisaWriter.cxx:956] -> [net/monalisa/src/TMonaLisaWriter.cxx:957]: (error) Iterator 'iter' used after element has been erased.
[proof/proofd/src/XrdProofdProofServMgr.cxx:4648] -> [proof/proofd/src/XrdProofdProofServMgr.cxx:4646]: (error) Iterator 'iter' used after element has been erased.

[math/minuit2/src/Minuit2Minimizer.cxx:669] -> [math/minuit2/src/Minuit2Minimizer.cxx:669]: (style) Same expression on both sides of '||'.
[math/minuit2/src/Minuit2Minimizer.cxx:736] -> [math/minuit2/src/Minuit2Minimizer.cxx:736]: (style) Same expression on both sides of '||'.
[math/minuit2/src/Minuit2Minimizer.cxx:753] -> [math/minuit2/src/Minuit2Minimizer.cxx:753]: (style) Same expression on both sides of '||'.

[tree/tree/src/TBasket.cxx:852]: (style) Redundant condition: If 'flag >= 80', the comparison 'flag' is always true.
[misc/table/src/TFileIter.cxx:467] -> [misc/table/src/TFileIter.cxx:468]: (warning) Identical condition 'thisRunNumber<runNumber', second condition is always false

[math/mathcore/src/TMath.cxx:826]: (style) Array index 'ia' is used before limits check.
[math/mathcore/src/TMath.cxx:830]: (style) Array index 'ib' is used before limits check.
[math/mathcore/src/triangle.c:15434]: (style) Array index 'aspectindex' is used before limits check.
[roofit/roofit/src/RooIntegralMorph.cxx:375]: (style) Array index 'igapHigh' is used before limits check.

[core/winnt/src/TWinNTSystem.cxx:5035]: (style) Statements following return, break, continue, goto or throw will never be executed.
[tree/treeplayer/src/TSelectorDraw.cxx:380]: (style) Statements following return, break, continue, goto or throw will never be executed.

[net/auth/src/TAuthenticate.cxx:4205]: (error) Resource leak: fd
[roofit/roofitcore/src/BidirMMapPipe.cxx:1880]: (error) Memory leak: s
[tree/tree/src/TLeaf.cxx:222]: (error) Memory leak: countname
[tree/tree/src/TLeaf.cxx:226]: (error) Memory leak: countname
[tmva/tmva/src/MethodBase.cxx:2783]: (error) Memory leak: pdfS
[tmva/tmva/src/MethodBase.cxx:2783]: (error) Memory leak: pdfB

[roofit/roofitcore/src/RooAbsArg.cxx:280]: (style) Redundant checking of STL container element existence before removing it.

[core/dictgen/src/rootcling_impl.cxx:457]: (performance) Possible inefficient checking for 'fieldSelRules' emptiness.
[core/dictgen/src/rootcling_impl.cxx:4573]: (performance) Possible inefficient checking for 'filesIncludedByLinkdef' emptiness.
[gui/canvaspainter/v7/src/TCanvasPainter.cxx:322]: (performance) Possible inefficient checking for 'fWebConn' emptiness.
[gui/canvaspainter/v7/src/TCanvasPainter.cxx:374]: (performance) Possible inefficient checking for 'fCmds' emptiness.
[gui/canvaspainter/v7/src/TCanvasPainter.cxx:419]: (performance) Possible inefficient checking for 'fWebConn' emptiness.
[gui/canvaspainter/v7/src/TCanvasPainter.cxx:475]: (performance) Possible inefficient checking for 'fWebConn' emptiness.
[gui/canvaspainter/v7/src/TCanvasPainter.cxx:587]: (performance) Possible inefficient checking for 'fCmds' emptiness.
[gui/canvaspainter/v7/src/TCanvasPainter.cxx:787]: (performance) Possible inefficient checking for 'fCmds' emptiness.
[html/src/TDocParser.cxx:684]: (performance) Possible inefficient checking for 'currentType' emptiness.
[proof/proofd/src/XrdProofdManager.cxx:804]: (performance) Possible inefficient checking for 'uwrks' emptiness.
[proof/proofd/src/XrdProofdSandbox.cxx:467]: (performance) Possible inefficient checking for 'staglst' emptiness.
[proof/proofd/src/XrdProofdSandbox.cxx:571]: (performance) Possible inefficient checking for 'actln' emptiness.
[roofit/roofitcore/src/RooSimWSTool.cxx:574]: (performance) Possible inefficient checking for 'slist' emptiness.

all the reports Prefer prefix ++/-- operators for non-primitive types

This refactors the CMake build files to no longer manually call
the CMake functions for generating and linking the dicionairies.
One reason is to reduce boilerplate, the other is that it is now
no longer possible to have naming mismatches between the dictionary
generation arguments and linking function arguments which was causing
the race conditions we had in our build system.

This also now follows more strictly the separation between dependencies
like Math, Tree and Core and pure linking flags to external libraries.

ROOT_GENERATE_DICTIONARY allows to specify dependencies, but we currently
don't actually specify those. As we need this for getting the module
dependencies right (as we can't build missing modules on demand), we should
add those dependencies here. Then those dependencies propagate to the
rootcling invocation which will in the future also generate the C++ module
for the selected dictionary.

ClassImp is a macro defined in Rtypes.h. It can be written without trailing
semicolon. However, clang-format is based on lexing and it doesn't know at
all about preprocessors and how to expand macros. When visiting ClassImp(X)
it thinks this is not a completed entity (as it doesn't expand macros) and
considers the next line as continuation of the previous.

Inserting a semicolon fixes the issue and makes formatting with clang-format
in the ROOT codebase less tricky.

gROOTMutex (equal to gInterpreterMutex) are always set at the same type as gGlobalMutex so there is no need to use R__LOCKGUARD2

Many headers contains redundant header guards around #include directives:

    #ifndef ROOT_TTree
    #include "TTree.h"
    #endif

This patch removes the #ifndef's around these includes as they
don't serve any pratical purpose anymore and are no longer part
of the current ROOT coding convention.

This patch also fixes the 153 typos that are contained in the
symbols of the #ifndef directives.

Signed-off-by: Vassil Vassilev <vvasilev@cern.ch>

This reverts commit 83e4099f.

This reverts commit 5c076c6c.

This reverts commit 92c7310f.

This reverts commit b406328d, reversing
changes made to 318c7a47.

Make cannot deal with 'export *', they have to be escaped and fixed later on.

This is the recommended way of using the modules feature and should pave our way
of enabling -fmodules-local-submodules-visibility mode.

This remove duplicate definitions and duplicate default argument errors when
building modules for proof.

Our two build systems can generate almost entirely a modulemap file laying out
one module per library. Due to some non-modular implementation in ROOT's core we
still need to treat some header files specially.

This patch appends modular header files to the modulemap while skipping the
predefined ones. Configure-make relates all headers that are installed in
$ROOTSYS/include to their library whereas relates only headers which are part of
library's dictionary.

rpdp headers are not part of the ROOT public API and thus should not
be visible in include/. They were simply because multiple ROOT modules
were including them, and we had no way to specify that other than
publishing them. Now we have a new directory next to src/ and inc/:
res/ (as in "reserved" or "restricted"), signalling that these headers
are not public but used by other ROOT modules.

Update the Moduke.mk-s accordingly.

Move a few really private headers into their src/ directories.

Added more protections to include_directories(${OPENSSL_INCLUDE_DIR})

The patch adds missing OpenSSL include directories. Otherwise the
ones from standard system location is being used, which might not
be installed. E.g., CMSSW provides their own build of OpenSSL and
build machines do not have OpenSSL libs and dev packages installed.
Signed-off-by: David Abdurachmanov <davidlt@cern.ch>