Skip to content
Snippets Groups Projects
  1. Jul 01, 2019
  2. May 14, 2019
  3. Feb 11, 2019
  4. Jan 22, 2019
  5. Jan 09, 2019
  6. Oct 03, 2018
  7. Oct 02, 2018
  8. Jul 26, 2018
  9. Jul 18, 2018
  10. Mar 27, 2018
  11. Feb 18, 2018
  12. Dec 04, 2017
    • Julien Nabet's avatar
      cppcheck: fix some reports · cd6fa81b
      Julien Nabet authored
      [net/monalisa/src/TMonaLisaWriter.cxx:956] -> [net/monalisa/src/TMonaLisaWriter.cxx:957]: (error) Iterator 'iter' used after element has been erased.
      [proof/proofd/src/XrdProofdProofServMgr.cxx:4648] -> [proof/proofd/src/XrdProofdProofServMgr.cxx:4646]: (error) Iterator 'iter' used after element has been erased.
      
      [math/minuit2/src/Minuit2Minimizer.cxx:669] -> [math/minuit2/src/Minuit2Minimizer.cxx:669]: (style) Same expression on both sides of '||'.
      [math/minuit2/src/Minuit2Minimizer.cxx:736] -> [math/minuit2/src/Minuit2Minimizer.cxx:736]: (style) Same expression on both sides of '||'.
      [math/minuit2/src/Minuit2Minimizer.cxx:753] -> [math/minuit2/src/Minuit2Minimizer.cxx:753]: (style) Same expression on both sides of '||'.
      
      [tree/tree/src/TBasket.cxx:852]: (style) Redundant condition: If 'flag >= 80', the comparison 'flag' is always true.
      [misc/table/src/TFileIter.cxx:467] -> [misc/table/src/TFileIter.cxx:468]: (warning) Identical condition 'thisRunNumber<runNumber', second condition is always false
      
      [math/mathcore/src/TMath.cxx:826]: (style) Array index 'ia' is used before limits check.
      [math/mathcore/src/TMath.cxx:830]: (style) Array index 'ib' is used before limits check.
      [math/mathcore/src/triangle.c:15434]: (style) Array index 'aspectindex' is used before limits check.
      [roofit/roofit/src/RooIntegralMorph.cxx:375]: (style) Array index 'igapHigh' is used before limits check.
      
      [core/winnt/src/TWinNTSystem.cxx:5035]: (style) Statements following return, break, continue, goto or throw will never be executed.
      [tree/treeplayer/src/TSelectorDraw.cxx:380]: (style) Statements following return, break, continue, goto or throw will never be executed.
      
      [net/auth/src/TAuthenticate.cxx:4205]: (error) Resource leak: fd
      [roofit/roofitcore/src/BidirMMapPipe.cxx:1880]: (error) Memory leak: s
      [tree/tree/src/TLeaf.cxx:222]: (error) Memory leak: countname
      [tree/tree/src/TLeaf.cxx:226]: (error) Memory leak: countname
      [tmva/tmva/src/MethodBase.cxx:2783]: (error) Memory leak: pdfS
      [tmva/tmva/src/MethodBase.cxx:2783]: (error) Memory leak: pdfB
      
      [roofit/roofitcore/src/RooAbsArg.cxx:280]: (style) Redundant checking of STL container element existence before removing it.
      
      [core/dictgen/src/rootcling_impl.cxx:457]: (performance) Possible inefficient checking for 'fieldSelRules' emptiness.
      [core/dictgen/src/rootcling_impl.cxx:4573]: (performance) Possible inefficient checking for 'filesIncludedByLinkdef' emptiness.
      [gui/canvaspainter/v7/src/TCanvasPainter.cxx:322]: (performance) Possible inefficient checking for 'fWebConn' emptiness.
      [gui/canvaspainter/v7/src/TCanvasPainter.cxx:374]: (performance) Possible inefficient checking for 'fCmds' emptiness.
      [gui/canvaspainter/v7/src/TCanvasPainter.cxx:419]: (performance) Possible inefficient checking for 'fWebConn' emptiness.
      [gui/canvaspainter/v7/src/TCanvasPainter.cxx:475]: (performance) Possible inefficient checking for 'fWebConn' emptiness.
      [gui/canvaspainter/v7/src/TCanvasPainter.cxx:587]: (performance) Possible inefficient checking for 'fCmds' emptiness.
      [gui/canvaspainter/v7/src/TCanvasPainter.cxx:787]: (performance) Possible inefficient checking for 'fCmds' emptiness.
      [html/src/TDocParser.cxx:684]: (performance) Possible inefficient checking for 'currentType' emptiness.
      [proof/proofd/src/XrdProofdManager.cxx:804]: (performance) Possible inefficient checking for 'uwrks' emptiness.
      [proof/proofd/src/XrdProofdSandbox.cxx:467]: (performance) Possible inefficient checking for 'staglst' emptiness.
      [proof/proofd/src/XrdProofdSandbox.cxx:571]: (performance) Possible inefficient checking for 'actln' emptiness.
      [roofit/roofitcore/src/RooSimWSTool.cxx:574]: (performance) Possible inefficient checking for 'slist' emptiness.
      
      all the reports Prefer prefix ++/-- operators for non-primitive types
      cd6fa81b
  13. Nov 26, 2017
  14. Sep 05, 2017
  15. Aug 03, 2017
    • Danilo Piparo's avatar
      Impose library linking order · dbadc905
      Danilo Piparo authored
      this affects the order in which the libraries are loaded and ultimately
      the order in which the streamer infos are present on the files.
      This affects the roottest-root-io-filemerger-make test, very sensitive
      to the file size on disk which in turn is sensitive to the size (and compression factor)
      of the TStreamerInfo record.
      dbadc905
  16. Jul 28, 2017
    • Raphael Isemann's avatar
      Use ROOT_STANDARD_LIBRARY_PACKAGE where possible [NFC] · ac0de75b
      Raphael Isemann authored
      This refactors the CMake build files to no longer manually call
      the CMake functions for generating and linking the dicionairies.
      One reason is to reduce boilerplate, the other is that it is now
      no longer possible to have naming mismatches between the dictionary
      generation arguments and linking function arguments which was causing
      the race conditions we had in our build system.
      
      This also now follows more strictly the separation between dependencies
      like Math, Tree and Core and pure linking flags to external libraries.
      ac0de75b
  17. Jul 14, 2017
  18. Jul 12, 2017
    • Raphael Isemann's avatar
      Fixed dependencies between rootcling invocations and linking. · 82ecb5f0
      Raphael Isemann authored
      The naming of the library in the two function calls ROOT_GENERATE_DICTIONARY
      and ROOT_LINKER_LIBRARY was often not matching. This causes that
      ROOT_LINKER_LIBRARY couldn't correctly set its dependencies to the output
      file of ROOT_GENERATE_DICTIONARY and therefore causes race conditions in
      the build system.
      
      Note: We're attached all dependencies to a custom target, and
      NOT to the output files generated by rootcling. This should mitigate
      the race conditions we experience when multiple targets in different
      Make jobs request the same output file as a dependency and then
      suffer from this Make problem that is described here:
      https://cmake.org/Bug/view.php?id=10082
      
      This patch also adds a (commented out) piece of code that can print
      warnings if we don't have a fitting G__*.cxx file for a
      ROOT_LINKER_LIBRARY call. This is sometimes intended, so I didn't
      enable this warning by default. We should enable this code
      by default in the future once we have a way to express if we
      intentionally don't provide the G__*.cxx file when calling
      ROOT_LINKER_LIBRARY.
      82ecb5f0
    • Raphael Isemann's avatar
      Add missing dependencies to ROOT_GENERATE_DICTIONARY · 8a646b53
      Raphael Isemann authored
      ROOT_GENERATE_DICTIONARY allows to specify dependencies, but we currently
      don't actually specify those. As we need this for getting the module
      dependencies right (as we can't build missing modules on demand), we should
      add those dependencies here. Then those dependencies propagate to the
      rootcling invocation which will in the future also generate the C++ module
      for the selected dictionary.
      8a646b53
  19. Jun 06, 2017
    • Vassil Vassilev's avatar
      Do not confuse clang-format. · 68a8a335
      Vassil Vassilev authored
      ClassImp is a macro defined in Rtypes.h. It can be written without trailing
      semicolon. However, clang-format is based on lexing and it doesn't know at
      all about preprocessors and how to expand macros. When visiting ClassImp(X)
      it thinks this is not a completed entity (as it doesn't expand macros) and
      considers the next line as continuation of the previous.
      
      Inserting a semicolon fixes the issue and makes formatting with clang-format
      in the ROOT codebase less tricky.
      68a8a335
  20. Apr 11, 2017
  21. Mar 28, 2017
  22. Mar 03, 2017
  23. Mar 01, 2017
  24. Feb 28, 2017
  25. Feb 14, 2017
    • Raphael Isemann's avatar
      Remove all redundant header guards around include directives · 04fe6d5d
      Raphael Isemann authored
      
      Many headers contains redundant header guards around #include directives:
      
          #ifndef ROOT_TTree
          #include "TTree.h"
          #endif
      
      This patch removes the #ifndef's around these includes as they
      don't serve any pratical purpose anymore and are no longer part
      of the current ROOT coding convention.
      
      This patch also fixes the 153 typos that are contained in the
      symbols of the #ifndef directives.
      
      Signed-off-by: default avatarVassil Vassilev <vvasilev@cern.ch>
      04fe6d5d
  26. Dec 17, 2016
  27. Dec 14, 2016
    • Vassil Vassilev's avatar
      Move each header in a submodule. · 8d6b3e8d
      Vassil Vassilev authored
      This is the recommended way of using the modules feature and should pave our way
      of enabling -fmodules-local-submodules-visibility mode.
      8d6b3e8d
    • Vassil Vassilev's avatar
      [cmake][make] Automatically generate bug chunk of the modulemap. · ca144dfa
      Vassil Vassilev authored
      Our two build systems can generate almost entirely a modulemap file laying out
      one module per library. Due to some non-modular implementation in ROOT's core we
      still need to treat some header files specially.
      
      This patch appends modular header files to the modulemap while skipping the
      predefined ones. Configure-make relates all headers that are installed in
      $ROOTSYS/include to their library whereas relates only headers which are part of
      library's dictionary.
      ca144dfa
  28. Mar 15, 2016
Loading