Skip to content
Snippets Groups Projects
  1. Sep 03, 2018
  2. Aug 30, 2018
  3. Dec 04, 2017
    • Julien Nabet's avatar
      cppcheck: fix some reports · cd6fa81b
      Julien Nabet authored
      [net/monalisa/src/TMonaLisaWriter.cxx:956] -> [net/monalisa/src/TMonaLisaWriter.cxx:957]: (error) Iterator 'iter' used after element has been erased.
      [proof/proofd/src/XrdProofdProofServMgr.cxx:4648] -> [proof/proofd/src/XrdProofdProofServMgr.cxx:4646]: (error) Iterator 'iter' used after element has been erased.
      
      [math/minuit2/src/Minuit2Minimizer.cxx:669] -> [math/minuit2/src/Minuit2Minimizer.cxx:669]: (style) Same expression on both sides of '||'.
      [math/minuit2/src/Minuit2Minimizer.cxx:736] -> [math/minuit2/src/Minuit2Minimizer.cxx:736]: (style) Same expression on both sides of '||'.
      [math/minuit2/src/Minuit2Minimizer.cxx:753] -> [math/minuit2/src/Minuit2Minimizer.cxx:753]: (style) Same expression on both sides of '||'.
      
      [tree/tree/src/TBasket.cxx:852]: (style) Redundant condition: If 'flag >= 80', the comparison 'flag' is always true.
      [misc/table/src/TFileIter.cxx:467] -> [misc/table/src/TFileIter.cxx:468]: (warning) Identical condition 'thisRunNumber<runNumber', second condition is always false
      
      [math/mathcore/src/TMath.cxx:826]: (style) Array index 'ia' is used before limits check.
      [math/mathcore/src/TMath.cxx:830]: (style) Array index 'ib' is used before limits check.
      [math/mathcore/src/triangle.c:15434]: (style) Array index 'aspectindex' is used before limits check.
      [roofit/roofit/src/RooIntegralMorph.cxx:375]: (style) Array index 'igapHigh' is used before limits check.
      
      [core/winnt/src/TWinNTSystem.cxx:5035]: (style) Statements following return, break, continue, goto or throw will never be executed.
      [tree/treeplayer/src/TSelectorDraw.cxx:380]: (style) Statements following return, break, continue, goto or throw will never be executed.
      
      [net/auth/src/TAuthenticate.cxx:4205]: (error) Resource leak: fd
      [roofit/roofitcore/src/BidirMMapPipe.cxx:1880]: (error) Memory leak: s
      [tree/tree/src/TLeaf.cxx:222]: (error) Memory leak: countname
      [tree/tree/src/TLeaf.cxx:226]: (error) Memory leak: countname
      [tmva/tmva/src/MethodBase.cxx:2783]: (error) Memory leak: pdfS
      [tmva/tmva/src/MethodBase.cxx:2783]: (error) Memory leak: pdfB
      
      [roofit/roofitcore/src/RooAbsArg.cxx:280]: (style) Redundant checking of STL container element existence before removing it.
      
      [core/dictgen/src/rootcling_impl.cxx:457]: (performance) Possible inefficient checking for 'fieldSelRules' emptiness.
      [core/dictgen/src/rootcling_impl.cxx:4573]: (performance) Possible inefficient checking for 'filesIncludedByLinkdef' emptiness.
      [gui/canvaspainter/v7/src/TCanvasPainter.cxx:322]: (performance) Possible inefficient checking for 'fWebConn' emptiness.
      [gui/canvaspainter/v7/src/TCanvasPainter.cxx:374]: (performance) Possible inefficient checking for 'fCmds' emptiness.
      [gui/canvaspainter/v7/src/TCanvasPainter.cxx:419]: (performance) Possible inefficient checking for 'fWebConn' emptiness.
      [gui/canvaspainter/v7/src/TCanvasPainter.cxx:475]: (performance) Possible inefficient checking for 'fWebConn' emptiness.
      [gui/canvaspainter/v7/src/TCanvasPainter.cxx:587]: (performance) Possible inefficient checking for 'fCmds' emptiness.
      [gui/canvaspainter/v7/src/TCanvasPainter.cxx:787]: (performance) Possible inefficient checking for 'fCmds' emptiness.
      [html/src/TDocParser.cxx:684]: (performance) Possible inefficient checking for 'currentType' emptiness.
      [proof/proofd/src/XrdProofdManager.cxx:804]: (performance) Possible inefficient checking for 'uwrks' emptiness.
      [proof/proofd/src/XrdProofdSandbox.cxx:467]: (performance) Possible inefficient checking for 'staglst' emptiness.
      [proof/proofd/src/XrdProofdSandbox.cxx:571]: (performance) Possible inefficient checking for 'actln' emptiness.
      [roofit/roofitcore/src/RooSimWSTool.cxx:574]: (performance) Possible inefficient checking for 'slist' emptiness.
      
      all the reports Prefer prefix ++/-- operators for non-primitive types
      cd6fa81b
  4. Jun 29, 2016
    • Gerardo Ganis's avatar
      xproofd: use xrootd to serve files on the same port, instead of rootd · e30da89a
      Gerardo Ganis authored
      For setups having limitations with open ports, such as in some cases PoD, xproofd provides the
      possibility to serve the files produced during running via the same port. This was implemented
      by starting a rootd process upon an incoming request for a file. The use of xrootd for this
      purpose was not possible with earlier versions of XRootD (up to 3) because the file serving
      protocol was not available as separate plug-in.
      This patch enables the use of xrootd for this purpose and deprecates the use of rootd .
      e30da89a
  5. May 09, 2016
  6. Jun 26, 2015
  7. Aug 05, 2014
  8. Jul 22, 2014
  9. Jul 21, 2014
    • Gerardo Ganis's avatar
      Support for XRootD 4 · 84177b59
      Gerardo Ganis authored
      This patch - together with  cc884ecb832f025af4dd5eea0eb27ad017e76b0d - adds support fro XRootD version 4.
      The bulk of the patch copes with the changes in the XRootD network classes to support IPv6. The rest is mostly
      handling of the changes in packaging.
      The PROOF part still uses the old XrdClient (still delivered with XRootD).
      
      Conflicts:
      	configure
      	proof/proofd/src/XrdProofdNetMgr.cxx
      84177b59
  10. May 17, 2014
  11. Mar 06, 2013
  12. Dec 19, 2012
  13. Dec 13, 2012
    • Gerardo Ganis's avatar
      · 9e2c5096
      Gerardo Ganis authored
         Fixes in xproofd:
         - Make sure that unused XrdProofdResponse objects are properly invalidated instead of deleted;
           this avoids improper usage of invalid instances and subsequent crashes.
         - Fix problem with two variables being initialized only once in recurrant loops; this prevented
           proper Reset of XrdProofdProofServ instances and proper active session accounting (and session
           cleanup).
      
      
      git-svn-id: http://root.cern.ch/svn/root/trunk@48015 27541ba8-7e3a-0410-8455-c3a389f83636
      9e2c5096
  14. Jun 25, 2012
  15. Jun 04, 2012
  16. May 31, 2012
  17. May 03, 2012
  18. Feb 22, 2012
  19. Oct 24, 2011
  20. Oct 13, 2011
  21. May 13, 2011
    • Gerardo Ganis's avatar
      · 3b1e269c
      Gerardo Ganis authored
        Patch implementing an interface to start proofserv processes with an external launcher
        and an implementation using 'system' instead of 'fork', as done in PROOF-Lite. The goal
        is to consolidate the startup process, avoiding the problems related to forking in a
        multi-thread process.
        For the moment the new startup is disabled by default and can be enabled via a new
        switch 'userfork' in the 'proofservmgr' directive:
      
                        xpd.proofservmgr usefork:0
      
      
      git-svn-id: http://root.cern.ch/svn/root/trunk@39178 27541ba8-7e3a-0410-8455-c3a389f83636
      3b1e269c
  22. Apr 20, 2011
  23. Feb 25, 2011
    • Gerardo Ganis's avatar
      · b7a90a71
      Gerardo Ganis authored
        Add the possibility to access the files on the workers via the same port used
        by PROOF. This is useful for cases when it is not possible to start a file server
        daemon on a different port (because, for eample, of a firewall or just inconvenience)
        and workers do not share a file system.
        Internally this works by forking a 'rootd' after identifying a file request and
        trasferring the connection to it. The client side is a TNetFile and it is triggered
        by the protocol "rootd://" (the just implemented etc/plugins/TFile/P120_TNetFile.C
        includes this protocol).
        On the server-side this new service is disabled by default and requires the directive
        
             xpd.rootd allow
      
        to be active. By default the 'rootd' is started in 'read-only' mode and no authentication.
        This can be change with some switches supported by the directive; for example
       
             xpd.rootd allow auth:full mode:rw
      
        starts 'rootd' in 'read-write' mode and authentication controlled by etc/system.rootdaemonrc .
        The list of avaialbe switches is documented at
      
             http://root.cern.ch/drupal/content/configuration-reference-guide#rootd
      
        The directive 'xpd.rootdallow' can be used to define the list of hosts allowed to use
        this service: see
      
             http://root.cern.ch/drupal/content/configuration-reference-guide#rootdallow
      
        The default setting of the environment variable LOCALDATASERVER has been changed to be
        "rootd://<host>:<proof_port> if file-serving via 'rootd' is enabled. In this way 
        TProofOutputFile automatically sets the correct default URL for further access from the
        master or other workers.
        The can always be overwritten with a dedicated 'xpd.putenv LOCALDATASERVER=<my_setting>'
        directive .
      
      
      git-svn-id: http://root.cern.ch/svn/root/trunk@38227 27541ba8-7e3a-0410-8455-c3a389f83636
      b7a90a71
  24. May 06, 2010
    • Gerardo Ganis's avatar
      · ba3528fb
      Gerardo Ganis authored
         - Fix an issue with parsing non 'xpd.' directives defining a string or an int
         - Make sure that XrdProofdTrace is always defined when loading the XrdproofdProtocol
           in a generic xrootd; fixes a crash in case of an error in parsing the directives
      
      
      git-svn-id: http://root.cern.ch/svn/root/trunk@33410 27541ba8-7e3a-0410-8455-c3a389f83636
      ba3528fb
  25. Dec 18, 2009
    • Gerardo Ganis's avatar
      · 9f1bc637
      Gerardo Ganis authored
         In case of failure, return an error from XrdProofdProtocol::SendData and
         XrdProofdProtocol::SendDataN, so that master and/or clients can stop collection
         on the socket.
      
      
      git-svn-id: http://root.cern.ch/svn/root/trunk@31934 27541ba8-7e3a-0410-8455-c3a389f83636
      9f1bc637
  26. Nov 27, 2009
    • Gerardo Ganis's avatar
      · d6e8231c
      Gerardo Ganis authored
         - Fix a backward compatibility issue with the recently introduced status files
         - Improve synchronization between parent and child during fork
         - Optimize loops over directory entries
         - Improve error and notification messages
      
      
      git-svn-id: http://root.cern.ch/svn/root/trunk@31441 27541ba8-7e3a-0410-8455-c3a389f83636
      d6e8231c
  27. Nov 06, 2009
    • Gerardo Ganis's avatar
      · 8915db50
      Gerardo Ganis authored
         Save the status of a 'proofserv' session into a new file in the 'activesessions' area.
         The full path of the new file is
      
                <admin_path>/.xproofd.<port>/activesessions/<user>.<group>.<pid>.status
      
         The status indicates whether the session is idle, running or queued.
         The status is updated every 'checkfq' secs (see xpd.proofservmgr; default 30 s).
         The status is dumped by the reader thread of TXProofServ and therefore its r/w access
         is protected.
      
         This change is needed for PoD optimizations.
      
      
      git-svn-id: http://root.cern.ch/svn/root/trunk@31012 27541ba8-7e3a-0410-8455-c3a389f83636
      8915db50
  28. Oct 29, 2009
  29. Oct 24, 2009
    • Gerardo Ganis's avatar
      · b367cee5
      Gerardo Ganis authored
        Patch for improved performance monitoring: 
        Add propagation of number of sessions, number of active sessions, number of sessions
        sharing workers with a session.
      
      
      git-svn-id: http://root.cern.ch/svn/root/trunk@30858 27541ba8-7e3a-0410-8455-c3a389f83636
      b367cee5
  30. Jul 25, 2009
  31. Jun 22, 2009
    • Rene Brun's avatar
      From Gerri: · 3ca7114d
      Rene Brun authored
      Fixes for report #51364
        - In XrdProofdNetMgr, validate the proof.conf file only at the moment when it is really used
        - When parsing configuration directives, use XrdOucStream::GetWord() instead of XrdOucStream::GetToken()
          so that variable substitution is fully active; this allows to write more concise and less error-prone
          configuration files
      
      
      git-svn-id: http://root.cern.ch/svn/root/trunk@29127 27541ba8-7e3a-0410-8455-c3a389f83636
      3ca7114d
  32. Jun 17, 2009
    • Gerardo Ganis's avatar
      · 81ef3e8a
      Gerardo Ganis authored
         Consolidation of the XrdProofd plug-in
         - Optimize length of locked sections in the XrdProofdResponse::Send methods, XrdProofdAux::PostPipe,
           XrdProofdClientMgr::GetClient and in XrdProofdProofServMgr::CleanClientSessions
         - In XrdProofdProtocol::Recycle, delete the XrdProofdResponse objects when clearing the corresponding
           vector
         - In XrdProofdClient:
           - make sure that the instance is avlid before acting
           - remove unused method PostSessionRemoval
           - rename Reset to ResetSessions
         - In XrdProofdAdmin::CleanupSessions, fix a problem preventing a timeout to be effective
         - In XrdProofdProofServMgr::SetUserEnvironment, make sure that USER is also exported for the new session
         - In XrdProofdProofServMgr and XrdSecProtocolpwd, fix a problem with the ownership of the exported
           credentials file
      
      
      git-svn-id: http://root.cern.ch/svn/root/trunk@29058 27541ba8-7e3a-0410-8455-c3a389f83636
      81ef3e8a
  33. May 13, 2009
    • Gerardo Ganis's avatar
      · 3dc78894
      Gerardo Ganis authored
         - Fix a potential source of deadlocks due to the usage of vnsprintf
         - Fixes for permission related failures during initialization of dataset managers:
           - Add the possibility to define the dataset information sources via the
             directive 'xpd.datasetsrc'. In this way the permissions should be
             set correctly and the related problems disappear.
           - In TProofDataSetManagerFile, switch in browse mode (instead of failing
             construction) if the write permissions are not present.
      
      
      git-svn-id: http://root.cern.ch/svn/root/trunk@28590 27541ba8-7e3a-0410-8455-c3a389f83636
      3dc78894
  34. Apr 29, 2009
  35. Apr 28, 2009
  36. Apr 02, 2009
  37. Mar 17, 2009
    • Gerardo Ganis's avatar
      · ba6e58fa
      Gerardo Ganis authored
         Build also a binary named 'xproofd' which runs a xrootd daemon with only the XrdProofdProtocol
         (i.e. no data serving).
         This simplifies setups when data serving is not needed and also allows to better disantagle
         problems related to one specific protocol.
      
      
      git-svn-id: http://root.cern.ch/svn/root/trunk@27848 27541ba8-7e3a-0410-8455-c3a389f83636
      ba6e58fa
  38. Jan 28, 2009
  39. Jan 25, 2009
    • Gerardo Ganis's avatar
      · 8c817e79
      Gerardo Ganis authored
        Patch adding support for session queuing in the scheduler (from Jan and me).
        This allows to control the number of sessions allowed to process queries concurrently.
        The feature is enabled by a new parameter 'queue:fifo' in the 'xpd.schedparam'
        directive.
      
        In case of static worker assigment (default, random, round-robin) the max number of
        running sessions can be limited by another new parameter 'mxrun'; for example
        'xpd.schedparam default mxrun:3 queue:fifo' will run concurrently only 3 sessions.
        Additional requests are queued and run as soon as one of the running sessions goes idle.
        The current policy is FIFO, so that there is a rotation among queued sessions.
      
        In the case of load-based worker assignement, the max number of running queries is
        determined dynamically.
      
        This option requires dynamic, per-job scheduling.
      
      
      git-svn-id: http://root.cern.ch/svn/root/trunk@27231 27541ba8-7e3a-0410-8455-c3a389f83636
      8c817e79
Loading