Skip to content
Snippets Groups Projects
  1. Jul 12, 2019
  2. Jul 10, 2019
  3. Jul 02, 2019
  4. Jul 01, 2019
    • Guilherme Amadio's avatar
      Escape special characters before using source/build dirs in regex · 7552ce3e
      Guilherme Amadio authored
      If "^${CMAKE_SOURCE_DIR}" contains special characters, the regular
      expression will break with an error like this for Garfield++:
      
      RegularExpression::compile(): Nested *?+.
      RegularExpression::compile(): Error in compile.
      CMake Error at .../RootNewMacros.cmake:288 (if):
        if given arguments:
      
          "NOT" "IS_ABSOLUTE" "incdir"
          "OR" "incdir" "MATCHES" "^/<...>/src/Garfield++/HEAD"
          "OR" "incdir" "MATCHES" "^"
          "OR" "incdir" "MATCHES" "^"
      
        Regular expression
        "^/<...>/src/Garfield++/HEAD"
        cannot compile
      Call Stack (most recent call first):
        CMakeLists.txt:118 (ROOT_GENERATE_DICTIONARY)
      
      Also, the (current) build directory is CMAKE_(CURRENT_)BINARY_DIR.
      Related Jira issue: ROOT-10210.
      7552ce3e
    • Guilherme Amadio's avatar
      Let CMake handle CUDA requirements · e9968cdc
      Guilherme Amadio authored
      CMake should already know which versions of CUDA are required
      depending on which standard is being used. The current setup
      forbids compiling with C++17 for the host code and C++14 for
      CUDA. This will require modifications in TMVA to work, but
      relaxing this restriction will at least allow compilation of
      ROOT with CUDA and C++17 when it's supported by Nvidia.
      e9968cdc
    • Guilherme Amadio's avatar
      Move use of option values after call to ROOT_APPLY_OPTIONS() · 5e0a9cce
      Guilherme Amadio authored
      Option values *must not be used* before calling the function
      ROOT_APPLY_OPTIONS(). This function is responsible for setting
      all values using the defaults and what was passed on the command
      line, so values before the call are not what the user asked for.
      5e0a9cce
    • Guilherme Amadio's avatar
      Do not disable tmva when -Dmlp=OFF, but fail to configure · fd32708f
      Guilherme Amadio authored
      CMake options specified on the command line should not change their
      value during configuration. Only default values are allowed to change
      (i.e. ${option}_defvalue not ${option}). See ROOT-9385 for more info.
      fd32708f
    • Guilherme Amadio's avatar
      3f67c219
    • Axel Naumann's avatar
      [CMake] Add copyright to ROOT cmake/modules files. · 760d1ce7
      Axel Naumann authored
      Pere agreed.
      760d1ce7
    • Vassil Vassilev's avatar
      [cmake] Fix typo in docs. · 1eed4ec6
      Vassil Vassilev authored
      1eed4ec6
  5. Jun 28, 2019
  6. Jun 26, 2019
    • Guilherme Amadio's avatar
      Fix capitalization in FindUnuran.cmake · 0cb7c2a6
      Guilherme Amadio authored
      The package name in the call to find_package_handle_standard_args()
      function must match what is used in the call to find_package() and
      the find module name (e.g. FindUnuran.cmake). If there is a mismatch,
      then find_package(Unuran REQUIRED) will not cause the desired failure
      during configuration when the package is not found. CMake will define
      both Unuran_FOUND and UNURAN_FOUND for compatibility reasons.
      Unverified
      0cb7c2a6
    • Guilherme Amadio's avatar
      Remove 'explicitlink' option (breaks compilation if disabled) · 88ed0c6e
      Guilherme Amadio authored
      This option is ported from ROOT 5.x but disabling it makes
      compilation break since a long time. Fixes: ROOT-9449.
      88ed0c6e
  7. Jun 21, 2019
  8. Jun 20, 2019
  9. Jun 19, 2019
    • Vassil Vassilev's avatar
      [cxxmodules] Read the rdict file from the module file. · cd15c50d
      Vassil Vassilev authored
      This patch enables TCling to read the Rdict file content from the module file
      directly. This is possible because the module file mmaps the Rdict content and
      we can create a TMemFile around this blob region.
      
      When we have runtime_cxxmodules on, we do not need to dependency-track the
      rdict.pcm files as they do not exist by themselves.
      cd15c50d
Loading