Skip to content
Snippets Groups Projects
  1. Jan 30, 2019
    • Yuka Takahashi's avatar
      [cxxmodule] Fix a warning in modules build · 3c6cf1ee
      Yuka Takahashi authored
      Not expose ROOT/RConfig.h to rootcling, but to add the header to
      ROOT_Config pcm.
      3c6cf1ee
    • Lorenzo Moneta's avatar
      Use for bin edge comparisons an epsilon abs value that is computed as a... · 1f75abe2
      Lorenzo Moneta authored
      Use for bin edge comparisons an epsilon abs value that is computed as a fraction of bin width. This would give a more robust comparison test.
      This should fix what has been shown in ROOT-7752
      1f75abe2
    • Sergey Linev's avatar
      geom: create TGeoCone with name in TGeoBuilder · fb1357ce
      Sergey Linev authored
      Looks like only TGeoCone was ignoring name.
      Fixes error described in https://root-forum.cern.ch/t/32493
      fb1357ce
    • Stephan Hageboeck's avatar
      Add R__SUGGEST_ALTERNATIVE macro to flag legacy functions · 247ecf1a
      Stephan Hageboeck authored
      Functions that are outdated, but will not be removed, can be flagged with `R__SUGGEST_ALTERNATIVE`, a macro expanding to ROOT's `_R__DEPRECATED_LATER`. This can be used to point users to the recommended interfaces.
      
      Flagging a function like this:
      TIterator* createIterator() const
      R__SUGGEST_ALTERNATIVE("begin(), end() and range-based for loops are faster.") {
         ...
      }
      
      and defining `R__SUGGEST_NEW_INTERFACE` in a translation unit will trigger a warning such as:
      RooChebychev.cxx:66:34: warning: 'createIterator' is deprecated: There is a superior alternative: begin(), end() and range-based for loops are faster. [-Wdeprecated-declarations]
        TIterator* coefIter = coefList.createIterator();
      
      IMPORTANT:
      Theoretically, the macro could be used for classes: Don't!
      This will trigger warnings for all uses of the class in the interfaces of ROOT.
      247ecf1a
    • Danilo Piparo's avatar
    • Stephan Hageboeck's avatar
      [RF] Reactivate copy assignment for HistFactory classes · 68635da6
      Stephan Hageboeck authored
      * Make histfactory Samples copy-assignable.
      Rootbench depends on copy assignment for the Sample class. After implementing move semantics to speed up hist2workspace, the copy assignment had been implicitly deleted. This was fixed, and a gtest has been added.
      * Further, HistRef, a member of Sample, is now movable, and the histograms given back by Sample are now const TH1* instead of TH1*.
      68635da6
    • Stephan Hageboeck's avatar
      [RF] Improve RooFit tutorials · 77fcbbb0
      Stephan Hageboeck authored
      * Temporaries in python: In the RooFit python tutorials, C++ objects save pointers to objects held by python. When these are temporaries, this leads to crashes. Naming the temporaries works around this problem.
      * rf204a: Add a new tutorial that demonstrates using extended pdfs when fitting in multiple ranges.
      77fcbbb0
    • Yuka Takahashi's avatar
      [cxxmodule] Infer proper modulename from library · b3e0431e
      Yuka Takahashi authored
      Before RegisterModule was assuming that "modulename" starts from "lib",
      which is not the case for CMSSW where the "modulename" is
      "SimDataFormatsValidationFormats_xr" for example.
      b3e0431e
  2. Jan 29, 2019
  3. Jan 28, 2019
  4. Jan 25, 2019
Loading