There seems to be a confusion between crypt(3) and crypto(7) here.
The crypt function is defined in unistd.h and is used for password
and data encryption, while crypto is OpenSSL's library implementing
cryptographic algorithms used in Internet standards.

crypt  - https://www.unix.com/man-page/all/3C/crypt
crypto - https://www.openssl.org/docs/man1.1.1/man7/crypto.html

This module was introduced with CMake 3.12, so we cannot remove it yet.

ROOT only uses client headers, but the module considers PostgreSQL
not found if server headers are not found.

The module from CMake is more complete and has support for Windows.

This reverts commit 0f5415c3.
The revert was not necessary, the problem was in hist2workspace.

ROOT can build and start. Autoloading does not work yet.

RooAbsSelfCached* were using a local variable that has the same name as a function.

Usually the system packages have the version as a suffix,
whereas if one builds clang by hand the name is llvm-config.

* TMVA-GUI: fix group folder name for methods

When writing trained methods to the output file, there was a typo in the
target directory. This lead to the results of a  method of type "BDT" and
name "MyBDT" being placed (incorrectly) in a folder named
"Method_MyBDT/MyBDT".

This patch places the data correctly in "Method_BDT/BDT". This is
important since e.g. the GUI relies on all BDT's being placed in the
"MethodBDT" folder.

Squashed commits (slight refactoring and fixups):
* TMVA: MethodBase -- fix indentation isses
* TMVA: MethodBase -- refactor datasetName
* TMVA: fix line wrapping
* TMVA: refactor for clarity and better naming
* clang-format
* fix typo in type
* `fFactoryBaseDir` is _not_ a field of MethodBase
* Fix directory name in envelope test

Re-factor FindFirstBinAbove and FindLastBinAbove by implementing a common function for all histogram dimensions.
Add possibility to look in a range, re-implemnting on top of  PR #1533 from @ksmith0.

The additional firstBin and lastBin arguments limit the axis being
searched for the bin above or threshold. If the firstBin term is less
than 1 it is set to 1. If the lastBin term is less than 0 or greater than
the number of bins the value is set to the number of bins for that axis.

If not built with the same compiler, CMAKE_CXX_FLAGS may contain
flags not known by the default compiler, which will make the test
fail. In particular using Ninja + Clang on Linux makes this test
fail with the error below without this patch.

c++: error: unrecognized command line option ‘-fcolor-diagnostics’
ninja: build stopped: subcommand failed.

clang-tidy would run the wrong checks/no checks at all because of a missing comma.

ParseOption("READ") returns EMode::kRead, so we know that
the if will never execute, and that we do not need to create
the file, since we are reusing external data. Nevertheless,
make the file a zombie if the input buffer is empty, since
a read-only empty file is otherwise useless.

Using nbytes we get a buffer only as big as last thing
written with TMemFile::Write(), which causes many memory
allocations to expand the TBufferFile to the same size
as the TBufferMergerFile. Related JIRA issue: ROOT-9133.