Skip to content
Snippets Groups Projects
  1. Jul 16, 2018
    • Guilherme Amadio's avatar
      Use all-keyword style in target_link_libraries() · fe4ffa75
      Guilherme Amadio authored
      When using builtin_openssl=ON, CMake erroneously exports the builtin
      static libraries in ROOTConfig-targets.cmake, which causes problems with
      dependent projects. In order to avoid this, we need Net and RHTTP to use
      SSL as a private dependency. Since CMake requires target_link_libraries()
      to either be all-plain (as before) or all-keyword (required to allow
      PRIVATE linking), we need to move the build system to use all-keyword
      linking only.
      
      Fixes: ROOT-9532
      fe4ffa75
  2. May 29, 2018
    • Guilherme Amadio's avatar
      [VecOps] Disable finite math functions for old glibc · a882aae0
      Guilherme Amadio authored
      These functions (enabled when -ffast-math is used) were only added
      in glibc 2.15. However, SLC 6 still uses glibc 2.12 and clang does
      not check before emitting the symbols, so linkage with clang is
      broken when fast math is enabled.
      a882aae0
  3. May 25, 2018
  4. May 23, 2018
  5. May 04, 2018
  6. May 02, 2018
    • Guilherme Amadio's avatar
      Drop from -Ofast to -O3 to compile VecOps · 456833cf
      Guilherme Amadio authored
      Using -ffast-math is causing linking problems like the one below in the
      nightly builds with Clang 7 + GCC 6.2:
      
      CMakeFiles/VecOps.dir/src/TVec.cxx.o: In function `exp':
       /.../include/c++/6.2.0/cmath:246: undefined reference to `__expf_finite'
      
      This is because when linking with -ffast-math, the compiler is expecting
      the symbol __expf_finite to be in libm.so, but it is not there:
      
      $ nm -D /lib/libm-2.12.so | grep expf
      00012010 W cexpf
      00010aa0 W expf
      000141d0 W frexpf
      00014240 W ldexpf
      
      The vectorized math functions were only introduced in glibc-2.22, so
      on a machine with a more recent glibc, however, the symbols are there:
      
      $ nm -D /lib/libm-2.26.so | grep expf
      000000000004d5d0 W cexpf
      000000000006bbe0 W cexpf128
      000000000000f930 W expf
      000000000006fb10 W expf128
      0000000000050f20 T __expf128_finite
      0000000000040de0 T __expf_finite
      00000000000489b0 W frexpf
      0000000000064080 W frexpf128
      0000000000048a60 W ldexpf
      00000000000641b0 W ldexpf128
      
      More information: https://sourceware.org/glibc/wiki/libmvec
      456833cf
  7. Apr 28, 2018
  8. Apr 27, 2018
  9. Apr 12, 2018
Loading