Skip to content
Snippets Groups Projects
  1. Mar 19, 2023
  2. Mar 18, 2023
  3. Mar 17, 2023
    • Lorenzo Moneta's avatar
      [hist] Improve TEfficiency::Fit and handling of binned likelihood fits in Fitter · aeefd628
      Lorenzo Moneta authored
      Improve the binomial fit use by TEfficiency::Fit by setting the correct chi2 and number of degree of freedom.
      
      Add function in Fitter to set number of fit points and fit type. When the fit type is a binned likelihood fit used as chi2 value to report 2 * minFCN
      
      Fix also the copying of the TF1 object after fitting. Use IsA()->New() instead of copy constructor which will not work correctly for TF2 and TF3 objects
      aeefd628
    • Jonas Rembser's avatar
      [RF] Use `std::vector` diretly in RooVectorDataStore::RealFullVector · 82d17fb6
      Jonas Rembser authored
      This follows up on a previous commit 92fbd0db with the title:
      ```
      [RF] Modernize `RooVectorDataStore::RealFullVector` class
      ```
      
      It changed the type of the `RooVectorDataStore::RealFullVector` members from
      `std::vector<double>*` to `std::unique_ptr<std::vector<double>>` while
      increasing the class version.
      
      However, while reasing old workspaces with the previous class version
      worked perfectly fine, there were logged errors when writing and then
      reading back a dataset with weight errors in ROOT `master`:
      
      ```
      TStreamerInfo::BuildOld:0: RuntimeWarning: Cannot convert RooVectorDataStore::RealFullVector::_vecE from type: vector<double> to type: vector<double>, skip element
      TStreamerInfo::BuildOld:0: RuntimeWarning: Cannot convert RooVectorDataStore::RealFullVector::_vecEL from type: vector<double> to type: vector<double>, skip element
      TStreamerInfo::BuildOld:0: RuntimeWarning: Cannot convert RooVectorDataStore::RealFullVector::_vecEH from type: vector<double> to type: vector<double>, skip element
      ```
      
      This was very unexpected. Maybe there is some problem with the IO of
      class members of type `std::unique_ptr<std::vector<double>>`. This
      commit suggests to fix this problem by using `std::vector<double>`
      directly, which makes the code much simpler anyway. It also allows us to
      get rid of a workaround in `RealFullVector::Streamer()` where it was not
      clear if this workaround is still needed or not.
      
      The class version is not incremented further, because the last increment
      only happened a few days ago, and no new ROOT version has been released
      since then.
      82d17fb6
    • olemorud's avatar
      [CI] Add annotations for warnings · 73ab7f6b
      olemorud authored
      73ab7f6b
  4. Mar 16, 2023
  5. Mar 15, 2023
  6. Mar 14, 2023
  7. Mar 13, 2023
Loading