Skip to content
Snippets Groups Projects
  1. Sep 06, 2018
  2. Aug 09, 2018
  3. Jul 16, 2018
    • Guilherme Amadio's avatar
      Use all-keyword style in target_link_libraries() · fe4ffa75
      Guilherme Amadio authored
      When using builtin_openssl=ON, CMake erroneously exports the builtin
      static libraries in ROOTConfig-targets.cmake, which causes problems with
      dependent projects. In order to avoid this, we need Net and RHTTP to use
      SSL as a private dependency. Since CMake requires target_link_libraries()
      to either be all-plain (as before) or all-keyword (required to allow
      PRIVATE linking), we need to move the build system to use all-keyword
      linking only.
      
      Fixes: ROOT-9532
      fe4ffa75
  4. Jun 27, 2018
  5. Jun 05, 2018
  6. May 18, 2018
  7. May 17, 2018
  8. May 04, 2018
  9. May 03, 2018
  10. Apr 24, 2018
  11. Apr 19, 2018
  12. Apr 18, 2018
    • Guilherme Amadio's avatar
      Drop unnecessary include_directories(${DAVIX_INCLUDE_DIRS}) · 8e4d8588
      Guilherme Amadio authored
      This include directory is now added automatically by the imported
      target for Davix.
      8e4d8588
    • Guilherme Amadio's avatar
      Add dynamic loading libraries to imported target for Davix · 1b864da5
      Guilherme Amadio authored
      OpenSSL needs -ldl, but does not propagate that properly, so
      when linked statically into Davix, there are missing symbols:
      
      builtins/davix/DAVIX-prefix/lib/libdavix.a(davixcontext.cpp.o):
      	In function `Davix::LibPath::LibPath()':
      builtins/davix/DAVIX-prefix/src/DAVIX/src/davixcontext.cpp:154:
      	undefined reference to `dladdr'
      builtins/openssl/OPENSSL-prefix/lib/libcrypto.a(dso_dlfcn.o):
      	In function `dlfcn_globallookup':
      dso_dlfcn.c:(.text+0x11): undefined reference to `dlopen'
      dso_dlfcn.c:(.text+0x24): undefined reference to `dlsym'
      dso_dlfcn.c:(.text+0x2f): undefined reference to `dlclose'
      
      Therefore we need to add ${CMAKE_DL_LIBS} to the Davix::Davix
      imported target so that -ldl gets added when linking to Davix.
      We can then remove the ${SYSLIBS} from RDAVIX, which had this
      role before.
      1b864da5
    • Guilherme Amadio's avatar
      Do not look for Davix a second time · a5ef03ca
      Guilherme Amadio authored
      In some builds calling find_package(PkgConfig) more than once fails
      with an error like the one below:
      
      -- Checking for module 'davix>=0.6.4'
      --   Found davix, version 0.6.7
      ...
      -- Checking for module 'davix>=0.6.4'
      --
      CMake Error at [...]/share/cmake-3.7/Modules/FindPkgConfig.cmake:415 (message):
        A required package was not found
      Call Stack (most recent call first):
        [...]/share/cmake-3.7/Modules/FindPkgConfig.cmake:588 (_pkg_check_modules_internal)
        cmake/modules/FindDavix.cmake:61 (pkg_check_modules)
        cmake/modules/SearchInstalledSoftware.cmake:9 (_find_package)
        net/davix/CMakeLists.txt:6 (find_package)
      
      -- Configuring incomplete, errors occurred!
      a5ef03ca
  13. Apr 17, 2018
  14. Apr 12, 2018
Loading