Skip to content
Snippets Groups Projects
  1. Sep 25, 2018
  2. Sep 21, 2018
  3. Sep 20, 2018
    • Elie Khairallah's avatar
      Final changes to py2help new (#2516) · dc825fc4
      Elie Khairallah authored
      * Centralise the generation of help for root command
      
      Add argparse2help.py, add root-argparse.py, delete the old help of root, add the cmake commands needed to generate the header containing the command line options help and to generate manual page for the root command.
      
      The python file argparse2help.py can be called with the root-argparse.py and the output name as arguments. This call will generate the header file if the output has an extension ".h" and will generate the manual page if the extension is ".1"
      
      * Centralise the generation of help for the rest of the commands
      
      Add cmake changes to generate headers and manual pages for rootcling hadd and hist2workspace
      Delete old man pages of hadd and hist2workspace
      Add commented out generation of man pages for python commands, we need to add a dependency before uncommenting them out
      Add hadd rootcling hist2workspace argparse modules
      
      * make the path compatible with windows
      
      * review modifications
      
      * add dependency on the input and the generation script of man pages
      
      * remove installation of headers
      
      * Update CMakeLists.txt
      
      It makes no sense to generates man pages on Windows. Windows does not have the `man` command.
      
      * Update argparse2help.py
      
      * Update argparse2help.py
      
      * Update argparse2help.py
      
      * Update hadd.cxx
      
      haddCommandLineOptionsHelp.h was not included for windows
      
      * Update root-argparse.py
      
      add the option --version
      
      * Update argparse2help.py
      
      simplified version (Thanks Bertrand !)
      dc825fc4
  4. Sep 13, 2018
  5. Sep 07, 2018
  6. Sep 04, 2018
  7. Sep 03, 2018
  8. Aug 14, 2018
  9. May 30, 2018
  10. May 24, 2018
  11. May 15, 2018
  12. May 04, 2018
  13. Apr 27, 2018
  14. Apr 10, 2018
  15. Mar 27, 2018
  16. Mar 20, 2018
  17. Mar 19, 2018
  18. Mar 15, 2018
  19. Mar 14, 2018
  20. Mar 13, 2018
  21. Mar 12, 2018
  22. Mar 11, 2018
  23. Mar 09, 2018
    • Yuka Takahashi's avatar
      Delete RooCintUtils.h and RooCintUtils.cxx (#1722) · 01472a0a
      Yuka Takahashi authored
      * Delete RooCintUtils.h and RooCintUtils.cxx
      
      I know this is not a small change, so any comments are welcome!
      
      Background:
      RooCintUtils was providing a wrapper between Cint and roofit. This implementation is very old, and is
      using Cint iteration interface a lot. Recently we were trying to kill
      RooCintUtils code where its using iteration and to change them to new
      Cling interface in order to improve the performance.
      
      RooCintUtils is an utility class, so this is internal namespace which is only used inside roofit.
      Since there are just 3 methods left, this RooCintUtils is no longer
      worth spending a file. Let's delete this and migrate methods to
      RooFactoryWSTool.
      
      * Put routines into anonymous namespace and made static
      Unverified
      01472a0a
    • Yuka Takahashi's avatar
      Remove redundant RooCintUtils.h · 89624575
      Yuka Takahashi authored
      There files were not using RooCintUtils.h which is an implementation for
      old interpreter.
      89624575
  24. Mar 07, 2018
  25. Feb 22, 2018
    • Julien Nabet's avatar
      Fix some cppcheck reports · 0ebc4cbc
      Julien Nabet authored
      [core/winnt/src/TWinNTSystem.cxx:996]: (error) Invalid number of character '(' when these macros are defined: 'ROOTPREFIX'.
      [html/src/TDocDirective.cxx:316]: (error) Invalid number of character '{' when these macros are defined: 'R__BEPAEPSTLICHERALSDERPAPST'.
      [math/mathcore/src/Delaunay2D.cxx:30]: (error) Invalid number of character '{' when these macros are defined: 'HAS_CGAL'.
      
      [graf2d/qt/src/TGQt.cxx:2817]: (error) Array 'shape[15]' accessed at index 15, which is out of bounds.
      [graf2d/qt/src/TGQt.cxx:2818]: (error) Array 'shape[15]' accessed at index 16, which is out of bounds.
      [graf2d/qt/src/TGQt.cxx:2841]: (error) Array 'shape[15]' accessed at index 15, which is out of bounds.
      [net/http/civetweb/handle_form.inl:627]: (style) Array index 'd' is used before limits check.
      
      [roofit/roostats/src/MetropolisHastings.cxx:153]: (style) Condition 'i<1000' is always true
      
      [graf2d/qt/src/TQtClientGuard.cxx:289]: (warning) Assert statement modifies 'thisPix'.
      
      [roofit/roofitcore/src/BidirMMapPipe.cxx:906]: (style) Throwing a copy of the caught exception instead of rethrowing the original exception.
      [roofit/roofitcore/src/BidirMMapPipe.cxx:972]: (style) Throwing a copy of the caught exception instead of rethrowing the original exception.
      [roofit/roofitcore/src/BidirMMapPipe.cxx:1394]: (style) Throwing a copy of the caught exception instead of rethrowing the original exception.
      [roofit/roofitcore/src/BidirMMapPipe.cxx:1429]: (style) Throwing a copy of the caught exception instead of rethrowing the original exception.
      
      [graf3d/eve/src/TEveElement.cxx:1745]: (style) Exception should be caught by reference.
      [roofit/histfactory/src/hist2workspace.cxx:76]: (style) Exception should be caught by reference.
      [roofit/histfactory/src/hist2workspace.cxx:97]: (style) Exception should be caught by reference.
      [roofit/roofitcore/src/RooClassFactory.cxx:786]: (style) Exception should be caught by reference.
      [roofit/roofitcore/src/RooFactoryWSTool.cxx:413]: (style) Exception should be caught by reference.
      [roofit/roofitcore/src/RooFactoryWSTool.cxx:484]: (style) Exception should be caught by reference.
      [roofit/roofitcore/src/RooFactoryWSTool.cxx:526]: (style) Exception should be caught by reference.
      [roofit/roofitcore/src/RooFactoryWSTool.cxx:568]: (style) Exception should be caught by reference.
      [roofit/roofitcore/src/RooFactoryWSTool.cxx:588]: (style) Exception should be caught by reference.
      [roofit/roofitcore/src/RooFactoryWSTool.cxx:629]: (style) Exception should be caught by reference.
      [roofit/roofitcore/src/RooFactoryWSTool.cxx:642]: (style) Exception should be caught by reference.
      [roofit/roofitcore/src/RooFactoryWSTool.cxx:681]: (style) Exception should be caught by reference.
      [roofit/roofitcore/src/RooFactoryWSTool.cxx:859]: (style) Exception should be caught by reference.
      [tmva/tmva/src/CostComplexityPruneTool.cxx:131]: (style) Exception should be caught by reference.
      [tmva/tmva/src/CostComplexityPruneTool.cxx:142]: (style) Exception should be caught by reference.
      [tmva/tmva/src/DataSet.cxx:173]: (style) Exception should be caught by reference.
      [tmva/tmva/src/Reader.cxx:636]: (style) Exception should be caught by reference.
      [tmva/tmva/src/Reader.cxx:702]: (style) Exception should be caught by reference.
      [tmva/tmva/src/VariableGaussTransform.cxx:751]: (style) Exception should be caught by reference.
      
      [io/sql/src/TSQLStructure.cxx:1931] -> [io/sql/src/TSQLStructure.cxx:1933]: (warning) Identical condition 'len==0', second condition is always false
      0ebc4cbc
  26. Feb 06, 2018
  27. Dec 11, 2017
Loading