Skip to content
Snippets Groups Projects
  1. Sep 07, 2018
  2. Apr 10, 2018
    • Wolf Behrenhoff's avatar
      Correct misleading indentation · 417cce0c
      Wolf Behrenhoff authored
      In case of VariableTransform.cxx, reformatted the whole file as it was
      using 4 whitespaces indentation and had misleading indentation on the
      bottom.
      417cce0c
  3. Mar 27, 2018
  4. Feb 22, 2018
    • Julien Nabet's avatar
      Fix some cppcheck reports · 0ebc4cbc
      Julien Nabet authored
      [core/winnt/src/TWinNTSystem.cxx:996]: (error) Invalid number of character '(' when these macros are defined: 'ROOTPREFIX'.
      [html/src/TDocDirective.cxx:316]: (error) Invalid number of character '{' when these macros are defined: 'R__BEPAEPSTLICHERALSDERPAPST'.
      [math/mathcore/src/Delaunay2D.cxx:30]: (error) Invalid number of character '{' when these macros are defined: 'HAS_CGAL'.
      
      [graf2d/qt/src/TGQt.cxx:2817]: (error) Array 'shape[15]' accessed at index 15, which is out of bounds.
      [graf2d/qt/src/TGQt.cxx:2818]: (error) Array 'shape[15]' accessed at index 16, which is out of bounds.
      [graf2d/qt/src/TGQt.cxx:2841]: (error) Array 'shape[15]' accessed at index 15, which is out of bounds.
      [net/http/civetweb/handle_form.inl:627]: (style) Array index 'd' is used before limits check.
      
      [roofit/roostats/src/MetropolisHastings.cxx:153]: (style) Condition 'i<1000' is always true
      
      [graf2d/qt/src/TQtClientGuard.cxx:289]: (warning) Assert statement modifies 'thisPix'.
      
      [roofit/roofitcore/src/BidirMMapPipe.cxx:906]: (style) Throwing a copy of the caught exception instead of rethrowing the original exception.
      [roofit/roofitcore/src/BidirMMapPipe.cxx:972]: (style) Throwing a copy of the caught exception instead of rethrowing the original exception.
      [roofit/roofitcore/src/BidirMMapPipe.cxx:1394]: (style) Throwing a copy of the caught exception instead of rethrowing the original exception.
      [roofit/roofitcore/src/BidirMMapPipe.cxx:1429]: (style) Throwing a copy of the caught exception instead of rethrowing the original exception.
      
      [graf3d/eve/src/TEveElement.cxx:1745]: (style) Exception should be caught by reference.
      [roofit/histfactory/src/hist2workspace.cxx:76]: (style) Exception should be caught by reference.
      [roofit/histfactory/src/hist2workspace.cxx:97]: (style) Exception should be caught by reference.
      [roofit/roofitcore/src/RooClassFactory.cxx:786]: (style) Exception should be caught by reference.
      [roofit/roofitcore/src/RooFactoryWSTool.cxx:413]: (style) Exception should be caught by reference.
      [roofit/roofitcore/src/RooFactoryWSTool.cxx:484]: (style) Exception should be caught by reference.
      [roofit/roofitcore/src/RooFactoryWSTool.cxx:526]: (style) Exception should be caught by reference.
      [roofit/roofitcore/src/RooFactoryWSTool.cxx:568]: (style) Exception should be caught by reference.
      [roofit/roofitcore/src/RooFactoryWSTool.cxx:588]: (style) Exception should be caught by reference.
      [roofit/roofitcore/src/RooFactoryWSTool.cxx:629]: (style) Exception should be caught by reference.
      [roofit/roofitcore/src/RooFactoryWSTool.cxx:642]: (style) Exception should be caught by reference.
      [roofit/roofitcore/src/RooFactoryWSTool.cxx:681]: (style) Exception should be caught by reference.
      [roofit/roofitcore/src/RooFactoryWSTool.cxx:859]: (style) Exception should be caught by reference.
      [tmva/tmva/src/CostComplexityPruneTool.cxx:131]: (style) Exception should be caught by reference.
      [tmva/tmva/src/CostComplexityPruneTool.cxx:142]: (style) Exception should be caught by reference.
      [tmva/tmva/src/DataSet.cxx:173]: (style) Exception should be caught by reference.
      [tmva/tmva/src/Reader.cxx:636]: (style) Exception should be caught by reference.
      [tmva/tmva/src/Reader.cxx:702]: (style) Exception should be caught by reference.
      [tmva/tmva/src/VariableGaussTransform.cxx:751]: (style) Exception should be caught by reference.
      
      [io/sql/src/TSQLStructure.cxx:1931] -> [io/sql/src/TSQLStructure.cxx:1933]: (warning) Identical condition 'len==0', second condition is always false
      0ebc4cbc
  5. Dec 04, 2017
    • Julien Nabet's avatar
      cppcheck: fix some reports · cd6fa81b
      Julien Nabet authored
      [net/monalisa/src/TMonaLisaWriter.cxx:956] -> [net/monalisa/src/TMonaLisaWriter.cxx:957]: (error) Iterator 'iter' used after element has been erased.
      [proof/proofd/src/XrdProofdProofServMgr.cxx:4648] -> [proof/proofd/src/XrdProofdProofServMgr.cxx:4646]: (error) Iterator 'iter' used after element has been erased.
      
      [math/minuit2/src/Minuit2Minimizer.cxx:669] -> [math/minuit2/src/Minuit2Minimizer.cxx:669]: (style) Same expression on both sides of '||'.
      [math/minuit2/src/Minuit2Minimizer.cxx:736] -> [math/minuit2/src/Minuit2Minimizer.cxx:736]: (style) Same expression on both sides of '||'.
      [math/minuit2/src/Minuit2Minimizer.cxx:753] -> [math/minuit2/src/Minuit2Minimizer.cxx:753]: (style) Same expression on both sides of '||'.
      
      [tree/tree/src/TBasket.cxx:852]: (style) Redundant condition: If 'flag >= 80', the comparison 'flag' is always true.
      [misc/table/src/TFileIter.cxx:467] -> [misc/table/src/TFileIter.cxx:468]: (warning) Identical condition 'thisRunNumber<runNumber', second condition is always false
      
      [math/mathcore/src/TMath.cxx:826]: (style) Array index 'ia' is used before limits check.
      [math/mathcore/src/TMath.cxx:830]: (style) Array index 'ib' is used before limits check.
      [math/mathcore/src/triangle.c:15434]: (style) Array index 'aspectindex' is used before limits check.
      [roofit/roofit/src/RooIntegralMorph.cxx:375]: (style) Array index 'igapHigh' is used before limits check.
      
      [core/winnt/src/TWinNTSystem.cxx:5035]: (style) Statements following return, break, continue, goto or throw will never be executed.
      [tree/treeplayer/src/TSelectorDraw.cxx:380]: (style) Statements following return, break, continue, goto or throw will never be executed.
      
      [net/auth/src/TAuthenticate.cxx:4205]: (error) Resource leak: fd
      [roofit/roofitcore/src/BidirMMapPipe.cxx:1880]: (error) Memory leak: s
      [tree/tree/src/TLeaf.cxx:222]: (error) Memory leak: countname
      [tree/tree/src/TLeaf.cxx:226]: (error) Memory leak: countname
      [tmva/tmva/src/MethodBase.cxx:2783]: (error) Memory leak: pdfS
      [tmva/tmva/src/MethodBase.cxx:2783]: (error) Memory leak: pdfB
      
      [roofit/roofitcore/src/RooAbsArg.cxx:280]: (style) Redundant checking of STL container element existence before removing it.
      
      [core/dictgen/src/rootcling_impl.cxx:457]: (performance) Possible inefficient checking for 'fieldSelRules' emptiness.
      [core/dictgen/src/rootcling_impl.cxx:4573]: (performance) Possible inefficient checking for 'filesIncludedByLinkdef' emptiness.
      [gui/canvaspainter/v7/src/TCanvasPainter.cxx:322]: (performance) Possible inefficient checking for 'fWebConn' emptiness.
      [gui/canvaspainter/v7/src/TCanvasPainter.cxx:374]: (performance) Possible inefficient checking for 'fCmds' emptiness.
      [gui/canvaspainter/v7/src/TCanvasPainter.cxx:419]: (performance) Possible inefficient checking for 'fWebConn' emptiness.
      [gui/canvaspainter/v7/src/TCanvasPainter.cxx:475]: (performance) Possible inefficient checking for 'fWebConn' emptiness.
      [gui/canvaspainter/v7/src/TCanvasPainter.cxx:587]: (performance) Possible inefficient checking for 'fCmds' emptiness.
      [gui/canvaspainter/v7/src/TCanvasPainter.cxx:787]: (performance) Possible inefficient checking for 'fCmds' emptiness.
      [html/src/TDocParser.cxx:684]: (performance) Possible inefficient checking for 'currentType' emptiness.
      [proof/proofd/src/XrdProofdManager.cxx:804]: (performance) Possible inefficient checking for 'uwrks' emptiness.
      [proof/proofd/src/XrdProofdSandbox.cxx:467]: (performance) Possible inefficient checking for 'staglst' emptiness.
      [proof/proofd/src/XrdProofdSandbox.cxx:571]: (performance) Possible inefficient checking for 'actln' emptiness.
      [roofit/roofitcore/src/RooSimWSTool.cxx:574]: (performance) Possible inefficient checking for 'slist' emptiness.
      
      all the reports Prefer prefix ++/-- operators for non-primitive types
      cd6fa81b
  6. Oct 27, 2017
  7. Oct 09, 2017
  8. Sep 01, 2017
  9. Jul 13, 2017
  10. Jun 06, 2017
    • Vassil Vassilev's avatar
      Do not confuse clang-format. · 68a8a335
      Vassil Vassilev authored
      ClassImp is a macro defined in Rtypes.h. It can be written without trailing
      semicolon. However, clang-format is based on lexing and it doesn't know at
      all about preprocessors and how to expand macros. When visiting ClassImp(X)
      it thinks this is not a completed entity (as it doesn't expand macros) and
      considers the next line as continuation of the previous.
      
      Inserting a semicolon fixes the issue and makes formatting with clang-format
      in the ROOT codebase less tricky.
      68a8a335
  11. Jun 04, 2017
  12. Feb 14, 2017
    • Raphael Isemann's avatar
      Remove all redundant header guards around include directives · 04fe6d5d
      Raphael Isemann authored
      
      Many headers contains redundant header guards around #include directives:
      
          #ifndef ROOT_TTree
          #include "TTree.h"
          #endif
      
      This patch removes the #ifndef's around these includes as they
      don't serve any pratical purpose anymore and are no longer part
      of the current ROOT coding convention.
      
      This patch also fixes the 153 typos that are contained in the
      symbols of the #ifndef directives.
      
      Signed-off-by: default avatarVassil Vassilev <vvasilev@cern.ch>
      04fe6d5d
  13. Feb 09, 2017
  14. Jan 28, 2017
  15. Jan 26, 2017
  16. Dec 17, 2016
  17. Dec 14, 2016
  18. Oct 05, 2016
  19. Sep 28, 2016
  20. Sep 12, 2016
  21. Jul 18, 2016
  22. Jun 23, 2016
  23. Jan 09, 2016
  24. Nov 13, 2015
  25. Aug 23, 2015
  26. Jul 31, 2015
  27. Jun 26, 2015
  28. Jun 05, 2015
  29. Jun 02, 2015
  30. Sep 25, 2014
  31. Aug 05, 2014
    • Philippe Canal's avatar
      Remove trailing spaces · 59b2b079
      Philippe Canal authored
      59b2b079
    • Philippe Canal's avatar
      Remove trailing spaces · a6bc8d71
      Philippe Canal authored
      a6bc8d71
    • Philippe Canal's avatar
      remove <TAB>'s. · ef2f6464
      Philippe Canal authored
      Conflicts:
      	bindings/pyroot/src/MethodProxy.cxx
      	cmake/modules/RootConfiguration.cmake
      	etc/http/files/main.htm
      	etc/http/files/single.htm
      	geom/geompainter/src/TGeoChecker.cxx
      	graf2d/mathtext/inc/mathtext.h
      	graf2d/mathtext/src/fontembed.cxx
      	graf2d/mathtext/src/fontembedps.cxx
      	graf2d/qt/inc/TQtCanvasPainter.h
      	gui/qtgsi/src/TQRootCanvas.cxx
      	hist/hist/src/TBackCompFitter.cxx
      	hist/hist/src/TEfficiency.cxx
      	hist/hist/src/TFractionFitter.cxx
      	hist/hist/src/TGraphAsymmErrors.cxx
      	hist/hist/src/TH2.cxx
      	hist/hist/src/TH3.cxx
      	hist/hist/src/TMultiDimFit.cxx
      	hist/hist/src/TProfile.cxx
      	hist/hist/src/TProfile2D.cxx
      	hist/hist/src/TUnfoldBinning.cxx
      	html/src/TDocParser.cxx
      	math/foam/src/TFoam.cxx
      	math/genvector/inc/Math/VectorUtil_Cint.h
      	math/minuit2/inc/Minuit2/FumiliMaximumLikelihoodFCN.h
      	math/minuit2/inc/Minuit2/FumiliStandardChi2FCN.h
      	math/minuit2/inc/Minuit2/FumiliStandardMaximumLikelihoodFCN.h
      	math/minuit2/inc/Minuit2/StackAllocator.h
      	math/minuit2/src/TChi2ExtendedFCN.cxx
      	math/minuit2/src/TChi2FCN.cxx
      	math/minuit2/src/TFitterMinuit.cxx
      	math/minuit2/src/TFumiliFCN.cxx
      	misc/table/src/TTableDescriptor.cxx
      	net/auth/src/rsaaux.cxx
      	test/QpRandomDriver.cxx
      	test/ios/RootBrowser/Src/Browser/Controllers/FileCollectionViewController.mm
      	test/ios/RootBrowser/Src/Browser/Controllers/FileContentViewController.mm
      	test/ios/RootBrowser/Src/Browser/Controllers/ObjectViewController.mm
      	test/ios/RootBrowser/Src/Browser/Views/PadView.mm
      	test/ios/RootBrowser/Src/CustomUI/RangeSlider.mm
      	test/ios/RootBrowser/Src/ObjectInspector/Controllers/AxisFontInspector.mm
      	test/ios/RootBrowser/Src/ObjectInspector/Controllers/AxisInspector.mm
      	test/ios/RootBrowser/Src/ObjectInspector/Controllers/AxisLabelsInspector.mm
      	test/ios/RootBrowser/Src/ObjectInspector/Controllers/AxisTitleInspector.mm
      	test/ios/RootBrowser/Src/ObjectInspector/Controllers/FilledAreaInspector.mm
      	test/ios/RootBrowser/Src/ObjectInspector/Controllers/H1BinsInspector.mm
      	test/ios/RootBrowser/Src/ObjectInspector/Controllers/H1ErrorsInspector.mm
      	test/ios/RootBrowser/Src/ObjectInspector/Controllers/H1Inspector.mm
      	test/ios/RootBrowser/Src/ObjectInspector/Controllers/InspectorWithNavigation.mm
      	test/ios/RootBrowser/Src/ObjectInspector/Controllers/LineInspector.mm
      	test/ios/RootBrowser/Src/ObjectInspector/Controllers/MarkerInspector.mm
      	test/ios/RootBrowser/Src/ObjectInspector/Controllers/ObjectInspector.mm
      	test/ios/RootBrowser/Src/ObjectInspector/Controllers/PadInspector.mm
      	test/ios/RootBrowser/Src/ObjectInspector/Controllers/PadTicksGridInspector.mm
      	test/ios/Tutorials/PadOptionsController.mm
      	test/ios/Tutorials/PadView.mm
      	test/periodic/NdbMF.cxx
      	test/periodic/NdbMTReacDesc.cxx
      	test/periodic/NdbMTReactionXS.cxx
      	test/periodic/NdbParticleList.cxx
      	test/periodic/XSGui.h
      	test/stressLinear.cxx
      	test/stressRooFit_tests.cxx
      	test/tcollbm.cxx
      	test/vmatrix.cxx
      	tutorials/eve/boxset.C
      	tutorials/geom/geodemo.C
      	tutorials/graphs/splines.C
      	tutorials/hist/th2polyEurope.C
      	tutorials/mc/CompareMasses.C
      	tutorials/memstat/memstat.C
      ef2f6464
Loading