Skip to content
Snippets Groups Projects
  1. Aug 19, 2021
  2. Aug 18, 2021
    • Ahmat's avatar
      [TMVA][SOFIE] Add Conv operator (#8800) · eb7c9c44
      Ahmat authored
      * Add Conv operator
      
      * Add tests for Conv
      
      * Small fixes
      
      * Add missing default constructor
      
      * Fix typos
      eb7c9c44
    • Jonas Rembser's avatar
      [RF][PyROOT] Update of RooFit pythonization doc infrastructure · 9c65dcc0
      Jonas Rembser authored
      * a Python decorator is introduced to set the `_cpp_signature` attribute
        of pythonization functions
      
      * the `print_roofit_pyz_doctrings.py` script now also deals with the
        case where `_cpp_signature` is a list of signatures, adding the
        PyROOT block to the documentaton of each function matched by the
        signatures
      
      * the Python docstring is now used to fill the doxygen documentation
        instead of the `_doxygen` attribute
      9c65dcc0
    • Jonas Rembser's avatar
      [RF][PyROOT] New mechanism for documentation of RooFit pythonizations · 4b8e2c22
      Jonas Rembser authored
      For the documentation of the RooFit pythonizations, we wanted to realize
      two things:
      
        * A PyROOT block in the doxygen documentation of the C++ class,
          indicating the pythonizations for a given class or function
      
        * A new doxygen page with only the content of all the RooFit PyROOT
          blocks to have a one-stop place to learn everything about RooFit
          pythonizations
      
      This commit proposes a new mechanism to do this, based on the existing
      RooFit pythonization mirror class infrastructure:
      
        * Every class or member function that should get a PyROOT block gets
          an can be patched with an attribute `_doxygen`, containing the
          contents of the PyROOT block
        * Member functions can also be patched with the attribute
          `cpp_signature`, specifying the C++ overload where the PyROOT block
          should go
        * A new scipt `print_roofit_pyz_doctrings.py` extracts this
          information, and this script is used to create a file
          `_roofit.pyzdoc` with all the doxygen source to generate both the
          PyROOT blocks in the existing documentation, as well as the separate
          page about all the RooFit pythonizations
      4b8e2c22
    • axmat's avatar
      Apply suggestions from code review · 0004733b
      axmat authored
      0004733b
    • axmat's avatar
      Fix protobuf · c8109226
      axmat authored
      c8109226
    • Enrico Guiraud's avatar
      [DF][NFC] Bring back doxygen docs for ROOT::RDF::ColumnNames_t (#8855) · c3b73148
      Enrico Guiraud authored
      For unclear reasons the `\cond` directive put _after_ the declaration
      of the `ColumnNames_t` alias inhibited docs for it being created.
      c3b73148
  3. Aug 17, 2021
    • Vincenzo Eduardo Padulano's avatar
      2572e056
    • Vincenzo Eduardo Padulano's avatar
      [DF] Send number of entries in tree to use in TChain::Add · 48e5d3e2
      Vincenzo Eduardo Padulano authored
      It is often desirable to call `TChain::Add` with the total number of entries in the file that is being added. This value is retrieved when iterating over the clusters of each file in the chain on the client and then sent as an attribute of the `TTreeRange` to the distributed workers.
      48e5d3e2
    • Vincenzo Eduardo Padulano's avatar
      [DF][NFC] Test Count independent of npartitions · db665c8a
      Vincenzo Eduardo Padulano authored
      Add a new test that checks the invariance of the result from a `Count` operation on a TTree based distributed RDataFrame irrespective of the number of partitions asked. This could have varied in some previously unsupported TEntryList cases.
      db665c8a
    • Vincenzo Eduardo Padulano's avatar
      [DF][NFC] Adapt tests to new TreeRange attributes · 54c6135f
      Vincenzo Eduardo Padulano authored
      Tests that check building of `TreeRange` objects now check for all attributes, excluding friend info that has its own separate tests. A test with an input file glob now checks against a full path due to TChain globbing.
      54c6135f
    • Vincenzo Eduardo Padulano's avatar
      [DF] TEntryList instead of Range for TTree based distributed RDF · 4086f2c0
      Vincenzo Eduardo Padulano authored
      This commit changes the way in which an input TTree based dataset is split in logical ranges of entries. It also changes the subsequent creation of an RDataFrame instance inside a distributed task.
      
      For a TTree based dataset, this happens through the creation of a TChain that represents the subset of the original dataset that contains the entries in the range assigned to the task.
      
      Before this commit:
      
      Any `TTreeRange` object would store a `start` and `end` entry attributes that would be global with respect to the TChain created inside
      the distributed task. TChain.SetCacheEntryRange(start, end) is called to make sure we don't read more than needed. An RDataFrame is
      created with the chain as argument. The Range operation is used to select only the entries of the TChain in the current task that are
      described by the input `TTreeRange`.
      
      After this commit:
      
      The input `TTreeRange` will report `globalstart` and `globalend` entries which are global with respect to the TChain of the task. But it
      will also report `localstarts` and `localends`, lists of respectively starting and ending entries which are local with respect to each
      single file of the TChain in the current task. A global `TEntryList` is created and filled with one sub-TEntryList per file in the chain
      through `TEntryList::AddSubList` method. Finally the global entry list is set on the chain via `TChain::SetEntryList` using option
      "sync". This allows to do a preselection directly in the TChain of the entries that should be processed or not. SetCacheEntryRange is
      still called to ensure we don't read more than needed (hence the need to still keep global entries in the range object). The TChain is
      finally passed as argument to an RDataFrame constructor.
      4086f2c0
    • Omar Zapata's avatar
      ROOT-R:fixed links to the users guide. · dace5167
      Omar Zapata authored
      dace5167
    • Omar Zapata's avatar
      ROOT-R: fixed segfault evaluating R code · 69cc3da4
      Omar Zapata authored
      69cc3da4
    • Mattias Ellert's avatar
      Adjust tests for s390x · 9641c8bf
      Mattias Ellert authored
      9641c8bf
    • Vassil Vassilev's avatar
      [cmake] Fix building ROOT with external llvm. · 0cddef5d
      Vassil Vassilev authored
      Fixes #8141.
      0cddef5d
  4. Aug 16, 2021
  5. Aug 13, 2021
  6. Aug 12, 2021
    • Jonas Rembser's avatar
      [RF] Various code modernizations in RooAbsCachedPdf · 686de808
      Jonas Rembser authored
      * replace `kTRUE` with `true` and `kFALSE` with `false`
      
      * replace `Double_t` with `double`
      
      * replace `Int_t` with `int` outside of data members
      
      * replace `0` with `nullptr` literals
      
      * replace C-style casts with `static_cast`
      
      * don't generally use `namespace std`
      
      * use `RooAbsCollection::empty()` and `RooAbsCollection::size()` instead
        of `RooAbsCollection::getSize()`
      686de808
    • Jonas Rembser's avatar
    • Jonas Rembser's avatar
      91f2f075
    • Enrico Guiraud's avatar
      [DF] Extract R[OneTime]Callback helper types from RLoopManager · 7bfce35d
      Enrico Guiraud authored
      To make the class more readable.
      7bfce35d
    • Enrico Guiraud's avatar
    • Enrico Guiraud's avatar
      [DF] Remove unused helper types · 9d5fdcfa
      Enrico Guiraud authored
      9d5fdcfa
    • Bertrand Bellenot's avatar
      Silent a couple of potential CMake Warnings (#8832) · fe88911b
      Bertrand Bellenot authored
      
      * Silent a couple of potential CMake Warnings
      
      Silent the following warnings when enabling arrow (`-Darrow=ON`) on Ubuntu:
      ```
      CMake Warning at cmake/modules/SearchInstalledSoftware.cmake:20 (_find_package):
        By not providing "Findre2.cmake" in CMAKE_MODULE_PATH this project has
        asked CMake to find a package configuration file provided by "re2", but
        CMake did not find one.
      
        Could not find a package configuration file provided by "re2" with any of
        the following names:
      
          re2Config.cmake
          re2-config.cmake
      
        Add the installation prefix of "re2" to CMAKE_PREFIX_PATH or set "re2_DIR"
        to a directory containing one of the above files.  If "re2" provides a
        separate development package or SDK, be sure it has been installed.
      Call Stack (most recent call first):
        /usr/lib/x86_64-linux-gnu/cmake/arrow/Findre2Alt.cmake:25 (find_package)
        cmake/modules/SearchInstalledSoftware.cmake:20 (_find_package)
        /usr/share/cmake-3.16/Modules/CMakeFindDependencyMacro.cmake:47 (find_package)
        /usr/lib/x86_64-linux-gnu/cmake/arrow/ArrowConfig.cmake:96 (find_dependency)
        cmake/modules/SearchInstalledSoftware.cmake:20 (_find_package)
        cmake/modules/FindArrow.cmake:206 (find_package)
        cmake/modules/FindArrow.cmake:313 (arrow_find_package_cmake_package_configuration)
        cmake/modules/FindArrow.cmake:350 (arrow_find_package)
        cmake/modules/SearchInstalledSoftware.cmake:20 (_find_package)
        cmake/modules/SearchInstalledSoftware.cmake:1088 (find_package)
        CMakeLists.txt:245 (include)
      ```
      and
      ```
      CMake Warning at cmake/modules/SearchInstalledSoftware.cmake:20 (_find_package):
        By not providing "Findc-ares.cmake" in CMAKE_MODULE_PATH this project has
        asked CMake to find a package configuration file provided by "c-ares", but
        CMake did not find one.
      
        Could not find a package configuration file provided by "c-ares" with any
        of the following names:
      
          c-aresConfig.cmake
          c-ares-config.cmake
      
        Add the installation prefix of "c-ares" to CMAKE_PREFIX_PATH or set
        "c-ares_DIR" to a directory containing one of the above files.  If "c-ares"
        provides a separate development package or SDK, be sure it has been
        installed.
      Call Stack (most recent call first):
        /usr/lib/x86_64-linux-gnu/cmake/arrow/Findc-aresAlt.cmake:25 (find_package)
        cmake/modules/SearchInstalledSoftware.cmake:20 (_find_package)
        /usr/share/cmake-3.16/Modules/CMakeFindDependencyMacro.cmake:47 (find_package)
        /usr/lib/x86_64-linux-gnu/cmake/arrow/ArrowConfig.cmake:96 (find_dependency)
        cmake/modules/SearchInstalledSoftware.cmake:20 (_find_package)
        cmake/modules/FindArrow.cmake:206 (find_package)
        cmake/modules/FindArrow.cmake:313 (arrow_find_package_cmake_package_configuration)
        cmake/modules/FindArrow.cmake:350 (arrow_find_package)
        cmake/modules/SearchInstalledSoftware.cmake:20 (_find_package)
        cmake/modules/SearchInstalledSoftware.cmake:1088 (find_package)
        CMakeLists.txt:245 (include)
      ```
      
      * Update cmake/modules/SearchInstalledSoftware.cmake
      
      Co-authored-by: default avatarEnrico Guiraud <enrico.guiraud@cern.ch>
      
      Co-authored-by: default avatarEnrico Guiraud <enrico.guiraud@cern.ch>
      fe88911b
    • Vassil Vassilev's avatar
      [cxxmodules] We are not yet ready to enable the module for R. · 28f8835b
      Vassil Vassilev authored
      We need several adjustments to do. First pre-loading of RInterface.pcm in
      root-project/root@5096f5fffc causes some crashes. Second we seem to still have
      issues when trying to resolve symbols from the Rcpp library.
      28f8835b
  7. Aug 11, 2021
Loading