- Jun 25, 2015
-
-
Patrick Gartung authored
-
Axel Naumann authored
-
David Abdurachmanov authored
This `std::vector` is allocated in `tmva/tmva/src/DataSetFactory.cxx` (line 162) and then passed to `TMVA::Event::Event()`. Then it's up to `TMVA::Event` to take care of releasing this memory. This solves a small memory leak. Signed-off-by:
David Abdurachmanov <David.Abdurachmanov@cern.ch>
-
Sergey Linev authored
Proper handling of '6.4g' formats kind, really try to extract signigicant number of digigts out of value Signed-off-by:
Bertrand Bellenot <bertrand.bellenot@cern.ch>
-
Pere Mato Vila authored
Added 'builtin_fftw3' option to build the FFTW static library that is used to build ROOT. The default is OFF.
-
Lorenzo Moneta authored
Reduce the memory taken for re-creating Tormula objects with the same expressions by using a local static map to cache the function pointers.
-
Pere Mato Vila authored
The patch adds missing OpenSSL include directories. Otherwise the ones from standard system location is being used, which might not be installed. E.g., CMSSW provides their own build of OpenSSL and build machines do not have OpenSSL libs and dev packages installed. Signed-off-by:
David Abdurachmanov <davidlt@cern.ch>
-
David Abdurachmanov authored
`OPENGL_FOUND` and `OPENGL_GLU_FOUND` are only available if `find_package(OpenGL)` is used, which is not the case if you are building without Cocoa on OSX. Check for `OPENGL_LIBRARIES` which is set in both if-statement paths. Signed-off-by:
David Abdurachmanov <davidlt@cern.ch>
-
Pere Mato Vila authored
Changed the XROOTD version to 4.2.1 when using 'builtin_xrootd' option. A number of warnings had to be silenced.
-
- Jun 23, 2015
-
-
Axel Naumann authored
This reverts commit 125a93e0. It fails in the following case (roottest/root/io/evolution/pragma_read): dictionary for a/b.h which includes a/c.h as #include "c.h" This will add a fwd decl with annotation "c.h", but this header cannot be found. Instead we'd need "a/c.h"...
-
Axel Naumann authored
-
Axel Naumann authored
-
Olivier Couet authored
fix ROOT-7414. Improve the algorithm to compute the lower limit of an axis in log scale when its real lower limit is 0
-
Sergey Linev authored
Required for normal HTML docu generation Signed-off-by:
Bertrand Bellenot <bertrand.bellenot@cern.ch>
-
Sergey Linev authored
Signed-off-by:
Bertrand Bellenot <bertrand.bellenot@cern.ch>
-
Sergey Linev authored
Signed-off-by:
Bertrand Bellenot <bertrand.bellenot@cern.ch>
-
Axel Naumann authored
-
Axel Naumann authored
-
Axel Naumann authored
-
Sergey Linev authored
Allow to bind http port with loopback address. This restrict access to http server only from localhost. One could either specify 'loopback' option in constructor: new THttpServer("http:8080?loopback") or in clear text specify IP address to which http socket should be bind: new THttpServer("http:127.0.0.1?loopback") If host has several network interfaces, one could select one from them Signed-off-by:
Bertrand Bellenot <bertrand.bellenot@cern.ch>
-
Sergey Linev authored
- when creating new tab, add it to direct child of top element, otherwise new tab can appear in other nested tabs - tab actiavted before drawing otherwise it is not visible and has wrong dimension, - SVG method GetBBox is not working for hidden elements in firefox, make workaround to prevent JavaScript exception Signed-off-by:
Bertrand Bellenot <bertrand.bellenot@cern.ch>
-
- Jun 22, 2015
-
-
Fons Rademakers authored
-
Fons Rademakers authored
-
Fons Rademakers authored
It now contains persistent information, only delete the generated index.html.
-
Axel Naumann authored
-
- Jun 21, 2015
-
-
Lorenzo Moneta authored
After reverting Tim patch in removing name in RooLinkedList we can set again the name in the detailed output list of RooAbsStudy
-
Lorenzo Moneta authored
Fix copy ctor of RooAbsAnaConvPdf. This problem was noticed by applying the previous patch of T. Adye in the RoolinkedList::Add to checking pointers added to the list. Restore the _name data member of RooLinkedList. This fixes the detailed output functionality of PROOF
-
- Jun 20, 2015
-
-
Lorenzo Moneta authored
-
- Jun 19, 2015
-
-
Lorenzo Moneta authored
Restores the speed of RooLinkedList lookups (and some other operations) to that from ROOT 5.34.17 and before. The hash table was used previously, but this was disabled in ROOT 5.34.18+ because it gave incorrect results when list entries were renamed. This patch allows the hash table to be used without risk of failure, improving the speed of operations that make heavy use of RooFit lists, such as combining and importing (eg. factor 3 on an import). Details from Tim Adye: An update (26/06/2014) included in ROOT 5.34.18 fixed name lookups with RooLinkedList::findArg() when a list element had been renamed, by disabling the hash table optimisation. There was still an issue with find(name) and when removing or replacing renamed elements. This patch should mostly restore (or even slightly improve on) the speed we had before that update (eg. in 5.34.17), but with corrected find, remove, and replace operations. For all this to work, I had to make a few changes to how the name registry is used. RooLinkedList now has _useNptr enabled by default, but only uses the name registry when it is safe and efficient to do so. If a RooAbsArg is ever renamed, a flag is set in the name registry (actually a bit in the new TNamed) to indicate that a hash table lookup may give a false negative for that name. That will permanently (for this job) prevent a quick lookup for that name, but that's OK since renaming is relatively rare. To speed up the name registry (which is now used more often), I increased its static hash table size from 31 to 100000. That might seem like a drastic change, but since this is a singleton it only adds 781 kilobytes to the total memory usage. This patch also includes a few minor fixes to RooHashTable: fix when a replaced element had a different name (slot), fix for find(TObject*) which always failed (but wasn't used), and a small optimisation for RooHashTable::findLinkTo().
-
Lorenzo Moneta authored
Several improvements to reduce the RooFit memory use, especially for the combined CMS Higgs coupling workspaces (eg. reduce the full CMS workspace requirements from 7.3 to 1.8 GB, with a more modest 5.3 to 4.6 GB improvement for an ATLAS workspace). Details from Wouter Verkerke: - For any RooSimultaneous component in which there is a pdf tagged with attribute "MAIN_MEASUREMENT", only that pdf is forwarded to the component calculator, thereby stripping of all subsidiary measurements (these are evaluated elsewhere anyway) This is already done automatically for ATLAS binned likelihood, where the BinnedLikelihood attribute has a similar effect. Since CMS attaches 2305 subsidiary measurements to each of their O(250) channels. this procedure avoids the replication of ~500,000 RooGaussians and 1.5 million associated RooRealVars. - The default buffer size allocation for TTree attached RooVectorDataStores is reduced from 4096 bytes per branch to 1024. - The initially reserved vector size of Roo(Obj)CacheManager for internally cached objects is reduced from 10 to 2. - The TNamed data member of RooLinkedList is removed (was only used in one very obscure place). - The chunk size for memory pools for RooLinkedListElems is reduced from 1M to 256K. To take advantage of this for the CMS workspace, the pdf terms should be tagged with the "MAIN_MEASUREMENT" attribute. If not already included, it can be added with the following code snippet. RooFIter iter = w->components().fwdIterator() ; RooAbsArg* arg ; while(arg=iter.next()) { if (arg->IsA()==RooAddPdf::Class() && TString(arg->GetName()).BeginsWith("pdf_")) { arg->setAttribute("MAIN_MEASUREMENT") ; cout << "component " << arg->GetName() << " is a cms main measurement" << endl ; } }
-
Lorenzo Moneta authored
from Wouter: change components to return a RooArgList instead of a RooArgSet to not remove duplicates (e.g. RooProduct of x*x )
-
Lorenzo Moneta authored
- Add Hash method to RooLinkedList otherwise it cannot be used correctly in THashList classes (e.g. when using it with PROOF) - Fix seeding of random numbers when using it with PROOF (use the worker number in the seeding) to be sure different seeds ar generated for each worker
-
Lorenzo Moneta authored
-
Lorenzo Moneta authored
-
Wouter Verkerke authored
- Introduce first moment as offset in calculation of second moment to promote numeric stability of calculation when first moment is large o RooCmdConfig - Increase length of string arguments allowed o RooCustomizer - When replace operations are executed with missing source or target expressions, ignore the offending operation with a warning message, rather than canceling the entire transaction
-
Lorenzo Moneta authored
Speed up RooWorkspace::import by using a has table for the internal Workspace collection if size is > 1000 and by speeding up the removal of the set which is cloned in the import. We don’t delete the set which calls safeDeleteList. It is not needed, the set contains a list of all the nodes, so we simply delete just one by one. Signed-off-by:
Wouter Verkerke <verkerke@nikhef.nl>
-
Lorenzo Moneta authored
Signed-off-by:
Wouter Verkerke <verkerke@nikhef.nl>
-
Lorenzo Moneta authored
Signed-off-by:
Wouter Verkerke <verkerke@nikhef.nl>
-