fix ~ 15 high impact coverity issues (Resource leaks in NumberCountingPdfFactory and Uninitilized variables  in other classes)


git-svn-id: http://root.cern.ch/svn/root/trunk@43992 27541ba8-7e3a-0410-8455-c3a389f83636

use noRounding for the Poisson of the sidebands since the noff value can be in some cause non-integer (i.e. be interpreted as a Gamma constraint)


git-svn-id: http://root.cern.ch/svn/root/trunk@43932 27541ba8-7e3a-0410-8455-c3a389f83636

 o RooWorkspace

  - Increase buffer size in defineSet() [ from M. Baak ]


git-svn-id: http://root.cern.ch/svn/root/trunk@43897 27541ba8-7e3a-0410-8455-c3a389f83636

counting datasets


git-svn-id: http://root.cern.ch/svn/root/trunk@43881 27541ba8-7e3a-0410-8455-c3a389f83636

git-svn-id: http://root.cern.ch/svn/root/trunk@43878 27541ba8-7e3a-0410-8455-c3a389f83636

do some cleanup pf header file of test statistics and the files they include, when trying to fix for bug 
https://savannah.cern.ch/bugs/index.php?93795


git-svn-id: http://root.cern.ch/svn/root/trunk@43847 27541ba8-7e3a-0410-8455-c3a389f83636

git-svn-id: http://root.cern.ch/svn/root/trunk@43686 27541ba8-7e3a-0410-8455-c3a389f83636

git-svn-id: http://root.cern.ch/svn/root/trunk@43683 27541ba8-7e3a-0410-8455-c3a389f83636

 These are the  fixes from Kyle: 

http://root.cern.ch/viewcvs?view=rev&revision=42965
http://root.cern.ch/viewcvs?view=rev&revision=43022


git-svn-id: http://root.cern.ch/svn/root/trunk@43451 27541ba8-7e3a-0410-8455-c3a389f83636

git-svn-id: http://root.cern.ch/svn/root/trunk@43445 27541ba8-7e3a-0410-8455-c3a389f83636

git-svn-id: http://root.cern.ch/svn/root/trunk@43422 27541ba8-7e3a-0410-8455-c3a389f83636

-fixes a typo in the XML parsing for an option that has rarely been used.
-adjusts the ranges of the nuisance parameters for the statistical uncertainties and adds a simple method that is needed for the analytical Barlow-Beeston-lite-like optimization.


git-svn-id: http://root.cern.ch/svn/root/trunk@43375 27541ba8-7e3a-0410-8455-c3a389f83636

git-svn-id: http://root.cern.ch/svn/root/trunk@43231 27541ba8-7e3a-0410-8455-c3a389f83636

 - some fixes for printout and tolerance


git-svn-id: http://root.cern.ch/svn/root/trunk@43228 27541ba8-7e3a-0410-8455-c3a389f83636

git-svn-id: http://root.cern.ch/svn/root/trunk@43200 27541ba8-7e3a-0410-8455-c3a389f83636

 new ToyMCImportanceSampler 
 new  version of the ToyMCSampler that can use multiple test statistics and "detailed output" of those test statistics.
 extension to the FrequentistCalculator that allows the user to manually specify the values for the signal nuisance parameters using SetConditionalMLEsNull/Alt().
 
 make  HypoTestResult managing now the  SamplingDIstribution for null and alt


git-svn-id: http://root.cern.ch/svn/root/trunk@43199 27541ba8-7e3a-0410-8455-c3a389f83636

   o RooHistConstraint

      - Fix compiler warning


git-svn-id: http://root.cern.ch/svn/root/trunk@43191 27541ba8-7e3a-0410-8455-c3a389f83636

 Import last set changes from 532 patch branch
 -----------------------------------------

   Fix 2 related bugs

     - Handling of pdfs with conditional observables in the likelihood

     - Make pdf integrals that are cached and interpolated also work 
       when one of the pdf observables is conditional

  
  o RooCachedReal

    - Propagate OperMode ADirty to function being cached


  o RooAbsCachedReal

     - Propagate OperMode ADirty to RooHistFunc that implements cache


  o RooVectorDataStore

    - NOCacheAndTrack will also disable caching of constant terms


  o RooAbsAnaConv

    - Declare original resolution model as NOCacheAndTrack to prevent
      superfluous cache calculations


  o RooAbsReal

    - In createIntObj() set caching wrapper to ADirty if the original integral
      is auto-determined to be so


  o RooAbsTestStatistic

     - Add debug option NCPU=-1, which amounts to NCPU=1, but run the the MP interface


  o RooNormSetCache

     - Fix bug in copy ctor


  o RooRealIntegral 

     - Fix bug in autoSelectDirtyMode() - only consider value servers, not sterile servers


  o RooAbsTestStatistic

    - Mark conditional observables in pdf, rather than in dataset, as that is what the new 
      vector-data-store uses


--------

  o RooVectorDataStore

     - In recalculateCache() only remove projected observables if they are defined
       (is more efficient when this feature is not used)


-------

  o RooParamHistFunc/RooHistConstraint

      - New classes representing a flexible histogram shape, and class representing a product of Poisson
        constraints on each of these bins


git-svn-id: http://root.cern.ch/svn/root/trunk@43190 27541ba8-7e3a-0410-8455-c3a389f83636

- fix generation of Asimov data for simple (not-extended) Gaussian models


git-svn-id: http://root.cern.ch/svn/root/trunk@43189 27541ba8-7e3a-0410-8455-c3a389f83636

git-svn-id: http://root.cern.ch/svn/root/trunk@43159 27541ba8-7e3a-0410-8455-c3a389f83636

git-svn-id: http://root.cern.ch/svn/root/trunk@43118 27541ba8-7e3a-0410-8455-c3a389f83636

in the AsymptoticCalculator.


git-svn-id: http://root.cern.ch/svn/root/trunk@43091 27541ba8-7e3a-0410-8455-c3a389f83636

merge patch http://root.cern.ch/viewvc?rev=43076&root=root&view=rev from Tim applied in 5.32 patches


git-svn-id: http://root.cern.ch/svn/root/trunk@43077 27541ba8-7e3a-0410-8455-c3a389f83636

Fix clang warnings: strlcpy(A, B, len) with len == strlen(B) instead of sizeof(A). Was okay in all cases, but double call to strlen() for no good reason.


git-svn-id: http://root.cern.ch/svn/root/trunk@43071 27541ba8-7e3a-0410-8455-c3a389f83636

see  http://root.cern.ch/viewvc?view=rev&revision=42988   for MarkovCHain, SamplingDistPlot and HypoTestPlot (from Sven)

     http://root.cern.ch/viewvc?view=rev&revision=42989  : set to false the default of usemultiGen in ToyMCSampler  (from Sven)

     http://root.cern.ch/viewvc?view=rev&revision=43017   : define a signed flag for the PL test statistics and have a a signed discovery TS (from Tim and Kyle)


git-svn-id: http://root.cern.ch/svn/root/trunk@43068 27541ba8-7e3a-0410-8455-c3a389f83636

  o RooDataSet

    - Increase string buffer size from 1024 to 10000


git-svn-id: http://root.cern.ch/svn/root/trunk@43042 27541ba8-7e3a-0410-8455-c3a389f83636

   o RooDataSet

     - Add missing weight() in fillHistogram


git-svn-id: http://root.cern.ch/svn/root/trunk@42985 27541ba8-7e3a-0410-8455-c3a389f83636

  Assorted bug fixes
 
  o Roo1DMomentMorphFunction, RooFunctorBinding, RooFunctor1DBinding, RooProdPdf, RooAbsRealLValue,
    RooSimSplitGenContext, RooBinIntegrator, RooVectorDataStore, RooSegmentedIntegrator, RooChangeTracker,
    RooAbsReal,RooFactoryWSTool, RooRealIntegral, RooTreeDataStore, RooUnitTest, RooAbsPdf
 
    - Coverity fixes (mostly missing initialization)


  o RooDataHist

    - Fix in bin volume correction for partial integrals


  o RooAbsData

    - Remove stray debug comment


  o RooObjCacheManager

    - Follow change in RooCacheManager


  o RooCacheManager

    - Back out LHCb version - new version that does same thing but works correctly


git-svn-id: http://root.cern.ch/svn/root/trunk@42984 27541ba8-7e3a-0410-8455-c3a389f83636

  Assorted bug fixes
 
  o RooUnblindPrecision,RooUnblindOffset,RooUnblindUniform,RooUnblindCPAsymVar

    - Fix default ctor for persistence (Savannah #91268)


  o RooBlindTools

    - Add default ctor


  o RooProdPdf

    - Set evaluation cutoff criteria to <= instead of < so that
      cutoff at zero actually terminates sequence (G. Raven)


  o RooAbsCachedReal, RooAbsCachedPdf

    - Fix signed/unsigned int mismatch


  o RooAbsAbsAnaConv

    - Cache range name strings in RooNameReg for faster lookup


  o RooAbsTestStatistic

    - Fix compiler warning


  o RooObjCacheManager

    - Follow changes in RooCacheManager<T>


  o RooHistPdf

    - In analytical integration, also fast-track integration over ranges
      if these ranges map to the nominal full range


  o RooCacheManager   

    - Use vector<T*> instead of T** for storage so that arrays grow
      with use (needed for LHCb fits)


git-svn-id: http://root.cern.ch/svn/root/trunk@42976 27541ba8-7e3a-0410-8455-c3a389f83636

  Assorted bug fixes
 
  o RooGaussModel

    - Fix 2 minus signs in cosh convolution term for flip-side decays
      (fixes Savannah #90845)


  o RooSpHarmonic

    - Fix in expression of partial integral (from G. Raven)


  o RooProdPdf, RooAbsAnaConvPdf, RooAddPdf

    - Adapt to auto-sizing AIC caches 



  o RooCachedReal

    - Eliminate progress indicator for cache filling


  o RooHistFunc

    - Advertise maximum of RooHistFunc through dedicated interface
      to speed up generation of pdfs that use a RooHistFunc as efficiency


  o RooAbsCachedReal

    - Move cache operation message from INFO to DEBUG level

  
  o RooAbsCollection

    - Inline method fwdIterator() for increased speed


  o RooAICRegistry

    - Use stl vector instead of static array for contents to avoid
      overflow when using complex pdfs [ R. Aaij ]


  o RooAbsTestStatistic

    - Fix memory leak (reported on Forum)


  o RooEffGenContext

    - More efficient implementation using kwown maximum value of efficiency
      function (if advertised) [ from G.Raven/R.Aaij ]


git-svn-id: http://root.cern.ch/svn/root/trunk@42963 27541ba8-7e3a-0410-8455-c3a389f83636

42180 to current HEAD (42958)


git-svn-id: http://root.cern.ch/svn/root/trunk@42959 27541ba8-7e3a-0410-8455-c3a389f83636

   Assorted bug fixes

   o RooChi2Var, RooXYChi2Var, RooDataWeightedAverage, RooNLLVar

     - Deploy upgraded interface of recalculateCache()


   o RooAbsDataStore

      - Extend interface for recalculateCache() to take needed
        info for smart recalculation when using NCPU>1 and to
        pass needed info for proper handling of normalization
        observables


   o RooCompositeDataStore

      - Forward recalculateCache() to components (should not
        be needed but just in case)


   o RooVectorDataStore

     - Treat conditional observables properly in the normalization
       set passed to cached pdfs

     - Only update elements that are actually being recalculated
       when using NumCPU>1


   o RooAbsAnaConv

     - Persist _model so that generation works after persistence

 
   o RooAbsReal

     - Disable cache-and-track when making plot projections
       with DataWeightedAverage, as this cannto work because
       the needed information for normalization is not available

     - Reinstate cloning of the function in fillDataHist(). Without
       it is is possible to trigger as accidental 'self-destruct'
       of cached normalization objects that call fillDataHist()


   o RooCachedReal

     - Make evaluate() return _func instead of null to make
       disableCache mode of base class functional

     - Initialize data member _useCdfBoundaries in all ctors


git-svn-id: http://root.cern.ch/svn/root/trunk@42950 27541ba8-7e3a-0410-8455-c3a389f83636

 == Fix bug in handling of cached conditional pdfs ==

  o RooVectorDataStore

    - Add argument to recalculateCache() that indicates conditional observables
      When passing normalization set to cached nodes removed conditional observables

  o RooNLLVar

    - Pass conditional observables to RooAbsDataStore::recalculateCache() 

  o RooAbsDataStore

    - Add argument to method recalculateCache()


git-svn-id: http://root.cern.ch/svn/root/trunk@42864 27541ba8-7e3a-0410-8455-c3a389f83636

add option in the constructor to use the nominal Asimov data set (i.e. the one where nuisance have nominal values when generating the data set)


git-svn-id: http://root.cern.ch/svn/root/trunk@42833 27541ba8-7e3a-0410-8455-c3a389f83636

  o RooEffProd

    - Bug fix in normalization integral when explicit normRange() is set


git-svn-id: http://root.cern.ch/svn/root/trunk@42830 27541ba8-7e3a-0410-8455-c3a389f83636

git-svn-id: http://root.cern.ch/svn/root/trunk@42829 27541ba8-7e3a-0410-8455-c3a389f83636

In this case the nuisance parameters are not set to the fitted value from the observed data but they are kept
at their nominal values
Implement the old method using the new one


git-svn-id: http://root.cern.ch/svn/root/trunk@42828 27541ba8-7e3a-0410-8455-c3a389f83636

  - Various optimizations and fixes from/for LHCb

   o RooAbsReal

     - Add new option setParameterizeIntegral() to optionally
       cache integrals in a RooCachedReal for all values of
       the given set of parameters

   o RooNameSet

     - Add setter method to support above change in RooAbsReal


   o RooAbsHiddenReal

     - Bug fix in blinding - fixes infinite loop


   o RooAbsAnaConvPdf

     - In analyticalIntegralWN() evaluate convolutions only if
       coefficient is not zero


git-svn-id: http://root.cern.ch/svn/root/trunk@42781 27541ba8-7e3a-0410-8455-c3a389f83636

  o RooTruthModel

    - Fix for stressRooFit failure


git-svn-id: http://root.cern.ch/svn/root/trunk@42737 27541ba8-7e3a-0410-8455-c3a389f83636

   o RooTruthModel

     - Fix analytical range integral for 'expBasis' (Bug report by P. Szczypka)
       (other terms still need to be fixed)


git-svn-id: http://root.cern.ch/svn/root/trunk@42734 27541ba8-7e3a-0410-8455-c3a389f83636