[Exp PyROOT] Implement and test converter for TString&

bindings/pyroot_experimental/PyROOT/test/tstring_converter.py

@@ -31,6 +31,13 @@ class TStringConverter(unittest.TestCase):
         self.check_type_conversion()
 
     def test_by_reference(self):
+        ROOT.gInterpreter.Declare("""
+        const char* myfun(TString &s) { return s.Data(); }
+        """)
+
+        self.check_type_conversion()
+
+    def test_by_const_reference(self):
         ROOT.gInterpreter.Declare("""
         const char* myfun(const TString &s) { return s.Data(); }
         """)

bindings/pyroot_experimental/cppyy/CPyCppyy/src/Converters.cxx

@@ -2070,6 +2070,7 @@ public:
 
     // factories for special cases
         gf["TString"] =                     (cf_t)+[](long) { return new TStringConverter{}; };
+        gf["TString&"] =                    (cf_t)+[](long) { return new TStringConverter{}; };
         gf["const TString&"] =              (cf_t)+[](long) { return new TStringConverter{}; };
         gf["const char*"] =                 (cf_t)+[](long) { return new CStringConverter{}; };
         gf["const char[]"] =                (cf_t)+[](long) { return new CStringConverter{}; };

bindings/pyroot_experimental/cppyy/patches/tstring_converter.patch

 diff --git a/bindings/pyroot_experimental/cppyy/CPyCppyy/src/Converters.cxx b/bindings/pyroot_experimental/cppyy/CPyCppyy/src/Converters.cxx
-index a470a41..e1b4961 100644
+index a470a41..56d486d 100644
 --- a/bindings/pyroot_experimental/cppyy/CPyCppyy/src/Converters.cxx
 +++ b/bindings/pyroot_experimental/cppyy/CPyCppyy/src/Converters.cxx
 @@ -1026,6 +1026,7 @@ bool CPyCppyy::name##Converter::ToMemory(PyObject* value, void* address)     \
@@ -10,11 +10,12 @@ index a470a41..e1b4961 100644
  CPPYY_IMPL_STRING_AS_PRIMITIVE_CONVERTER(STLString, std::string, c_str, size)
  CPPYY_IMPL_STRING_AS_PRIMITIVE_CONVERTER(STLStringViewBase, std::string_view, data, size)
  bool CPyCppyy::STLStringViewConverter::SetArg(
-@@ -2068,6 +2069,8 @@ public:
+@@ -2068,6 +2069,9 @@ public:
          gf["const ULong64_t&"] =            gf["const unsigned long long&"];
  
      // factories for special cases
 +        gf["TString"] =                     (cf_t)+[](long) { return new TStringConverter{}; };
++        gf["TString&"] =                    (cf_t)+[](long) { return new TStringConverter{}; };
 +        gf["const TString&"] =              (cf_t)+[](long) { return new TStringConverter{}; };
          gf["const char*"] =                 (cf_t)+[](long) { return new CStringConverter{}; };
          gf["const char[]"] =                (cf_t)+[](long) { return new CStringConverter{}; };