Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
R
Root
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Admin message
为了安全,强烈建议开启2FA双因子认证:User Settings -> Account -> Enable two-factor authentication!!!
Show more breadcrumbs
cxwx
Root
Commits
dad2e7e1
Commit
dad2e7e1
authored
7 years ago
by
Frederich Munch
Committed by
Philippe Canal
7 years ago
Browse files
Options
Downloads
Patches
Plain Diff
Store unresolved symbols in an unordered_set; have no need for ordering.
parent
cac0694b
No related branches found
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
interpreter/cling/lib/Interpreter/IncrementalExecutor.cpp
+4
-5
4 additions, 5 deletions
interpreter/cling/lib/Interpreter/IncrementalExecutor.cpp
interpreter/cling/lib/Interpreter/IncrementalExecutor.h
+2
-2
2 additions, 2 deletions
interpreter/cling/lib/Interpreter/IncrementalExecutor.h
with
6 additions
and
7 deletions
interpreter/cling/lib/Interpreter/IncrementalExecutor.cpp
+
4
−
5
View file @
dad2e7e1
...
...
@@ -358,18 +358,17 @@ bool IncrementalExecutor::diagnoseUnresolvedSymbols(llvm::StringRef trigger,
return
false
;
llvm
::
SmallVector
<
llvm
::
Function
*
,
128
>
funcsToFree
;
for
(
std
::
set
<
std
::
string
>::
const_iterator
i
=
m_unresolvedSymbols
.
begin
(),
e
=
m_unresolvedSymbols
.
end
();
i
!=
e
;
++
i
)
{
for
(
const
std
::
string
&
sym
:
m_unresolvedSymbols
)
{
#if 0
// FIXME: This causes a lot of test failures, for some reason it causes
// the call to HandleMissingFunction to be elided.
unsigned diagID = m_Diags.getCustomDiagID(clang::DiagnosticsEngine::Error,
"%0 unresolved while jitting %1");
(void)diagID;
//m_Diags.Report(diagID) <<
*i
<< funcname; // TODO: demangle the names.
//m_Diags.Report(diagID) <<
sym
<< funcname; // TODO: demangle the names.
#endif
cling
::
errs
()
<<
"IncrementalExecutor::executeFunction: symbol '"
<<
*
i
cling
::
errs
()
<<
"IncrementalExecutor::executeFunction: symbol '"
<<
sym
<<
"' unresolved while linking "
;
if
(
trigger
.
find
(
utils
::
Synthesize
::
UniquePrefix
)
!=
llvm
::
StringRef
::
npos
)
cling
::
errs
()
<<
"[cling interface function]"
;
...
...
@@ -383,7 +382,7 @@ bool IncrementalExecutor::diagnoseUnresolvedSymbols(llvm::StringRef trigger,
cling
::
errs
()
<<
"!
\n
"
;
// Be helpful, demangle!
std
::
string
demangledName
=
platform
::
Demangle
(
*
i
);
std
::
string
demangledName
=
platform
::
Demangle
(
sym
);
if
(
!
demangledName
.
empty
())
{
cling
::
errs
()
<<
"You are probably missing the definition of "
...
...
This diff is collapsed.
Click to expand it.
interpreter/cling/lib/Interpreter/IncrementalExecutor.h
+
2
−
2
View file @
dad2e7e1
...
...
@@ -22,7 +22,7 @@
#include
"llvm/ADT/StringRef.h"
#include
<vector>
#include
<set>
#include
<
unordered_
set>
#include
<map>
#include
<memory>
#include
<atomic>
...
...
@@ -126,7 +126,7 @@ namespace cling {
///\brief Set of the symbols that the JIT couldn't resolve.
///
std
::
set
<
std
::
string
>
m_unresolvedSymbols
;
std
::
unordered_
set
<
std
::
string
>
m_unresolvedSymbols
;
#if 0 // See FIXME in IncrementalExecutor.cpp
///\brief The diagnostics engine, printing out issues coming from the
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment