-
- Downloads
Fix memory leak in the Cocoa backend.
This was reported here: https://sft.its.cern.ch/jira/browse/ROOT-8951 Fix from Timur: 1. Add missing TGCocoa::ClosePixmap implementation. Apparently, while scanning for this function calls in TPad's code, I forgot to check TPadPainter and thus decided it's never used at all. 2. Make DestroyDrawable more 'atomic' - hide the fact that we first have to 'select drawable' (gVirtualX->SelectWindow(id) - note, SelectWindow for pixmap!!!) and then call ClosePixmap() - this is due to the old design problem/inconsistency in X11 backend and TPad::fPixmapID, which is not a real pixmap ID but some index that points to array where the real pixmap id is. Now DestroyDrawable accepts this fPixmapID and does all work of selecting pixmap and closing it.
Showing
- core/base/inc/TVirtualPadPainter.h 1 addition, 1 deletioncore/base/inc/TVirtualPadPainter.h
- graf2d/cocoa/src/TGCocoa.mm 5 additions, 0 deletionsgraf2d/cocoa/src/TGCocoa.mm
- graf2d/gpad/inc/TPadPainter.h 2 additions, 2 deletionsgraf2d/gpad/inc/TPadPainter.h
- graf2d/gpad/src/TPad.cxx 2 additions, 4 deletionsgraf2d/gpad/src/TPad.cxx
- graf2d/gpad/src/TPadPainter.cxx 4 additions, 3 deletionsgraf2d/gpad/src/TPadPainter.cxx
- graf3d/gl/inc/TGLPadPainter.h 2 additions, 2 deletionsgraf3d/gl/inc/TGLPadPainter.h
- graf3d/gl/src/TGLPadPainter.cxx 2 additions, 2 deletionsgraf3d/gl/src/TGLPadPainter.cxx
Loading
Please register or sign in to comment