-
- Downloads
[RF] Refactor RooFitHS3 to solve various bugs and improve usability
The first implementation of RooFitH3 had a number of shortcomings, which this PR addresses. In detail: * It is now possible to read JSON files independent of the ordering * A priority mechanism has been implemented for importers and exporters * Duplicate and dead code has been removed * Many small bugs have been fixed * The JSONInterface has been made public and moved from Detail to Experimental, so users can write their own importers & exporters * The two unit tests have been fixed Co-authored-by:Nicolas Morange <nicolas.morange@cern.ch> Co-authored-by:
Jonas Rembser <jonas.rembser@cern.ch>
Showing
- etc/RooFitHS3_wsexportkeys.json 14 additions, 8 deletionsetc/RooFitHS3_wsexportkeys.json
- etc/RooFitHS3_wsfactoryexpressions.json 12 additions, 6 deletionsetc/RooFitHS3_wsfactoryexpressions.json
- roofit/histfactory/inc/RooStats/HistFactory/PiecewiseInterpolation.h 3 additions, 2 deletions...factory/inc/RooStats/HistFactory/PiecewiseInterpolation.h
- roofit/histfactory/src/PiecewiseInterpolation.cxx 5 additions, 3 deletionsroofit/histfactory/src/PiecewiseInterpolation.cxx
- roofit/hs3/CMakeLists.txt 1 addition, 0 deletionsroofit/hs3/CMakeLists.txt
- roofit/hs3/inc/RooFitHS3/HistFactoryJSONTool.h 4 additions, 4 deletionsroofit/hs3/inc/RooFitHS3/HistFactoryJSONTool.h
- roofit/hs3/inc/RooFitHS3/JSONInterface.h 17 additions, 4 deletionsroofit/hs3/inc/RooFitHS3/JSONInterface.h
- roofit/hs3/inc/RooFitHS3/RooJSONFactoryWSTool.h 111 additions, 37 deletionsroofit/hs3/inc/RooFitHS3/RooJSONFactoryWSTool.h
- roofit/hs3/src/HistFactoryJSONTool.cxx 3 additions, 4 deletionsroofit/hs3/src/HistFactoryJSONTool.cxx
- roofit/hs3/src/JSONFactories_HistFactory.cxx 259 additions, 86 deletionsroofit/hs3/src/JSONFactories_HistFactory.cxx
- roofit/hs3/src/JSONFactories_RooFitCore.cxx 391 additions, 46 deletionsroofit/hs3/src/JSONFactories_RooFitCore.cxx
- roofit/hs3/src/JSONInterface.cxx 32 additions, 2 deletionsroofit/hs3/src/JSONInterface.cxx
- roofit/hs3/src/JSONParser.cxx 2 additions, 2 deletionsroofit/hs3/src/JSONParser.cxx
- roofit/hs3/src/JSONParser.h 3 additions, 2 deletionsroofit/hs3/src/JSONParser.h
- roofit/hs3/src/RYMLParser.h 1 addition, 1 deletionroofit/hs3/src/RYMLParser.h
- roofit/hs3/src/RooJSONFactoryWSTool.cxx 619 additions, 357 deletionsroofit/hs3/src/RooJSONFactoryWSTool.cxx
- roofit/hs3/test/testRooFitHS3.cxx 63 additions, 10 deletionsroofit/hs3/test/testRooFitHS3.cxx
- roofit/hs3/test/test_hs3_histfactory_json.py 17 additions, 21 deletionsroofit/hs3/test/test_hs3_histfactory_json.py
- roofit/roofit/inc/RooGaussian.h 9 additions, 0 deletionsroofit/roofit/inc/RooGaussian.h
- roofit/roofitcore/inc/RooBinSamplingPdf.h 4 additions, 0 deletionsroofit/roofitcore/inc/RooBinSamplingPdf.h
Loading
Please register or sign in to comment