-
- Downloads
[RF] Use `recursiveRedirectServers()` in NormalizationHelpers
In the `foldIntegrals()` function that reverses the unfolting of normalization integrals in the computation graph, some custom logic was used to redirect the servers. However, it caused some failures in the ASAN builds because it accessed invalid memory. This commit suggests to fix that by using the already existing `RooAbsArg::recursiveRedirectServers()` function for the same logic. Furthermore, in `unfoldIntegrals()`, clients outside the computation graph are not considered for the server redirection, which also fixes ASAN build failures.
Showing
- roofit/roofitcore/src/NormalizationHelpers.cxx 16 additions, 25 deletionsroofit/roofitcore/src/NormalizationHelpers.cxx
- roofit/roofitcore/src/NormalizationHelpers.h 1 addition, 0 deletionsroofit/roofitcore/src/NormalizationHelpers.h
- test/stressRooFit_tests.h 8 additions, 4 deletionstest/stressRooFit_tests.h
Loading
Please register or sign in to comment