fix ~ 15 high impact coverity issues (Resource leaks in...

fix ~ 15 high impact coverity issues (Resource leaks in NumberCountingPdfFactory and Uninitilized variables  in other classes)


git-svn-id: http://root.cern.ch/svn/root/trunk@43992 27541ba8-7e3a-0410-8455-c3a389f83636

roofit/roostats/inc/RooStats/AsymptoticCalculator.h

@@ -113,7 +113,6 @@ namespace RooStats {
    private: 
 
       bool fOneSided;                // for one sided PL test statistic
-      bool fNominalAsimov;  
       mutable int fUseQTilde;              // flag to indicate if using qtilde or not (-1 (default based on RooRealVar)), 0 false, 1 (true)
       static int fgPrintLevel;     // control print level  (0 minimal, 1 normal, 2 debug)
       mutable double fNLLObs; 

roofit/roostats/src/BayesianCalculator.cxx

@@ -625,6 +625,7 @@ BayesianCalculator::BayesianCalculator() :
    fSize(0.05), fLeftSideFraction(0.5), 
    fBrfPrecision(0.00005), 
    fNScanBins(-1),
+   fNumIterations(0),
    fValidInterval(false)
 {
    // default constructor
@@ -1280,7 +1281,7 @@ void BayesianCalculator::ComputeIntervalFromApproxPosterior(double lowerCutOff,
    if (!fApproxPosterior) return;
 
    double prob[2]; 
-   double limits[2];
+   double limits[2] = {0,0};
    prob[0] = lowerCutOff;
    prob[1] = upperCutOff; 
    fApproxPosterior->GetQuantiles(2,limits,prob);

roofit/roostats/src/HypoTestInverterResult.cxx

@@ -663,8 +663,8 @@ SamplingDistribution *  HypoTestInverterResult::GetLimitDistribution(bool lower
      delete distVec[i];  distVec[i] = 0;
      std::sort(pvalues.begin(), pvalues.end());
      // find the quantiles of the distribution 
-     double p[1]; 
-     double q[1];
+     double p[1] = {0}; 
+     double q[1] = {0};
 
      quantVec[i] = std::vector<double>(size);
      for (int ibin = 0; ibin < size; ++ibin) { 
@@ -689,7 +689,7 @@ SamplingDistribution *  HypoTestInverterResult::GetLimitDistribution(bool lower
   // loop on the p values and find the limit for each expected point in the quantiles vector  
   for (int j = 0; j < size; ++j ) {
 
-     TGraph g(ArraySize() );
+     TGraph g( npoints );
      for (int k = 0; k < npoints ; ++k) { 
         g.SetPoint(k, GetXValue(index[k]), (quantVec[index[k]])[j] );
      }
@@ -749,8 +749,11 @@ double  HypoTestInverterResult::GetExpectedLimit(double nsig, bool lower, const
    // else (default) find expected limit by obtaining first a full limit distributions
    // The last one is in general more correct
 
-
+   const int nEntries = ArraySize();
+   if (nEntries <= 0)  return (lower) ? 1 : 0;  // return 1 for lower, 0 for upper
+   
    HypoTestResult * r = dynamic_cast<HypoTestResult *> (fYObjects.First() );
+   assert(r != 0);
    if (!r->GetNullDistribution() && !r->GetAltDistribution() ) { 
       // we are in the asymptotic case 
       // get the limits obtained at the different sigma values 
@@ -763,8 +766,8 @@ double  HypoTestInverterResult::GetExpectedLimit(double nsig, bool lower, const
       return values[i];
    }
 
-   double p[1];
-   double q[1];
+   double p[1] = {0};
+   double q[1] = {0};
    p[0] = ROOT::Math::normal_cdf(nsig,1);
 
    // for CLs+b can get the quantiles of p-value distribution and 
@@ -776,7 +779,6 @@ double  HypoTestInverterResult::GetExpectedLimit(double nsig, bool lower, const
    option.ToUpper();
    if (option.Contains("P")) {
 
-      const int nEntries = ArraySize();
       TGraph  g(nEntries);   
 
       // sort the arrays based on the x values

roofit/roostats/src/NumberCountingPdfFactory.cxx

@@ -165,14 +165,13 @@ void NumberCountingPdfFactory::AddExpData(Double_t* sig,
    // Arguements are an array of expected signal, expected background, and relative 
    // background uncertainty (eg. 0.1 for 10% uncertainty), and the number of channels.
 
-   using std::vector;
-   Double_t* mainMeas = new Double_t[nbins];
+   std::vector<Double_t> mainMeas(nbins);
 
    // loop over channels
    for(Int_t i=0; i<nbins; ++i){
       mainMeas[i] = sig[i] + back[i];
    }
-   return AddData(mainMeas, back, back_syst, nbins, ws, dsName);
+   return AddData(&mainMeas[0], back, back_syst, nbins, ws, dsName);
 }
 
 //_______________________________________________________
@@ -185,13 +184,13 @@ void NumberCountingPdfFactory::AddExpDataWithSideband(Double_t* sigExp,
    // Arguements are an array of expected signal, expected background, and relative 
    // ratio of background expected in the sideband to that expected in signal region, and the number of channels.
 
-   Double_t* mainMeas = new Double_t[nbins];
-   Double_t* sideband = new Double_t[nbins];
+   std::vector<Double_t> mainMeas(nbins);
+   std::vector<Double_t> sideband(nbins);
    for(Int_t i=0; i<nbins; ++i){
       mainMeas[i] = sigExp[i] + backExp[i];
       sideband[i] = backExp[i]*tau[i];
    }
-   return AddDataWithSideband(mainMeas, sideband, tau, nbins, ws, dsName);
+   return AddDataWithSideband(&mainMeas[0], &sideband[0], tau, nbins, ws, dsName);
 
 }
 
@@ -239,8 +238,8 @@ void NumberCountingPdfFactory::AddData(Double_t* mainMeas,
    TList observablesCollection;
 
    TTree* tree = new TTree();
-   Double_t* xForTree = new Double_t[nbins];
-   Double_t* yForTree = new Double_t[nbins];
+   std::vector<Double_t> xForTree(nbins);
+   std::vector<Double_t> yForTree(nbins);
 
    // loop over channels
    for(Int_t i=0; i<nbins; ++i){
@@ -274,8 +273,8 @@ void NumberCountingPdfFactory::AddData(Double_t* mainMeas,
       xForTree[i] = mainMeas[i];
       yForTree[i] = back[i]*_tau;
 
-      tree->Branch(("x"+str.str()).c_str(), xForTree+i ,("x"+str.str()+"/D").c_str());
-      tree->Branch(("y"+str.str()).c_str(), yForTree+i ,("y"+str.str()+"/D").c_str());
+      tree->Branch(("x"+str.str()).c_str(), &xForTree[i] ,("x"+str.str()+"/D").c_str());
+      tree->Branch(("y"+str.str()).c_str(), &yForTree[i] ,("y"+str.str()+"/D").c_str());
 
       ws->var(("b"+str.str()).c_str())->setMax( 1.2*back[i]+MaxSigma*(sqrt(back[i])+back[i]*back_syst[i]) );
       ws->var(("b"+str.str()).c_str())->setVal( back[i] );
@@ -319,8 +318,10 @@ void NumberCountingPdfFactory::AddDataWithSideband(Double_t* mainMeas,
    TList observablesCollection;
 
    TTree* tree = new TTree();
-   Double_t* xForTree = new Double_t[nbins];
-   Double_t* yForTree = new Double_t[nbins];
+
+   std::vector<Double_t> xForTree(nbins);
+   std::vector<Double_t> yForTree(nbins);
+
 
    // loop over channels
    for(Int_t i=0; i<nbins; ++i){
@@ -355,8 +356,8 @@ void NumberCountingPdfFactory::AddDataWithSideband(Double_t* mainMeas,
       xForTree[i] = mainMeas[i];
       yForTree[i] = sideband[i];
 
-      tree->Branch(("x"+str.str()).c_str(), xForTree+i ,("x"+str.str()+"/D").c_str());
-      tree->Branch(("y"+str.str()).c_str(), yForTree+i ,("y"+str.str()+"/D").c_str());
+      tree->Branch(("x"+str.str()).c_str(), &xForTree[i] ,("x"+str.str()+"/D").c_str());
+      tree->Branch(("y"+str.str()).c_str(), &yForTree[i] ,("y"+str.str()+"/D").c_str());
 
       ws->var(("b"+str.str()).c_str())->setMax(  1.2*back+MaxSigma*(sqrt(back)+back*back_syst) );
       ws->var(("b"+str.str()).c_str())->setVal( back );

roofit/roostats/src/PointSetInterval.cxx

@@ -143,7 +143,7 @@ Bool_t PointSetInterval::CheckParameters(const RooArgSet &parameterPoint) const
 Double_t PointSetInterval::UpperLimit(RooRealVar& param ) 
 {  
   RooDataSet*  tree = dynamic_cast<RooDataSet*>(  fParameterPointsInInterval );
-  Double_t low, high;
+  Double_t low = 0, high = 0;
   if( tree ){
     tree->getRange(param, low, high);
     return high;
@@ -155,7 +155,7 @@ Double_t PointSetInterval::UpperLimit(RooRealVar& param )
 Double_t PointSetInterval::LowerLimit(RooRealVar& param ) 
 {  
   RooDataSet*  tree = dynamic_cast<RooDataSet*>(  fParameterPointsInInterval );
-  Double_t low, high;
+  Double_t low = 0, high = 0;
   if( tree ){
     tree->getRange(param, low, high);
     return low;