Skip to content
  • Darrick J. Wong's avatar
    xfs: annotate grabbing the realtime bitmap/summary locks in growfs · ace74e79
    Darrick J. Wong authored
    
    
    Use XFS_ILOCK_RT{BITMAP,SUM} to annotate grabbing the rt bitmap and
    summary locks when we grow the realtime volume, just like we do most
    everywhere else.  This shuts up lockdep warnings about grabbing the
    ILOCK class of locks recursively:
    
    ============================================
    WARNING: possible recursive locking detected
    5.9.0-rc4-djw #rc4 Tainted: G           O
    --------------------------------------------
    xfs_growfs/4841 is trying to acquire lock:
    ffff888035acc230 (&xfs_nondir_ilock_class){++++}-{3:3}, at: xfs_ilock+0xac/0x1a0 [xfs]
    
    but task is already holding lock:
    ffff888035acedb0 (&xfs_nondir_ilock_class){++++}-{3:3}, at: xfs_ilock+0xac/0x1a0 [xfs]
    
    other info that might help us debug this:
     Possible unsafe locking scenario:
    
           CPU0
           ----
      lock(&xfs_nondir_ilock_class);
      lock(&xfs_nondir_ilock_class);
    
     *** DEADLOCK ***
    
     May be due to missing lock nesting notation
    
    Signed-off-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
    Reviewed-by: default avatarChandan Babu R <chandanrlinux@gmail.com>
    ace74e79