Commit c2a93974 authored by Mike Christie's avatar Mike Christie Committed by Guillaume Abrioux
Browse files

iscsi: Fix crashes during rolling update

During a rolling update we will run the ceph iscsigw tasks that start
the daemons then run the configure_iscsi.yml tasks which can create
iscsi objects like targets, disks, clients, etc. The problem is that
once the daemons are started they will accept confifguration requests,
or may want to update the system themself. Those operations can then
conflict with the configure_iscsi.yml tasks that setup objects and we
can end up in crashes due to the kernel being in a unsupported state.

This could also happen during creation, but is less likely due to no
objects being setup yet, so there are no watchers or users accessing the
gws yet. The fix in this patch works for both update and initial setup.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1795806

Signed-off-by: default avatarMike Christie <mchristi@redhat.com>
(cherry picked from commit 77f3b5d5)
parent b7a21d94
......@@ -20,6 +20,10 @@
when:
- not containerized_deployment
- name: include non-container/postrequisites.yml
include_tasks: non-container/postrequisites.yml
when: not containerized_deployment | bool
- name: include containerized.yml
include_tasks: container/containerized.yml
when:
......
- name: start rbd-target-api and rbd-target-gw
service:
name: "{{ item }}"
state: started
enabled: yes
masked: no
with_items:
- rbd-target-gw
- rbd-target-api
......@@ -89,14 +89,13 @@
- target.stat.exists
- target.stat.islnk == False
- name: enable the rbd-target-gw service and make sure it is running
# Only start tcmu-runner, so configure_iscsi.yml can create disks.
# We must start rbd-target-gw/api after configure_iscsi.yml to avoid
# races where they are both trying to setup the same object during
# a rolling update.
- name: start tcmu-runner
service:
name: rbd-target-gw
enabled: yes
name: tcmu-runner
state: started
- name: enable the rbd-target-api service and make sure it is running
service:
name: rbd-target-api
enabled: yes
state: started
masked: no
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment