From b509135ecc16450e0288b2da3c42e38f0b4752e8 Mon Sep 17 00:00:00 2001
From: Jakob Blomer <jblomer@cern.ch>
Date: Tue, 26 Mar 2019 15:06:05 +0100
Subject: [PATCH] [forest] fix smaller review comments
---
tree/forest/v7/inc/ROOT/RColumn.hxx | 2 +-
tree/forest/v7/inc/ROOT/RForest.hxx | 1 -
tree/forest/v7/inc/ROOT/RPage.hxx | 1 +
3 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tree/forest/v7/inc/ROOT/RColumn.hxx b/tree/forest/v7/inc/ROOT/RColumn.hxx
index 96348858aed..d9abc0f9989 100644
--- a/tree/forest/v7/inc/ROOT/RColumn.hxx
+++ b/tree/forest/v7/inc/ROOT/RColumn.hxx
@@ -63,7 +63,7 @@ private:
RColumn* fOffsetColumn;
public:
- RColumn(const RColumnModel& model);
+ explicit RColumn(const RColumnModel& model);
RColumn(const RColumn&) = delete;
RColumn& operator =(const RColumn&) = delete;
~RColumn() = default;
diff --git a/tree/forest/v7/inc/ROOT/RForest.hxx b/tree/forest/v7/inc/ROOT/RForest.hxx
index a972857e4ee..e403fb77b61 100644
--- a/tree/forest/v7/inc/ROOT/RForest.hxx
+++ b/tree/forest/v7/inc/ROOT/RForest.hxx
@@ -85,7 +85,6 @@ Individual fields can be read as well by instantiating a tree view.
class RInputForest : public Detail::RForest {
private:
std::unique_ptr<Detail::RPageSource> fSource;
- ForestSize_t fNEntries;
public:
static std::unique_ptr<RInputForest> Create(std::unique_ptr<RForestModel> model,
diff --git a/tree/forest/v7/inc/ROOT/RPage.hxx b/tree/forest/v7/inc/ROOT/RPage.hxx
index 21f15d805af..56b49c48814 100644
--- a/tree/forest/v7/inc/ROOT/RPage.hxx
+++ b/tree/forest/v7/inc/ROOT/RPage.hxx
@@ -19,6 +19,7 @@
#include <ROOT/RForestUtil.hxx>
#include <cstddef>
+#include <cstdint>
namespace ROOT {
namespace Experimental {
--
GitLab