From 655af18ec21e7036652394e5d2a945d579b4c58d Mon Sep 17 00:00:00 2001
From: Sergey Linev <S.Linev@gsi.de>
Date: Thu, 11 Mar 2021 11:42:44 +0100
Subject: [PATCH] [ui5] remove unreachable code and duplicated variables
Detected by DeppCode
---
ui5/canv/controller/SVGSample.js | 2 --
ui5/eve7/controller/EveTable.controller.js | 4 +---
ui5/eve7/lib/EveElements.js | 3 +--
3 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/ui5/canv/controller/SVGSample.js b/ui5/canv/controller/SVGSample.js
index 22a46a7edb3..f108266e25b 100644
--- a/ui5/canv/controller/SVGSample.js
+++ b/ui5/canv/controller/SVGSample.js
@@ -87,6 +87,4 @@ sap.ui.define([
});
- return SVGSample;
-
});
diff --git a/ui5/eve7/controller/EveTable.controller.js b/ui5/eve7/controller/EveTable.controller.js
index 740eb2b240b..8e66d4f9dbf 100644
--- a/ui5/eve7/controller/EveTable.controller.js
+++ b/ui5/eve7/controller/EveTable.controller.js
@@ -94,9 +94,7 @@ sap.ui.define([
},
sortTable: function (e) {
- var col = e.mParameters.column;
- var colId = col.getId();
-
+ // var colId = col.getId();
var col = e.mParameters.column;
var bDescending = (e.mParameters.sortOrder == sap.ui.core.SortOrder.Descending);
var sv = bDescending;
diff --git a/ui5/eve7/lib/EveElements.js b/ui5/eve7/lib/EveElements.js
index 398c820998d..dcf74f875bd 100644
--- a/ui5/eve7/lib/EveElements.js
+++ b/ui5/eve7/lib/EveElements.js
@@ -268,7 +268,6 @@ sap.ui.define(['rootui5/eve7/lib/EveManager'], function(EveManager) {
{
var fcol = jsrp.getColor(ebox.fMainColor);
var boxMaterial = new THREE.MeshPhongMaterial({color: fcol, flatShading: true});
- var fcol = jsrp.getColor(ebox.fMainColor);
// console.log("EveElements.prototype.makeFlatBox triangulate", idxBegin, idxEnd);
let nTriang = (idxEnd - idxBegin) -2;
@@ -707,7 +706,7 @@ sap.ui.define(['rootui5/eve7/lib/EveManager'], function(EveManager) {
Calo2DControl.prototype.extractIndex = function(intersect)
{
let idx = Math.floor(intersect.faceIndex/2);
- return idx;ls
+ return idx;
}
Calo2DControl.prototype.getTooltipText = function(intersect)
--
GitLab