From 42da2894c3ffc741df0e87d7aa8d92bc582043ba Mon Sep 17 00:00:00 2001
From: Rene Brun <Rene.Brun@cern.ch>
Date: Mon, 17 Sep 2007 16:19:59 +0000
Subject: [PATCH] From Axel: This patch reduces
roottest/root/io/geom/runreadGeo.C from 50sec to 21sec, by building the list
using AddLast() instead of AddAt(i).
Now it spends 1/3 of its time in TObjArray::IndexOf() which is called by
~TGeoBBox -> ~TGeoShape -> TObjArray::Remove, at TGeoShape.cxx:194:
if (gGeoManager) gGeoManager->GetListOfShapes()->Remove(this);
git-svn-id: http://root.cern.ch/svn/root/trunk@19808 27541ba8-7e3a-0410-8455-c3a389f83636
---
geom/src/TGeoManager.cxx | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/geom/src/TGeoManager.cxx b/geom/src/TGeoManager.cxx
index 6ffb235db77..9b9a8c8f4d4 100644
--- a/geom/src/TGeoManager.cxx
+++ b/geom/src/TGeoManager.cxx
@@ -1,4 +1,4 @@
-// @(#)root/geom:$Name: $:$Id: TGeoManager.cxx,v 1.189 2007/09/10 14:28:49 brun Exp $
+// @(#)root/geom:$Name: $:$Id: TGeoManager.cxx,v 1.190 2007/09/12 16:59:59 brun Exp $
// Author: Andrei Gheata 25/10/01
/*************************************************************************
@@ -1398,8 +1398,8 @@ void TGeoManager::CloseGeometry(Option_t *option)
fHashVolumes = new THashList(nvol+1);
fHashGVolumes = new THashList(ngvol+1);
Int_t i;
- for (i=0; i<ngvol; i++) fHashGVolumes->AddAt(fGVolumes->At(i),i);
- for (i=0; i<nvol; i++) fHashVolumes->AddAt(fVolumes->At(i),i);
+ for (i=0; i<ngvol; i++) fHashGVolumes->AddLast(fGVolumes->At(i));
+ for (i=0; i<nvol; i++) fHashVolumes->AddLast(fVolumes->At(i));
}
Info("CloseGeometry","%i nodes/ %i volume UID's in %s", fNNodes, fUniqueVolumes->GetEntriesFast()-1, GetTitle());
@@ -2470,8 +2470,8 @@ TGeoVolume *TGeoManager::FindVolumeFast(const char *name, Bool_t multi)
fHashVolumes = new THashList(nvol+1);
fHashGVolumes = new THashList(ngvol+1);
Int_t i;
- for (i=0; i<ngvol; i++) fHashGVolumes->AddAt(fGVolumes->At(i),i);
- for (i=0; i<nvol; i++) fHashVolumes->AddAt(fVolumes->At(i),i);
+ for (i=0; i<ngvol; i++) fHashGVolumes->AddLast(fGVolumes->At(i));
+ for (i=0; i<nvol; i++) fHashVolumes->AddLast(fVolumes->At(i));
}
TString sname = name;
sname = sname.Strip();
--
GitLab