From 39a57d10fcf305d051b1fa3f2fdb1192920539b1 Mon Sep 17 00:00:00 2001
From: Fons Rademakers <Fons.Rademakers@cern.ch>
Date: Wed, 9 Dec 2009 10:05:46 +0000
Subject: [PATCH] From Coverity: remove incorrect assignment and copy ctor,
describe them unimplemented.
git-svn-id: http://root.cern.ch/svn/root/trunk@31717 27541ba8-7e3a-0410-8455-c3a389f83636
---
core/base/inc/TTask.h | 4 ++--
core/base/src/TTask.cxx | 35 ++++++-----------------------------
2 files changed, 8 insertions(+), 31 deletions(-)
diff --git a/core/base/inc/TTask.h b/core/base/inc/TTask.h
index 4df73dae5cb..d9d0cbd2e4c 100644
--- a/core/base/inc/TTask.h
+++ b/core/base/inc/TTask.h
@@ -44,12 +44,12 @@ protected:
static TTask *fgBeginTask; //pointer to task initiator
static TTask *fgBreakPoint; //pointer to current break point
- TTask& operator=(const TTask& tt);
+ TTask(const TTask &task); // not implemented
+ TTask& operator=(const TTask& tt); // not implemented
public:
TTask();
TTask(const char* name, const char *title);
- TTask(const TTask &task);
virtual ~TTask();
virtual void Abort(); // *MENU*
diff --git a/core/base/src/TTask.cxx b/core/base/src/TTask.cxx
index 7c5135d78cd..e7bcb7c1a1d 100644
--- a/core/base/src/TTask.cxx
+++ b/core/base/src/TTask.cxx
@@ -96,9 +96,9 @@ TTask::TTask()
fHasExecuted = kFALSE;
fActive = kTRUE;
- fBreakin = 0;
- fBreakout = 0;
- fTasks = 0;
+ fBreakin = 0;
+ fBreakout = 0;
+ fTasks = 0;
}
//______________________________________________________________________________
@@ -109,25 +109,9 @@ TTask::TTask(const char* name, const char *title)
fHasExecuted = kFALSE;
fActive = kTRUE;
- fBreakin = 0;
- fBreakout = 0;
- fTasks = new TList();
-}
-
-//______________________________________________________________________________
-TTask& TTask::operator=(const TTask& tt)
-{
- //assignment operator
- if(this!=&tt) {
- TNamed::operator=(tt);
- fTasks=tt.fTasks;
- fOption=tt.fOption;
- fBreakin=tt.fBreakin;
- fBreakout=tt.fBreakout;
- fHasExecuted=tt.fHasExecuted;
- fActive=tt.fActive;
- }
- return *this;
+ fBreakin = 0;
+ fBreakout = 0;
+ fTasks = new TList();
}
//______________________________________________________________________________
@@ -140,13 +124,6 @@ TTask::~TTask()
delete fTasks;
}
-//______________________________________________________________________________
-TTask::TTask(const TTask &task) : TNamed(task)
-{
- // Copy constructos.
- fTasks = new TList();
-}
-
//______________________________________________________________________________
void TTask::Abort()
{
--
GitLab