From 2278fb99ed8cd7ee90b8a859fd1407e38882a017 Mon Sep 17 00:00:00 2001
From: Danilo Piparo <danilo.piparo@cern.ch>
Date: Mon, 21 Jan 2019 21:20:02 +0100
Subject: [PATCH] [DictGen] Remove compilation warning

and correct inconsistency in help printout.
---
 core/dictgen/src/rootcling_impl.cxx | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/core/dictgen/src/rootcling_impl.cxx b/core/dictgen/src/rootcling_impl.cxx
index 59a2bfaca1f..db848343734 100644
--- a/core/dictgen/src/rootcling_impl.cxx
+++ b/core/dictgen/src/rootcling_impl.cxx
@@ -3830,7 +3830,7 @@ int RootClingMain(int argc,
       fprintf(stderr,
               shortHelp,
               argv[0]);
-      fprintf(stderr, "For more extensive help type: %s -h\n", argv[0]);
+      fprintf(stderr, "For more extensive help type: %s --help\n", argv[0]);
       return 1;
    }
 
@@ -3923,14 +3923,13 @@ int RootClingMain(int argc,
       ignoreExistingDict = true;
       ic++;
    } else if (argc > 1 && (!strcmp(argv[1], "-?") || !strcmp(argv[1], "-h"))) {
-      fprintf(stderr, shortHelp);
+      fprintf(stderr, "%s\n", shortHelp);
       return 1;
    } else if (argc > 1 && !strcmp(argv[1], "--help")) {
       fprintf(stderr, kCommandLineOptionsHelp);
       return 1;
    } else if (ic < argc && !strncmp(argv[ic], "-", 1)) {
-      fprintf(stderr, shortHelp,
-              argv[0]);
+      fprintf(stderr, "%s\n", shortHelp);
       fprintf(stderr, "Only one verbose flag is authorized (one of -v, -v0, -v1, -v2, -v3, -v4)\n"
               "and must be before the -f flags\n");
       fprintf(stderr, "For more extensive help type: %s --help\n", argv[0]);
-- 
GitLab