Commit ffaf62a8 authored by Masahiro Yamada's avatar Masahiro Yamada
Browse files

scripts/setlocalversion: add more comments to -dirty flag detection

This script stumbled on the read-only source tree over again:

 - a2bb90a0 ("kbuild: fix delay in setlocalversion on readonly
   source")

 - cdf2bc63 ("scripts/setlocalversion on write-protected source
   tree")

 - 8ef14c2c ("Revert "scripts/setlocalversion: git: Make -dirty
   check more robust"")

 - ff64dd48

 ("scripts/setlocalversion: Improve -dirty check with
   git-status --no-optional-locks")

Add comments to clarify that this script should never ever try to write
to the source tree.

'git describe --dirty' might look as a simple solution for appending
the -dirty string, but we cannot use it because it creates the
.git/index.lock file.
Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
Reviewed-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: default avatarNico Schottelius <nico-linuxsetlocalversion@schottelius.org>
parent a2be76a3
......@@ -80,6 +80,10 @@ scm_version()
fi
# Check for uncommitted changes.
# This script must avoid any write attempt to the source tree,
# which might be read-only.
# You cannot use 'git describe --dirty' because it tries to
# create .git/index.lock .
# First, with git-status, but --no-optional-locks is only
# supported in git >= 2.14, so fall back to git-diff-index if
# it fails. Note that git-diff-index does not refresh the
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment