Skip to content
  • Masahiro Yamada's avatar
    kbuild: avoid split lines in .mod files · 7d32358b
    Masahiro Yamada authored
    "xargs echo" is not a safe way to remove line breaks because the input
    may exceed the command line limit and xargs may break it up into
    multiple invocations of echo. This should never happen because
    scripts/gen_autoksyms.sh expects all undefined symbols are placed in
    the second line of .mod files.
    
    One possible way is to replace "xargs echo" with
    "sed ':x;N;$!bx;s/\n/ /g'" or something, but I rewrote the code by
    using awk because it is more readable.
    
    This issue was reported by Sami Tolvanen; in his Clang LTO patch set,
    $(multi-used-m) is no longer an ELF object, but a thin archive that
    contains LLVM bitcode files. llvm-nm prints out symbols for each
    archive member separately, which results a lot of dupications, in some
    places, beyond the system-defined limit.
    
    This problem must be fixed irrespective of LTO, and we must ensure
    zero possibility of having this issue.
    
    Link: https://lkml.org/lkml/2020/12/1/1658
    
    
    Reported-by: default avatarSami Tolvanen <samitolvanen@google.com>
    Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
    Reviewed-by: default avatarSami Tolvanen <samitolvanen@google.com>
    7d32358b